[0/4] Use lock guard macros in block

Message

Gan Qixin Nov. 9, 2020, 3:43 p.m. UTC

Hi all,
  I saw some tasks to replace manual lock()/unlock() calls with lock guard macros in BiteSizedTasks.
I am very interested in this and modified some of the files under block. Could someone help me check the code?

Thanks,
Gan Qixin

Gan Qixin (4):
  block/accounting.c: Use lock guard macros
  block/curl.c: Use lock guard macros
  block/throttle-groups.c: Use lock guard macros
  block/iscsi.c: Use lock guard macros

 block/accounting.c      | 32 +++++++++++++--------------
 block/curl.c            | 28 ++++++++++++------------
 block/iscsi.c           | 28 +++++++++++-------------
 block/throttle-groups.c | 48 ++++++++++++++++++++---------------------
 4 files changed, 65 insertions(+), 71 deletions(-)

Comments

Markus Armbruster Dec. 2, 2020, 9:22 a.m. UTC | #1

Did this fall through the cracks?

Gan Qixin <[e-mail]> writes:

> Hi all,
>   I saw some tasks to replace manual lock()/unlock() calls with lock guard macros in BiteSizedTasks.
> I am very interested in this and modified some of the files under block. Could someone help me check the code?
>
> Thanks,
> Gan Qixin
>
> Gan Qixin (4):
>   block/accounting.c: Use lock guard macros
>   block/curl.c: Use lock guard macros
>   block/throttle-groups.c: Use lock guard macros
>   block/iscsi.c: Use lock guard macros
>
>  block/accounting.c      | 32 +++++++++++++--------------
>  block/curl.c            | 28 ++++++++++++------------
>  block/iscsi.c           | 28 +++++++++++-------------
>  block/throttle-groups.c | 48 ++++++++++++++++++++---------------------
>  4 files changed, 65 insertions(+), 71 deletions(-)

Paolo Bonzini Dec. 2, 2020, 9:33 a.m. UTC | #2

On 02/12/20 10:22, Markus Armbruster wrote:
> Did this fall through the cracks?
> 
> Gan Qixin <[e-mail]> writes:
> 
>> Hi all,
>>    I saw some tasks to replace manual lock()/unlock() calls with lock guard macros in BiteSizedTasks.
>> I am very interested in this and modified some of the files under block. Could someone help me check the code?
>>
>> Thanks,
>> Gan Qixin
>>
>> Gan Qixin (4):
>>    block/accounting.c: Use lock guard macros
>>    block/curl.c: Use lock guard macros
>>    block/throttle-groups.c: Use lock guard macros
>>    block/iscsi.c: Use lock guard macros
>>
>>   block/accounting.c      | 32 +++++++++++++--------------
>>   block/curl.c            | 28 ++++++++++++------------
>>   block/iscsi.c           | 28 +++++++++++-------------
>>   block/throttle-groups.c | 48 ++++++++++++++++++++---------------------
>>   4 files changed, 65 insertions(+), 71 deletions(-)
> 

Yes, it did.

Reviewed-by: Paolo Bonzini <[e-mail]>

Paolo