From patchwork Tue Nov 17 16:30:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Wolf X-Patchwork-Id: 11912721 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9F2C71391 for ; Tue, 17 Nov 2020 16:32:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF40924248 for ; Tue, 17 Nov 2020 16:32:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XSqCF/a2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF40924248 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:37756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kf3uX-0003uj-7M for patchwork-qemu-devel@patchwork.kernel.org; Tue, 17 Nov 2020 11:32:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kf3sq-0001wW-A3 for qemu-devel@nongnu.org; Tue, 17 Nov 2020 11:31:08 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:54968) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kf3sk-0007qT-Mj for qemu-devel@nongnu.org; Tue, 17 Nov 2020 11:31:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605630661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BEH02/8kgiEl4Gtl/jQhChTxgT5r4TPqVTXOYy3xqX8=; b=XSqCF/a2ICquju3FkZuZJLsREVCPfQiq/Bcf8SbrYYhN6J6KeWSelwO7IleS1PSLlukOqA mp2WPObrjKjYalborjdDsgUncIDnZgu2CtB0kx5M0deX6+KsAxHHKJdqVXzef6HJQemk3M n9w3/72NSBQLYhANEZ0MLrzE9a7NhD8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-386-GYk23HxfORaXASNJwaRERw-1; Tue, 17 Nov 2020 11:30:59 -0500 X-MC-Unique: GYk23HxfORaXASNJwaRERw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 42667188C12C for ; Tue, 17 Nov 2020 16:30:58 +0000 (UTC) Received: from merkur.redhat.com (ovpn-114-113.ams2.redhat.com [10.36.114.113]) by smtp.corp.redhat.com (Postfix) with ESMTP id 640166EF52; Tue, 17 Nov 2020 16:30:57 +0000 (UTC) From: Kevin Wolf To: qemu-devel@nongnu.org Subject: [PATCH for-5.2? 0/2] authz: Add missing NULL checks Date: Tue, 17 Nov 2020 17:30:43 +0100 Message-Id: <20201117163045.307451-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=63.128.21.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/17 00:41:22 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, berrange@redhat.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" While trying to write a QAPI schema for user creatable object types, I have to figure out whether properties are mandatory or options. Turns out that some authz object types have properties that should be mandatory because the code assumes they are non-NULL, but we never check that they are actually given. Kevin Wolf (2): authz-pam: Check that 'service' property is set authz-simple: Check that 'identity' property is set authz/pamacct.c | 6 ++++++ authz/simple.c | 14 ++++++++++++++ 2 files changed, 20 insertions(+)