From patchwork Fri Nov 20 23:41:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kurz X-Patchwork-Id: 11922907 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C38EC5519F for ; Fri, 20 Nov 2020 23:44:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F08A7223B0 for ; Fri, 20 Nov 2020 23:44:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F08A7223B0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kgG4Z-0007Ri-Gw for qemu-devel@archiver.kernel.org; Fri, 20 Nov 2020 18:44:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kgG2n-0005oQ-7F for qemu-devel@nongnu.org; Fri, 20 Nov 2020 18:42:21 -0500 Received: from us-smtp-delivery-44.mimecast.com ([205.139.111.44]:30492) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kgG2l-0003l9-L2 for qemu-devel@nongnu.org; Fri, 20 Nov 2020 18:42:20 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-116-9dTHljj-NZ2STFD1ozJHUQ-1; Fri, 20 Nov 2020 18:42:12 -0500 X-MC-Unique: 9dTHljj-NZ2STFD1ozJHUQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4BA0151A9; Fri, 20 Nov 2020 23:42:11 +0000 (UTC) Received: from bahia.redhat.com (ovpn-112-44.ams2.redhat.com [10.36.112.44]) by smtp.corp.redhat.com (Postfix) with ESMTP id CEDF760BFA; Fri, 20 Nov 2020 23:42:09 +0000 (UTC) From: Greg Kurz To: qemu-devel@nongnu.org Subject: [PATCH for-6.0 0/9] spapr: Perform hotplug sanity checks at pre-plug Date: Sat, 21 Nov 2020 00:41:59 +0100 Message-Id: <20201120234208.683521-1-groug@kaod.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=groug@kaod.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: kaod.org Received-SPF: softfail client-ip=205.139.111.44; envelope-from=groug@kaod.org; helo=us-smtp-delivery-44.mimecast.com X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mammedov , qemu-ppc@nongnu.org, Greg Kurz , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Igor recently suggested that instead of failing in spapr_drc_attach() at plug time we should rather check that the DRC is attachable at pre-plug time. This allows to error out before the hot-plugged device is even realized and to come up with simpler plug callbacks. sPAPR currently supports hotplug of PCI devices, PHBs, CPU cores, PC-DIMM/NVDIMM memory and TPM proxy devices. Some of these already do sanity checks at pre-plug that are sufficient to ensure the DRC are attachables. Some others don't even have a pre-plug handler. This series adds the missing pieces so that all failing conditions are caught at pre-plug time instead of plug time for all devices. Greg Kurz (9): spapr: Do PCI device hotplug sanity checks at pre-plug only spapr: Do NVDIMM/PC-DIMM device hotplug sanity checks at pre-plug only spapr: Fix pre-2.10 dummy ICP hack spapr: Set compat mode in spapr_reset_vcpu() spapr: Simplify error path of spapr_core_plug() spapr: Make PHB placement functions and spapr_pre_plug_phb() return status spapr: Do PHB hoplug sanity check at pre-plug spapr: Do TPM proxy hotplug sanity checks at pre-plug spapr: spapr_drc_attach() cannot fail include/hw/ppc/spapr.h | 2 +- include/hw/ppc/spapr_drc.h | 8 +- include/hw/ppc/spapr_nvdimm.h | 2 +- hw/ppc/spapr.c | 157 ++++++++++++++++------------------ hw/ppc/spapr_cpu_core.c | 13 +++ hw/ppc/spapr_drc.c | 8 +- hw/ppc/spapr_nvdimm.c | 11 +-- hw/ppc/spapr_pci.c | 43 +++++++--- 8 files changed, 138 insertions(+), 106 deletions(-)