Message ID | 20201202081854.4126071-1-pbonzini@redhat.com (mailing list archive) |
---|---|
Headers | show |
Series | Finish cleaning up qemu_init | expand |
Patchew URL: https://patchew.org/QEMU/20201202081854.4126071-1-pbonzini@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201202081854.4126071-1-pbonzini@redhat.com Subject: [PATCH 00/15] Finish cleaning up qemu_init === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20201202081854.4126071-1-pbonzini@redhat.com -> patchew/20201202081854.4126071-1-pbonzini@redhat.com - [tag update] patchew/20201207084042.7690-1-cfontana@suse.de -> patchew/20201207084042.7690-1-cfontana@suse.de Switched to a new branch 'test' 450811f monitor: allow quitting while in preconfig state dce3fd5 null-machine: do not create a default memdev e52482a memory: allow creating MemoryRegions before accelerators e951562 plugin: propagate errors c29889b qtest: add a QOM object for qtest f7526bf vl: make qemu_get_machine_opts static 5f1f6d1 machine: record whether nvdimm= was set 8e65049 machine: introduce MachineInitPhase 7c4cb1c chardev: do not use machine_init_done 0f1597f vl: move all generic initialization out of vl.c c55f69e vl: extract softmmu/globals.c 6df0eeb vl: extract softmmu/runstate.c 1c6bebb vl: allow -incoming defer with -preconfig 893660d vl: remove separate preconfig main_loop a028d58 remove preconfig state === OUTPUT BEGIN === 1/15 Checking commit a028d58a8e83 (remove preconfig state) ERROR: suspect code indent for conditional statements (4, 9) #27: FILE: hw/core/machine-qmp-cmds.c:289: + if (qdev_hotplug) { + error_setg(errp, "The command is permitted only before the machine has been created"); ERROR: line over 90 characters #28: FILE: hw/core/machine-qmp-cmds.c:290: + error_setg(errp, "The command is permitted only before the machine has been created"); WARNING: line over 80 characters #88: FILE: monitor/qmp-cmds.c:108: + error_setg(errp, "The command is permitted only before machine initialization"); ERROR: line over 90 characters #150: FILE: softmmu/qdev-monitor.c:1006: + error_setg(errp, "The command '%s' is permitted only after machine initialization has completed", WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #207: new file mode 100644 total: 3 errors, 2 warnings, 155 lines checked Patch 1/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/15 Checking commit 893660defe11 (vl: remove separate preconfig main_loop) WARNING: line over 80 characters #93: FILE: softmmu/vl.c:3279: + error_setg(errp, "The command is permitted only before machine initialization"); total: 0 errors, 1 warnings, 161 lines checked Patch 2/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/15 Checking commit 1c6bebbd00e1 (vl: allow -incoming defer with -preconfig) 4/15 Checking commit 6df0eeb3c804 (vl: extract softmmu/runstate.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #46: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #422: FILE: softmmu/runstate.c:372: + /* This happens for eg ^C at the terminal, so it's worth ERROR: Don't use '#' flag of printf format ('%#') in format strings, use '0x' prefix instead #532: FILE: softmmu/runstate.c:482: + qemu_log_mask(LOG_GUEST_ERROR, "\nHV crash parameters: (%#"PRIx64 ERROR: Don't use '#' flag of printf format ('%#') in format strings, use '0x' prefix instead #533: FILE: softmmu/runstate.c:483: + " %#"PRIx64" %#"PRIx64" %#"PRIx64" %#"PRIx64")\n", ERROR: Don't use '#' flag of printf format ('%#') in format strings, use '0x' prefix instead #533: FILE: softmmu/runstate.c:483: + " %#"PRIx64" %#"PRIx64" %#"PRIx64" %#"PRIx64")\n", ERROR: Don't use '#' flag of printf format ('%#') in format strings, use '0x' prefix instead #533: FILE: softmmu/runstate.c:483: + " %#"PRIx64" %#"PRIx64" %#"PRIx64" %#"PRIx64")\n", ERROR: Don't use '#' flag of printf format ('%#') in format strings, use '0x' prefix instead #533: FILE: softmmu/runstate.c:483: + " %#"PRIx64" %#"PRIx64" %#"PRIx64" %#"PRIx64")\n", WARNING: Block comments use a leading /* on a separate line #646: FILE: softmmu/runstate.c:596: + /* Cannot call qemu_system_shutdown_request directly because total: 5 errors, 3 warnings, 1585 lines checked Patch 4/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/15 Checking commit c55f69ec8bed (vl: extract softmmu/globals.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 ERROR: "foo* bar" should be "foo *bar" #92: FILE: softmmu/globals.c:38: +const char* keyboard_layout; WARNING: Block comments use a leading /* on a separate line #120: FILE: softmmu/globals.c:66: +/* The bytes in qemu_uuid are in the order specified by RFC4122, _not_ in the total: 1 errors, 2 warnings, 184 lines checked Patch 5/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/15 Checking commit 0f1597fd687a (vl: move all generic initialization out of vl.c) WARNING: line over 80 characters #56: FILE: hw/core/machine.c:1200: + qemu_register_reset(restore_boot_order, g_strdup(current_machine->boot_order)); WARNING: Block comments use a leading /* on a separate line #66: FILE: hw/core/machine.c:1210: + /* TODO: once all bus devices are qdevified, this should be done WARNING: Block comments use a trailing */ on a separate line #67: FILE: hw/core/machine.c:1211: + * when bus is created by qdev.c */ WARNING: Block comments use a leading /* on a separate line #88: FILE: hw/core/machine.c:1232: + /* This checkpoint is required by replay to separate prior clock WARNING: Block comments use * on subsequent lines #89: FILE: hw/core/machine.c:1233: + /* This checkpoint is required by replay to separate prior clock + reading from the other reads, because timer polling functions query WARNING: Block comments use a trailing */ on a separate line #90: FILE: hw/core/machine.c:1234: + clock values from the log. */ total: 0 errors, 6 warnings, 164 lines checked Patch 6/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/15 Checking commit 7c4cb1ca1ada (chardev: do not use machine_init_done) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #109: deleted file mode 100644 total: 0 errors, 1 warnings, 142 lines checked Patch 7/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/15 Checking commit 8e65049a2eac (machine: introduce MachineInitPhase) ERROR: line over 90 characters #27: FILE: hw/core/machine-qmp-cmds.c:290: + error_setg(errp, "The command is permitted only before the machine has been created"); WARNING: line over 80 characters #232: FILE: softmmu/qdev-monitor.c:640: + if ((hide || phase_check(PHASE_MACHINE_READY)) && bus && !qbus_is_hotpluggable(bus)) { WARNING: line over 80 characters #254: FILE: softmmu/qdev-monitor.c:664: + /* No bus, no machine hotplug handler --> device is not hotpluggable */ WARNING: line over 80 characters #255: FILE: softmmu/qdev-monitor.c:665: + error_setg(errp, "Device '%s' can not be hotplugged on this machine", WARNING: line over 80 characters #327: FILE: ui/console.c:1348: + } else if (console_type != GRAPHIC_CONSOLE || phase_check(PHASE_MACHINE_READY)) { total: 1 errors, 4 warnings, 250 lines checked Patch 8/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/15 Checking commit 5f1f6d1df6e6 (machine: record whether nvdimm= was set) 10/15 Checking commit f7526bf54d78 (vl: make qemu_get_machine_opts static) WARNING: line over 80 characters #33: FILE: accel/kvm/kvm-all.c:2072: + g_autofree char *kvm_type = object_property_get_str(OBJECT(current_machine), total: 0 errors, 1 warnings, 195 lines checked Patch 10/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/15 Checking commit c29889b0f815 (qtest: add a QOM object for qtest) WARNING: line over 80 characters #33: FILE: softmmu/qtest.c:855: +static bool qtest_server_start(Chardev *chr, const char *qtest_log, Error **errp) total: 0 errors, 1 warnings, 190 lines checked Patch 11/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/15 Checking commit e9515620c1bb (plugin: propagate errors) ERROR: line over 90 characters #64: FILE: plugins/loader.c:153: +static int plugin_load(struct qemu_plugin_desc *desc, const qemu_info_t *info, Error **errp) WARNING: line over 80 characters #73: FILE: plugins/loader.c:166: + error_setg(errp, "Could not load plugin %s: %s", desc->path, g_module_error()); WARNING: line over 80 characters #79: FILE: plugins/loader.c:171: + error_setg(errp, "Could not load plugin %s: %s", desc->path, g_module_error()); WARNING: line over 80 characters #87: FILE: plugins/loader.c:177: + error_setg(errp, "Could not load plugin %s: qemu_plugin_install is NULL", ERROR: line over 90 characters #95: FILE: plugins/loader.c:183: + error_setg(errp, "Could not load plugin %s: plugin does not declare API version %s", ERROR: line over 90 characters #104: FILE: plugins/loader.c:189: + error_setg(errp, "Could not load plugin %s: plugin requires API version %d, but " ERROR: line over 90 characters #112: FILE: plugins/loader.c:194: + error_setg(errp, "Could not load plugin %s: plugin requires API version %d, but " ERROR: line over 90 characters #124: FILE: plugins/loader.c:223: + error_setg(errp, "Could not load plugin %s: qemu_plugin_install returned error code %d", total: 5 errors, 3 warnings, 119 lines checked Patch 12/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/15 Checking commit e52482a2d2ad (memory: allow creating MemoryRegions before accelerators) WARNING: Block comments use a leading /* on a separate line #93: FILE: softmmu/vl.c:1718: + /* Allocation of large amounts of memory may delay total: 0 errors, 1 warnings, 66 lines checked Patch 13/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/15 Checking commit dce3fd5895a3 (null-machine: do not create a default memdev) 15/15 Checking commit 450811f89668 (monitor: allow quitting while in preconfig state) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201202081854.4126071-1-pbonzini@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com