[0/2] target/ppc: Fix detection of 64-bit MMU models

Message

Greg Kurz Dec. 9, 2020, 5:35 p.m. UTC

Stephane Duverger posted a patch to fix a miscomputation of the
'need_access_type' flag in ppc_tr_init_disas_context(), which can
cause QEMU to abort with 32-bit CPUs.

This series contains an extended version of Stephane's patch and
introduce an mmu_is_64bit() helper to avoid a similar confusion
in the future.

Greg Kurz (1):
  target/ppc: Introduce an mmu_is_64bit() helper

Stephane Duverger (1):
  ppc/translate: Use POWERPC_MMU_64 to detect 64-bit MMU models

 target/ppc/cpu-qom.h            |  5 +++++
 target/ppc/excp_helper.c        |  4 ++--
 target/ppc/machine.c            |  4 ++--
 target/ppc/mmu-hash64.c         |  2 +-
 target/ppc/mmu_helper.c         | 10 +++++-----
 target/ppc/translate.c          |  4 ++--
 target/ppc/translate_init.c.inc |  2 +-
 7 files changed, 18 insertions(+), 13 deletions(-)

Comments

David Gibson Dec. 10, 2020, 3:24 a.m. UTC | #1

On Wed, Dec 09, 2020 at 06:35:34PM +0100, Greg Kurz wrote:
> Stephane Duverger posted a patch to fix a miscomputation of the
> 'need_access_type' flag in ppc_tr_init_disas_context(), which can
> cause QEMU to abort with 32-bit CPUs.
> 
> This series contains an extended version of Stephane's patch and
> introduce an mmu_is_64bit() helper to avoid a similar confusion
> in the future.

Applied to ppc-for-6.0, thanks.

Really that whole mmu_model thing is a mess.  A mix of flags and an
enum, for something that should probably be class callbacks in most
cases.  But your patches certainly improve things.