[v5,0/4] qcow2: don't leave partially initialized file on image creation

Message

Maxim Levitsky Dec. 9, 2020, 8:33 p.m. UTC

Use the bdrv_co_delete_file interface to delete the underlying
file if qcow2 initialization fails (e.g due to bad encryption secret)

This makes the qcow2 driver behave the same way as the luks driver behaves.

Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1845353

V3: addressed review feedback and reworked commit messages

V4: got rid of code duplication by adding bdrv_co_delete_file_noerr
and made the qcow2 driver use this function to delete
both the main and the data file.

V5: addresssed review feedback on reworked version.

Best regards,
	Maxim Levitsky

Maxim Levitsky (4):
  crypto: luks: Fix tiny memory leak
  block: add bdrv_co_delete_file_noerr
  crypto: luks: use bdrv_co_delete_file_noerr
  block: qcow2: remove the created file on initialization error

 block.c               | 24 ++++++++++++++++++++++++
 block/crypto.c        | 13 ++-----------
 block/qcow2.c         |  6 ++++--
 include/block/block.h |  1 +
 4 files changed, 31 insertions(+), 13 deletions(-)