Message ID | 20201210121226.19822-1-cfontana@suse.de (mailing list archive) |
---|---|
Headers | show |
Series | i386 cleanup | expand |
Hi Claudio, On 12/10/20 1:11 PM, Claudio Fontana wrote: > Hello, this is version 10 of the cleanup, changed from RFC to PATCH. > > v9 -> v10: minor tweaks and fixes > > * in "i386: split cpu accelerators from cpu.c", > > use kvm/kvm-cpu.c, hvf/hvf-cpu.c, tcg/tcg-cpu.c. > Easier to understand compared to editing multiple cpu.c files, > and matches the header files if needed (kvm-cpu.h). > > * in "accel: replace struct CpusAccel with AccelOpsClass", > > make it a bit more consistent, by naming the files defining > the AccelOpsClass types "...-accel-ops.c" instead of the old > naming "...-cpus.c". > > * in "cpu: move cc->transaction_failed to tcg_ops", > > protect with CONFIG_TCG the use of tcg_ops for hw/misc/jazz.c, > > #include "exec/memattrs.h" (Philippe, Eduardo) > > * in "cpu: Move synchronize_from_tb() to tcg_ops", > > #include "hw/core/cpu.h" (Philippe, Eduardo) > > do not remove the comment about struct TcgCpuOperations (Philippe) > > * in "accel/tcg: split TCG-only code from cpu_exec_realizefn", > > invert tcg_target_initialized set order (Alex) > > * in "i386: move TCG cpu class initialization out of helper.c", > > extract helper-tcg.h, tcg-cpu.c, and tcg-cpu.h directly into > tcg/, avoiding the extra move later to tcg/ (Alex) > ... > Claudio Fontana (23): > accel/tcg: split CpusAccel into three TCG variants > accel/tcg: split tcg_start_vcpu_thread > accel/tcg: rename tcg-cpus functions to match module name > i386: move kvm accel files into kvm/ > i386: move whpx accel files into whpx/ > i386: move hax accel files into hax/ > i386: hvf: remove stale MAINTAINERS entry for old hvf stubs > i386: move TCG accel files into tcg/ > i386: move cpu dump out of helper.c into cpu-dump.c > i386: move TCG cpu class initialization out of helper.c > target/riscv: remove CONFIG_TCG, as it is always TCG > accel/tcg: split TCG-only code from cpu_exec_realizefn > target/arm: do not use cc->do_interrupt for KVM directly > cpu: move cc->do_interrupt to tcg_ops > cpu: move cc->transaction_failed to tcg_ops > cpu: move do_unaligned_access to tcg_ops To be honest this is a lot to digest... I'd split your series in 2, the first part until here, almost ready; And this second part, the accel refactor: > accel: extend AccelState and AccelClass to user-mode > accel: replace struct CpusAccel with AccelOpsClass > accel: introduce AccelCPUClass extending CPUClass > i386: split cpu accelerators from cpu.c, using AccelCPUClass > cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn > hw/core/cpu: call qemu_init_vcpu in cpu_common_realizefn > cpu: introduce cpu_accel_instance_init
On 12/10/20 2:05 PM, Philippe Mathieu-Daudé wrote: > Hi Claudio, > > On 12/10/20 1:11 PM, Claudio Fontana wrote: >> Hello, this is version 10 of the cleanup, changed from RFC to PATCH. >> >> v9 -> v10: minor tweaks and fixes >> >> * in "i386: split cpu accelerators from cpu.c", >> >> use kvm/kvm-cpu.c, hvf/hvf-cpu.c, tcg/tcg-cpu.c. >> Easier to understand compared to editing multiple cpu.c files, >> and matches the header files if needed (kvm-cpu.h). >> >> * in "accel: replace struct CpusAccel with AccelOpsClass", >> >> make it a bit more consistent, by naming the files defining >> the AccelOpsClass types "...-accel-ops.c" instead of the old >> naming "...-cpus.c". >> >> * in "cpu: move cc->transaction_failed to tcg_ops", >> >> protect with CONFIG_TCG the use of tcg_ops for hw/misc/jazz.c, >> >> #include "exec/memattrs.h" (Philippe, Eduardo) >> >> * in "cpu: Move synchronize_from_tb() to tcg_ops", >> >> #include "hw/core/cpu.h" (Philippe, Eduardo) >> >> do not remove the comment about struct TcgCpuOperations (Philippe) >> >> * in "accel/tcg: split TCG-only code from cpu_exec_realizefn", >> >> invert tcg_target_initialized set order (Alex) >> >> * in "i386: move TCG cpu class initialization out of helper.c", >> >> extract helper-tcg.h, tcg-cpu.c, and tcg-cpu.h directly into >> tcg/, avoiding the extra move later to tcg/ (Alex) >> > ... > >> Claudio Fontana (23): >> accel/tcg: split CpusAccel into three TCG variants >> accel/tcg: split tcg_start_vcpu_thread >> accel/tcg: rename tcg-cpus functions to match module name >> i386: move kvm accel files into kvm/ >> i386: move whpx accel files into whpx/ >> i386: move hax accel files into hax/ >> i386: hvf: remove stale MAINTAINERS entry for old hvf stubs >> i386: move TCG accel files into tcg/ >> i386: move cpu dump out of helper.c into cpu-dump.c >> i386: move TCG cpu class initialization out of helper.c >> target/riscv: remove CONFIG_TCG, as it is always TCG >> accel/tcg: split TCG-only code from cpu_exec_realizefn >> target/arm: do not use cc->do_interrupt for KVM directly >> cpu: move cc->do_interrupt to tcg_ops >> cpu: move cc->transaction_failed to tcg_ops >> cpu: move do_unaligned_access to tcg_ops > > To be honest this is a lot to digest... I'd split your > series in 2, the first part until here, almost ready; > > And this second part, the accel refactor: > >> accel: extend AccelState and AccelClass to user-mode >> accel: replace struct CpusAccel with AccelOpsClass >> accel: introduce AccelCPUClass extending CPUClass >> i386: split cpu accelerators from cpu.c, using AccelCPUClass >> cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn >> hw/core/cpu: call qemu_init_vcpu in cpu_common_realizefn >> cpu: introduce cpu_accel_instance_init > Ok, will do for the next spin Ciao, Claudio
Patchew URL: https://patchew.org/QEMU/20201210121226.19822-1-cfontana@suse.de/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201210121226.19822-1-cfontana@suse.de Subject: [PATCH v10 00/32] i386 cleanup === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20201210121226.19822-1-cfontana@suse.de -> patchew/20201210121226.19822-1-cfontana@suse.de Switched to a new branch 'test' 1bcd971 cpu: introduce cpu_accel_instance_init 95e993b hw/core/cpu: call qemu_init_vcpu in cpu_common_realizefn eb89e90 cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn a2f3734 i386: split cpu accelerators from cpu.c, using AccelCPUClass a40f023 accel: introduce AccelCPUClass extending CPUClass d53721a accel: replace struct CpusAccel with AccelOpsClass d2ae1b0 accel: extend AccelState and AccelClass to user-mode ccc236f cpu: move do_unaligned_access to tcg_ops acf874d cpu: move cc->transaction_failed to tcg_ops 47ef2ce cpu: move cc->do_interrupt to tcg_ops 6937842 target/arm: do not use cc->do_interrupt for KVM directly b7c16fe cpu: Move debug_excp_handler to tcg_ops 2648f3c cpu: Move tlb_fill to tcg_ops c0ecda2 cpu: Move cpu_exec_* to tcg_ops c54ef21 cpu: Move synchronize_from_tb() to tcg_ops 9ba5153 accel/tcg: split TCG-only code from cpu_exec_realizefn c981286 target/riscv: remove CONFIG_TCG, as it is always TCG 00e7acf cpu: Introduce TCGCpuOperations struct 9a97463 cpu: Remove unnecessary noop methods 6535aaa tcg: Make CPUClass.debug_excp_handler optional 6a0b105 tcg: make CPUClass.cpu_exec_* optional b7c8ad4 tcg: cpu_exec_{enter,exit} helpers 30e1c48 i386: move TCG cpu class initialization out of helper.c c1eaae4 i386: move cpu dump out of helper.c into cpu-dump.c f740a09 i386: move TCG accel files into tcg/ 88074e1 i386: hvf: remove stale MAINTAINERS entry for old hvf stubs 2289beb i386: move hax accel files into hax/ 2a99707 i386: move whpx accel files into whpx/ c3dcbe4 i386: move kvm accel files into kvm/ 4288994 accel/tcg: rename tcg-cpus functions to match module name cd3c5fe accel/tcg: split tcg_start_vcpu_thread 0af862d accel/tcg: split CpusAccel into three TCG variants === OUTPUT BEGIN === 1/32 Checking commit 0af862d5b32b (accel/tcg: split CpusAccel into three TCG variants) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #57: new file mode 100644 total: 0 errors, 1 warnings, 1156 lines checked Patch 1/32 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/32 Checking commit cd3c5fe91905 (accel/tcg: split tcg_start_vcpu_thread) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #103: deleted file mode 100644 total: 0 errors, 1 warnings, 201 lines checked Patch 2/32 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/32 Checking commit 4288994bd943 (accel/tcg: rename tcg-cpus functions to match module name) 4/32 Checking commit c3dcbe421f99 (i386: move kvm accel files into kvm/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #168: rename from target/i386/hyperv-proto.h total: 0 errors, 1 warnings, 150 lines checked Patch 4/32 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/32 Checking commit 2a99707b0cf3 (i386: move whpx accel files into whpx/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 32 lines checked Patch 5/32 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/32 Checking commit 2289beb5ca9e (i386: move hax accel files into hax/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: rename from target/i386/hax-all.c total: 0 errors, 1 warnings, 47 lines checked Patch 6/32 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/32 Checking commit 88074e1bc90a (i386: hvf: remove stale MAINTAINERS entry for old hvf stubs) 8/32 Checking commit f740a0915167 (i386: move TCG accel files into tcg/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #45: rename from target/i386/bpt_helper.c total: 0 errors, 1 warnings, 39 lines checked Patch 8/32 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/32 Checking commit c1eaae4b18dc (i386: move cpu dump out of helper.c into cpu-dump.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #12: new file mode 100644 ERROR: braces {} are necessary for all arms of this statement #129: FILE: target/i386/cpu-dump.c:113: + if (!(env->hflags & HF_PE_MASK) || !(sc->flags & DESC_P_MASK)) [...] WARNING: Block comments use a leading /* on a separate line #173: FILE: target/i386/cpu-dump.c:157: +/* ARRAY_SIZE check is not required because WARNING: Block comments use a leading /* on a separate line #212: FILE: target/i386/cpu-dump.c:196: +/* ARRAY_SIZE check is not required because ERROR: line over 90 characters #374: FILE: target/i386/cpu-dump.c:358: + qemu_fprintf(f, "RAX=%016" PRIx64 " RBX=%016" PRIx64 " RCX=%016" PRIx64 " RDX=%016" PRIx64 "\n" ERROR: line over 90 characters #375: FILE: target/i386/cpu-dump.c:359: + "RSI=%016" PRIx64 " RDI=%016" PRIx64 " RBP=%016" PRIx64 " RSP=%016" PRIx64 "\n" ERROR: line over 90 characters #376: FILE: target/i386/cpu-dump.c:360: + "R8 =%016" PRIx64 " R9 =%016" PRIx64 " R10=%016" PRIx64 " R11=%016" PRIx64 "\n" ERROR: line over 90 characters #377: FILE: target/i386/cpu-dump.c:361: + "R12=%016" PRIx64 " R13=%016" PRIx64 " R14=%016" PRIx64 " R15=%016" PRIx64 "\n" ERROR: line over 90 characters #378: FILE: target/i386/cpu-dump.c:362: + "RIP=%016" PRIx64 " RFL=%08x [%c%c%c%c%c%c%c] CPL=%d II=%d A20=%d SMM=%d HLT=%d\n", ERROR: space required before the open parenthesis '(' #437: FILE: target/i386/cpu-dump.c:421: + for(i = 0; i < 6; i++) { WARNING: line over 80 characters #449: FILE: target/i386/cpu-dump.c:433: + qemu_fprintf(f, "CR0=%08x CR2=%016" PRIx64 " CR3=%016" PRIx64 " CR4=%08x\n", ERROR: space required before the open parenthesis '(' #454: FILE: target/i386/cpu-dump.c:438: + for(i = 0; i < 4; i++) ERROR: braces {} are necessary for all arms of this statement #454: FILE: target/i386/cpu-dump.c:438: + for(i = 0; i < 4; i++) [...] ERROR: space required before the open parenthesis '(' #470: FILE: target/i386/cpu-dump.c:454: + for(i = 0; i < 4; i++) { ERROR: braces {} are necessary for all arms of this statement #477: FILE: target/i386/cpu-dump.c:461: + if ((unsigned)env->cc_op < CC_OP_NB) [...] + else [...] WARNING: line over 80 characters #478: FILE: target/i386/cpu-dump.c:462: + snprintf(cc_op_name, sizeof(cc_op_name), "%s", cc_op_str[env->cc_op]); ERROR: space required before the open parenthesis '(' #498: FILE: target/i386/cpu-dump.c:482: + for(i = 0; i < 8; i++) { ERROR: spaces required around that '=' (ctx:VxV) #508: FILE: target/i386/cpu-dump.c:492: + for(i=0;i<8;i++) { ^ ERROR: space required after that ';' (ctx:VxV) #508: FILE: target/i386/cpu-dump.c:492: + for(i=0;i<8;i++) { ^ ERROR: spaces required around that '<' (ctx:VxV) #508: FILE: target/i386/cpu-dump.c:492: + for(i=0;i<8;i++) { ^ ERROR: space required after that ';' (ctx:VxV) #508: FILE: target/i386/cpu-dump.c:492: + for(i=0;i<8;i++) { ^ ERROR: space required before the open parenthesis '(' #508: FILE: target/i386/cpu-dump.c:492: + for(i=0;i<8;i++) { ERROR: braces {} are necessary for all arms of this statement #513: FILE: target/i386/cpu-dump.c:497: + if ((i & 1) == 1) [...] + else [...] ERROR: braces {} are necessary for all arms of this statement #518: FILE: target/i386/cpu-dump.c:502: + if (env->hflags & HF_CS64_MASK) [...] + else [...] ERROR: spaces required around that '=' (ctx:VxV) #522: FILE: target/i386/cpu-dump.c:506: + for(i=0;i<nb;i++) { ^ ERROR: space required after that ';' (ctx:VxV) #522: FILE: target/i386/cpu-dump.c:506: + for(i=0;i<nb;i++) { ^ ERROR: spaces required around that '<' (ctx:VxV) #522: FILE: target/i386/cpu-dump.c:506: + for(i=0;i<nb;i++) { ^ ERROR: space required after that ';' (ctx:VxV) #522: FILE: target/i386/cpu-dump.c:506: + for(i=0;i<nb;i++) { ^ ERROR: space required before the open parenthesis '(' #522: FILE: target/i386/cpu-dump.c:506: + for(i=0;i<nb;i++) { ERROR: braces {} are necessary for all arms of this statement #529: FILE: target/i386/cpu-dump.c:513: + if ((i & 1) == 1) [...] + else [...] total: 25 errors, 5 warnings, 1077 lines checked Patch 9/32 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/32 Checking commit 30e1c4878f0f (i386: move TCG cpu class initialization out of helper.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #412: new file mode 100644 total: 0 errors, 1 warnings, 608 lines checked Patch 10/32 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/32 Checking commit b7c8ad4e5828 (tcg: cpu_exec_{enter,exit} helpers) 12/32 Checking commit 6a0b1053f6b2 (tcg: make CPUClass.cpu_exec_* optional) 13/32 Checking commit 6535aaab70c2 (tcg: Make CPUClass.debug_excp_handler optional) 14/32 Checking commit 9a97463bf2cc (cpu: Remove unnecessary noop methods) 15/32 Checking commit 00e7acfe8db6 (cpu: Introduce TCGCpuOperations struct) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #93: new file mode 100644 total: 0 errors, 1 warnings, 301 lines checked Patch 15/32 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/32 Checking commit c9812860bc1c (target/riscv: remove CONFIG_TCG, as it is always TCG) 17/32 Checking commit 9ba515321a3c (accel/tcg: split TCG-only code from cpu_exec_realizefn) 18/32 Checking commit c54ef21375b3 (cpu: Move synchronize_from_tb() to tcg_ops) 19/32 Checking commit c0ecda22af8d (cpu: Move cpu_exec_* to tcg_ops) 20/32 Checking commit 2648f3c39867 (cpu: Move tlb_fill to tcg_ops) WARNING: line over 80 characters #23: FILE: accel/tcg/cputlb.c:1289: + ok = cc->tcg_ops.tlb_fill(cpu, addr, size, access_type, mmu_idx, false, retaddr); total: 0 errors, 1 warnings, 259 lines checked Patch 20/32 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/32 Checking commit b7c16fe8f339 (cpu: Move debug_excp_handler to tcg_ops) 22/32 Checking commit 6937842b12fd (target/arm: do not use cc->do_interrupt for KVM directly) 23/32 Checking commit 47ef2ce4ddf7 (cpu: move cc->do_interrupt to tcg_ops) 24/32 Checking commit acf874dd3fc0 (cpu: move cc->transaction_failed to tcg_ops) WARNING: line over 80 characters #87: FILE: include/hw/core/cpu.h:857: + cc->tcg_ops.do_transaction_failed(cpu, physaddr, addr, size, access_type, total: 0 errors, 1 warnings, 168 lines checked Patch 24/32 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 25/32 Checking commit ccc236fa232a (cpu: move do_unaligned_access to tcg_ops) 26/32 Checking commit d2ae1b01f812 (accel: extend AccelState and AccelClass to user-mode) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 359 lines checked Patch 26/32 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 27/32 Checking commit d53721ae3d89 (accel: replace struct CpusAccel with AccelOpsClass) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #119: new file mode 100644 total: 0 errors, 1 warnings, 871 lines checked Patch 27/32 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 28/32 Checking commit a40f023b29ec (accel: introduce AccelCPUClass extending CPUClass) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #99: new file mode 100644 total: 0 errors, 1 warnings, 123 lines checked Patch 28/32 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 29/32 Checking commit a2f37349ca0b (i386: split cpu accelerators from cpu.c, using AccelCPUClass) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #664: new file mode 100644 WARNING: line over 80 characters #1299: FILE: target/i386/tcg/tcg-cpu.c:104: + memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, cpu->cpu_as_mem, 0); total: 0 errors, 2 warnings, 1249 lines checked Patch 29/32 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 30/32 Checking commit eb89e906358b (cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn) 31/32 Checking commit 95e993b2b19f (hw/core/cpu: call qemu_init_vcpu in cpu_common_realizefn) 32/32 Checking commit 1bcd9713e4e9 (cpu: introduce cpu_accel_instance_init) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201210121226.19822-1-cfontana@suse.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com