| Message ID | 20201211151300.85322-1-agraf@csgraf.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | hvf: Implement Apple Silicon Support | expand |
Patchew URL: https://patchew.org/QEMU/20201211151300.85322-1-agraf@csgraf.de/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20201211151300.85322-1-agraf@csgraf.de
Subject: [PATCH v5 00/11] hvf: Implement Apple Silicon Support
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20201210203549.379-1-peter.maydell@linaro.org -> patchew/20201210203549.379-1-peter.maydell@linaro.org
* [new tag] patchew/20201211151300.85322-1-agraf@csgraf.de -> patchew/20201211151300.85322-1-agraf@csgraf.de
- [tag update] patchew/20201211152426.350966-1-thuth@redhat.com -> patchew/20201211152426.350966-1-thuth@redhat.com
Switched to a new branch 'test'
56f4c6b hvf: arm: Implement -cpu host
b5c4db1 hvf: arm: Add support for GICv3
6c0280c arm/hvf: Add a WFI handler
26b170e arm: Add Hypervisor.framework build target
a8820bd hvf: Add Apple Silicon support
d0b5c38 hvf: Simplify post reset/init/loadvm hooks
d3c68ab arm: Set PSCI to 0.2 for HVF
360f48e hvf: Introduce hvf vcpu struct
87a09e8 hvf: Move common code out
ac925f0 hvf: x86: Remove unused definitions
c77ce16 hvf: Add hypervisor entitlement to output binaries
=== OUTPUT BEGIN ===
1/11 Checking commit c77ce16832fb (hvf: Add hypervisor entitlement to output binaries)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18:
new file mode 100644
total: 0 errors, 1 warnings, 62 lines checked
Patch 1/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/11 Checking commit ac925f0aaf18 (hvf: x86: Remove unused definitions)
3/11 Checking commit 87a09e81f925 (hvf: Move common code out)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41:
new file mode 100644
total: 0 errors, 1 warnings, 1054 lines checked
Patch 3/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/11 Checking commit 360f48eb839f (hvf: Introduce hvf vcpu struct)
WARNING: line over 80 characters
#142: FILE: target/i386/hvf/hvf.c:213:
+ wvmcs(cpu->hvf->fd, VMCS_ENTRY_CTLS, cap2ctrl(hvf_state->hvf_caps->vmx_cap_entry,
ERROR: "(foo*)" should be "(foo *)"
#750: FILE: target/i386/hvf/x86hvf.c:85:
+ if (hv_vcpu_write_fpstate(cpu_state->hvf->fd, (void*)xsave, 4096)) {
ERROR: "(foo*)" should be "(foo *)"
#831: FILE: target/i386/hvf/x86hvf.c:167:
+ if (hv_vcpu_read_fpstate(cpu_state->hvf->fd, (void*)xsave, 4096)) {
total: 2 errors, 1 warnings, 996 lines checked
Patch 4/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/11 Checking commit d3c68ab7fa96 (arm: Set PSCI to 0.2 for HVF)
6/11 Checking commit d0b5c38651d5 (hvf: Simplify post reset/init/loadvm hooks)
7/11 Checking commit a8820bd60f6a (hvf: Add Apple Silicon support)
WARNING: architecture specific defines should be avoided
#48: FILE: accel/hvf/hvf-cpus.c:61:
+#ifdef __aarch64__
WARNING: architecture specific defines should be avoided
#59: FILE: accel/hvf/hvf-cpus.c:335:
+#ifdef __aarch64__
WARNING: architecture specific defines should be avoided
#91: FILE: include/sysemu/hvf_int.h:15:
+#ifdef __aarch64__
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#117:
new file mode 100644
WARNING: line over 80 characters
#579: FILE: target/arm/hvf/hvf.c:458:
+ hv_vcpu_set_pending_interrupt(cpu->hvf->fd, HV_INTERRUPT_TYPE_FIQ, true);
WARNING: line over 80 characters
#584: FILE: target/arm/hvf/hvf.c:463:
+ hv_vcpu_set_pending_interrupt(cpu->hvf->fd, HV_INTERRUPT_TYPE_IRQ, true);
total: 0 errors, 6 warnings, 691 lines checked
Patch 7/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/11 Checking commit 26b170ee618a (arm: Add Hypervisor.framework build target)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49:
new file mode 100644
total: 0 errors, 1 warnings, 36 lines checked
Patch 8/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/11 Checking commit 6c0280c8b649 (arm/hvf: Add a WFI handler)
10/11 Checking commit b5c4db10905e (hvf: arm: Add support for GICv3)
11/11 Checking commit 56f4c6b7ff84 (hvf: arm: Implement -cpu host)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20201211151300.85322-1-agraf@csgraf.de/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Fri, Dec 11, 2020 at 04:12:49PM +0100, Alexander Graf wrote: > Now that Apple Silicon is widely available, people are obviously excited > to try and run virtualized workloads on them, such as Linux and Windows. > > This patch set implements a fully functional version to get the ball > going on that. With this applied, I can successfully run both Linux and > Windows as guests. I am not aware of any limitations specific to > Hypervisor.framework apart from: > > - Live migration / savevm > - gdbstub debugging (SP register) > > > Enjoy! I have been using a VM created using v4/v5 as my daily work machine since v4 came out so. Tested-by: Graeme Gregory <graeme@nuviainc.com> > > Alex > > v1 -> v2: > > - New patch: hvf: Actually set SIG_IPI mask > - New patch: hvf: Introduce hvf vcpu struct > - New patch: hvf: arm: Mark CPU as dirty on reset > - Removed patch: hw/arm/virt: Disable highmem when on hypervisor.framework > - Removed patch: arm: Synchronize CPU on PSCI on > - Fix build on 32bit arm > - Merge vcpu kick function patch into ARM enablement > - Implement WFI handling (allows vCPUs to sleep) > - Synchronize system registers (fixes OVMF crashes and reboot) > - Don't always call cpu_synchronize_state() > - Use more fine grained iothread locking > - Populate aa64mmfr0 from hardware > - Make safe to ctrl-C entitlement application > > v2 -> v3: > > - Removed patch: hvf: Actually set SIG_IPI mask > - New patch: hvf: arm: Add support for GICv3 > - New patch: hvf: arm: Implement -cpu host > - Advance PC on SMC > - Use cp list interface for sysreg syncs > - Do not set current_cpu > - Fix sysreg isread mask > - Move sysreg handling to functions > - Remove WFI logic again > - Revert to global iothread locking > > v3 -> v4: > > - Removed patch: hvf: arm: Mark CPU as dirty on reset > - New patch: hvf: Simplify post reset/init/loadvm hooks > - Remove i386-softmmu target (meson.build for hvf target) > - Combine both if statements (PSCI) > - Use hv.h instead of Hypervisor.h for 10.15 compat > - Remove manual inclusion of Hypervisor.h in common .c files > - No longer include Hypervisor.h in arm hvf .c files > - Remove unused exe_full variable > - Reuse exe_name variable > > v4 -> v5: > > - Use g_free() on destroy > > Alexander Graf (10): > hvf: Add hypervisor entitlement to output binaries > hvf: x86: Remove unused definitions > hvf: Move common code out > hvf: Introduce hvf vcpu struct > arm: Set PSCI to 0.2 for HVF > hvf: Simplify post reset/init/loadvm hooks > hvf: Add Apple Silicon support > arm: Add Hypervisor.framework build target > hvf: arm: Add support for GICv3 > hvf: arm: Implement -cpu host > > Peter Collingbourne (1): > arm/hvf: Add a WFI handler > > MAINTAINERS | 14 +- > accel/hvf/entitlements.plist | 8 + > accel/hvf/hvf-all.c | 54 +++ > accel/hvf/hvf-cpus.c | 466 +++++++++++++++++++ > accel/hvf/meson.build | 7 + > accel/meson.build | 1 + > include/hw/core/cpu.h | 3 +- > include/sysemu/hvf.h | 2 + > include/sysemu/hvf_int.h | 66 +++ > meson.build | 40 +- > scripts/entitlement.sh | 13 + > target/arm/cpu.c | 13 +- > target/arm/cpu.h | 2 + > target/arm/hvf/hvf.c | 856 +++++++++++++++++++++++++++++++++++ > target/arm/hvf/meson.build | 3 + > target/arm/kvm_arm.h | 2 - > target/arm/meson.build | 2 + > target/i386/hvf/hvf-cpus.c | 131 ------ > target/i386/hvf/hvf-cpus.h | 25 - > target/i386/hvf/hvf-i386.h | 49 +- > target/i386/hvf/hvf.c | 462 +++---------------- > target/i386/hvf/meson.build | 1 - > target/i386/hvf/vmx.h | 24 +- > target/i386/hvf/x86.c | 28 +- > target/i386/hvf/x86_descr.c | 26 +- > target/i386/hvf/x86_emu.c | 62 +-- > target/i386/hvf/x86_mmu.c | 4 +- > target/i386/hvf/x86_task.c | 12 +- > target/i386/hvf/x86hvf.c | 224 ++++----- > target/i386/hvf/x86hvf.h | 2 - > 30 files changed, 1786 insertions(+), 816 deletions(-) > create mode 100644 accel/hvf/entitlements.plist > create mode 100644 accel/hvf/hvf-all.c > create mode 100644 accel/hvf/hvf-cpus.c > create mode 100644 accel/hvf/meson.build > create mode 100644 include/sysemu/hvf_int.h > create mode 100755 scripts/entitlement.sh > create mode 100644 target/arm/hvf/hvf.c > create mode 100644 target/arm/hvf/meson.build > delete mode 100644 target/i386/hvf/hvf-cpus.c > delete mode 100644 target/i386/hvf/hvf-cpus.h > > -- > 2.24.3 (Apple Git-128) > >
On Fri, Dec 11, 2020 at 04:12:49PM +0100, Alexander Graf wrote: > Now that Apple Silicon is widely available, people are obviously excited > to try and run virtualized workloads on them, such as Linux and Windows. > > This patch set implements a fully functional version to get the ball > going on that. With this applied, I can successfully run both Linux and > Windows as guests. I am not aware of any limitations specific to > Hypervisor.framework apart from: > > - Live migration / savevm > - gdbstub debugging (SP register) > > > Enjoy! > Hi Alex, For the ARM part: Tested-by: Roman Bolshakov <r.bolshakov@yadro.com> Note, that it doesn't apply to current master. So I applied it over tagged v5.2.0. Are there any outstanding issues that blocking merge apart from the rebase? Thanks, Roman > Alex > > v1 -> v2: > > - New patch: hvf: Actually set SIG_IPI mask > - New patch: hvf: Introduce hvf vcpu struct > - New patch: hvf: arm: Mark CPU as dirty on reset > - Removed patch: hw/arm/virt: Disable highmem when on hypervisor.framework > - Removed patch: arm: Synchronize CPU on PSCI on > - Fix build on 32bit arm > - Merge vcpu kick function patch into ARM enablement > - Implement WFI handling (allows vCPUs to sleep) > - Synchronize system registers (fixes OVMF crashes and reboot) > - Don't always call cpu_synchronize_state() > - Use more fine grained iothread locking > - Populate aa64mmfr0 from hardware > - Make safe to ctrl-C entitlement application > > v2 -> v3: > > - Removed patch: hvf: Actually set SIG_IPI mask > - New patch: hvf: arm: Add support for GICv3 > - New patch: hvf: arm: Implement -cpu host > - Advance PC on SMC > - Use cp list interface for sysreg syncs > - Do not set current_cpu > - Fix sysreg isread mask > - Move sysreg handling to functions > - Remove WFI logic again > - Revert to global iothread locking > > v3 -> v4: > > - Removed patch: hvf: arm: Mark CPU as dirty on reset > - New patch: hvf: Simplify post reset/init/loadvm hooks > - Remove i386-softmmu target (meson.build for hvf target) > - Combine both if statements (PSCI) > - Use hv.h instead of Hypervisor.h for 10.15 compat > - Remove manual inclusion of Hypervisor.h in common .c files > - No longer include Hypervisor.h in arm hvf .c files > - Remove unused exe_full variable > - Reuse exe_name variable > > v4 -> v5: > > - Use g_free() on destroy > > Alexander Graf (10): > hvf: Add hypervisor entitlement to output binaries > hvf: x86: Remove unused definitions > hvf: Move common code out > hvf: Introduce hvf vcpu struct > arm: Set PSCI to 0.2 for HVF > hvf: Simplify post reset/init/loadvm hooks > hvf: Add Apple Silicon support > arm: Add Hypervisor.framework build target > hvf: arm: Add support for GICv3 > hvf: arm: Implement -cpu host > > Peter Collingbourne (1): > arm/hvf: Add a WFI handler > > MAINTAINERS | 14 +- > accel/hvf/entitlements.plist | 8 + > accel/hvf/hvf-all.c | 54 +++ > accel/hvf/hvf-cpus.c | 466 +++++++++++++++++++ > accel/hvf/meson.build | 7 + > accel/meson.build | 1 + > include/hw/core/cpu.h | 3 +- > include/sysemu/hvf.h | 2 + > include/sysemu/hvf_int.h | 66 +++ > meson.build | 40 +- > scripts/entitlement.sh | 13 + > target/arm/cpu.c | 13 +- > target/arm/cpu.h | 2 + > target/arm/hvf/hvf.c | 856 +++++++++++++++++++++++++++++++++++ > target/arm/hvf/meson.build | 3 + > target/arm/kvm_arm.h | 2 - > target/arm/meson.build | 2 + > target/i386/hvf/hvf-cpus.c | 131 ------ > target/i386/hvf/hvf-cpus.h | 25 - > target/i386/hvf/hvf-i386.h | 49 +- > target/i386/hvf/hvf.c | 462 +++---------------- > target/i386/hvf/meson.build | 1 - > target/i386/hvf/vmx.h | 24 +- > target/i386/hvf/x86.c | 28 +- > target/i386/hvf/x86_descr.c | 26 +- > target/i386/hvf/x86_emu.c | 62 +-- > target/i386/hvf/x86_mmu.c | 4 +- > target/i386/hvf/x86_task.c | 12 +- > target/i386/hvf/x86hvf.c | 224 ++++----- > target/i386/hvf/x86hvf.h | 2 - > 30 files changed, 1786 insertions(+), 816 deletions(-) > create mode 100644 accel/hvf/entitlements.plist > create mode 100644 accel/hvf/hvf-all.c > create mode 100644 accel/hvf/hvf-cpus.c > create mode 100644 accel/hvf/meson.build > create mode 100644 include/sysemu/hvf_int.h > create mode 100755 scripts/entitlement.sh > create mode 100644 target/arm/hvf/hvf.c > create mode 100644 target/arm/hvf/meson.build > delete mode 100644 target/i386/hvf/hvf-cpus.c > delete mode 100644 target/i386/hvf/hvf-cpus.h > > -- > 2.24.3 (Apple Git-128) >