From patchwork Mon Dec 21 19:06:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Sementsov-Ogievskiy X-Patchwork-Id: 11985259 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EF44C433E0 for ; Mon, 21 Dec 2020 19:30:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8625822B43 for ; Mon, 21 Dec 2020 19:30:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8625822B43 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=virtuozzo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krQtN-0001ZR-Fw for qemu-devel@archiver.kernel.org; Mon, 21 Dec 2020 14:30:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53892) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krQkh-0003h7-4u for qemu-devel@nongnu.org; Mon, 21 Dec 2020 14:21:52 -0500 Received: from mail-eopbgr20117.outbound.protection.outlook.com ([40.107.2.117]:14596 helo=EUR02-VE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krQkW-0002sz-IK for qemu-devel@nongnu.org; Mon, 21 Dec 2020 14:21:47 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ao2miV6X0nk5d82meL5uR2oDPKFARWUW11q3WRBHzUXSRFRVrvs/ThkHxqUQxsUH7vFfH7bjXWsTI6K20hNxnA8iNfT6AqW7FOVIfHF4lnbZRlGf7nzCvtS+TJk59I+QDZpH0BRFlJXgvlv2Ee5a8Q52gFmmOhzhde19KVmjZoFruhcX08PZfMEm6SvTu1IqoGVLbs2AyuXvio7vy4VWJAMHRlVcMsaoZDrrkPMafvdujnAL9Mq9Rsu9i2I+eTR2VWQ+Gir17VNyenArDKY85fcaLdm1UT1ybL6nVrkcGkV91hePnj742GGmI4Nmyzgg8zvevH4r0hTyeezMAsDS1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4lPYTZmHAHelVm5V5/R4+Xybx8uw5JNRkMVK0MilDYo=; b=GG1FGQi4I1WPkx9D7nuE70qsieKMuLnZpnAx+44yGOMWj8KKOjm5rhYsr3w/gBOwt4FuDM5dmS0q52+yxQYE+M8yENAwTBSXWkseugpO67t8RCUI/fx+iCxRHfm3kJYgpC72Dkkrcl3hPsXQhYPOfEyE8dKMi3siiX9ABGBscV+BZBSTI4Uv2qcEc12256v7vZmtGKguwaxgGL0ld36wCu/laYvZ85RG5OU2TtVZzTnic1X6vjISvPdvhyhnmEcxgCR0pa5YUi7Onx6O1/inexGol+4EPrLua9jQ1V1yNrgIqtIdx1KxVG5LXqOxrZS46gflbubgf0CyBluF+Jw/Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4lPYTZmHAHelVm5V5/R4+Xybx8uw5JNRkMVK0MilDYo=; b=PuhoSj3VV9R8P3OR5j5KmJgWaoj0LVe9+asc8OEhLwuoLxAAIPhTr2J5fwXbMVIsrF6tdC1Rbo6+eX+yiJNlMcvY0mosdnTitIf7utVTKRDy0+8xsBVcjus8J5AXbrSVCBKL8GyLQjBn+BX2HWW5tTcVtX+Itf8tDsSsV5EoL64= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AM5PR0801MB1652.eurprd08.prod.outlook.com (2603:10a6:203:3c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.30; Mon, 21 Dec 2020 19:06:30 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::d585:99a4:d7a4:d478]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::d585:99a4:d7a4:d478%4]) with mapi id 15.20.3676.033; Mon, 21 Dec 2020 19:06:30 +0000 From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Subject: [PATCH 0/5] net/tap: some fixes and refactorings Date: Mon, 21 Dec 2020 22:06:04 +0300 Message-Id: <20201221190609.93768-1-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.26.2 X-Originating-IP: [185.215.60.92] X-ClientProxiedBy: AM0PR02CA0173.eurprd02.prod.outlook.com (2603:10a6:20b:28e::10) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from kvm.sw.ru (185.215.60.92) by AM0PR02CA0173.eurprd02.prod.outlook.com (2603:10a6:20b:28e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.28 via Frontend Transport; Mon, 21 Dec 2020 19:06:28 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 12388892-646d-4888-454c-08d8a5e38633 X-MS-TrafficTypeDiagnostic: AM5PR0801MB1652: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O0EzFR4lJLyxV/4l3PFAMDb4Qvmp5VbI8OXtAcU6gVUwczGAa1c9xZWaO10LHVHWlOYgnwXIEBEmk1HKXcyFK5XTsua8mTq3cNv56/pNpAbt14JBa2MHKC0CymHYFT8jWc6FdLGPA4xJiRj9y1mcXvrUMe+hH7JQOOQvQR2iKCHMn4abIWwTameATZPAGgqwNdnp9zQNPPeQsvhb2lHIUKqvQoiP6+wzvcHVCQVmdsPgub8tYpyADT/vyyyQXULSXocAGmscx+w19k0ep97l4FhOanU2QxTpfW7Habutko5LsO3K4014fksJcFmT6rabdNM9ZvzjVHFg6Hg03IGFrdwGs74eSL8hDY+4wRgrsNaV8Kxi6JNHeTPNpRWCm4UNlIp41sSt5Kiv31f43pMGLg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39840400004)(396003)(136003)(366004)(376002)(478600001)(186003)(16526019)(6506007)(6486002)(8936002)(8676002)(4744005)(26005)(2616005)(956004)(1076003)(86362001)(5660300002)(4326008)(66476007)(66556008)(66946007)(107886003)(6512007)(52116002)(2906002)(6916009)(6666004)(83380400001)(36756003)(316002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: KT51LYNcKSsv3HPanTdIeBi8IeX3pNqCYPqQYR8osBaPIs2W5cEqFuLbgAgEx8tjjUtu0x7rpp3wVgKv+IL0IDqxGW1sj7T4nfiJ7z8hTkVLtK9FdH9sxqIoD+8DtvJmLF9iHASH5feiJEwTMNxSpTWEIXdIqvA8bgOD2ukUOeE9GNMYuRwLK9Qx3LKksDkgI26yO2gjQs7SiM/d5Z5dcPWQiyDoSkapz8lxirLZne0q6WDPyH7Ao4wFgofVnJwecbP/lXowvWZ8TFdLg2nmrBes9Jzoas7/XfMIA/9iZIBtsv7GOzFjzKzzO46Nt6hs1jM7RLBVkFLQHJrGlDYPJqRl93K01x8g8hTndp7D0xVioeaYHGhTZogp7MD9Y5s+w+TcZxdPanHXO9+C/iyWJ0ZbZPUT4Swb/l4OuM78uwae8YRTj/BaDDadcZus8i2NpMUBfZZEpM7vIZmq5buh4GGp1So/TZV+cwD6GD376kPzsw2a43vjey8Ef4AklfMRRvhGyzLjjxp3gWlpJIc7GFngYJj5qjO9/cU/UHReE/9MGBnudUVySgl12EeEvoZgGhxON2Vj3mV0LkD8GBktzFJbi5u5OhdVTvWmHCOnmEQ6VDluI96ph5AMhER2nxZ7+/1uwvyvCdMpdIjmCGhySj/DrXqfwQkDH2tJ34CNNgdskmC1mrG33VO+oxBxkWvz22VLHHeL7PEaHQ7o4nKRLA8DSJgayWq7uE8ajEBSyD+BWSii2IV0lp5fuLrj4Uy+Fvg5tJA3yMoEEqOM6G1EBN9CmFXbdh4u7VBsz8CdVEUPFmO4E/z0iQcCUaeNO/vjMRPsTH9mvuim0VjOXe0ZDPdVYOcQSjmgLN1CGivAxXjAImlqxZEEvkeoOW57E+1fh+t3BQ3KOrE1VmFUcNgW4A0ZYK34ybjEHcBXBmXWzozeFam4Kvxfp40VQ8CrkRon9CTuZQIyqN5u27s8qVMcaNoYnmEP+lwEzBuALdag91JJHui6zairRe0ItX2XeNiJ X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-AuthSource: AM7PR08MB5494.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2020 19:06:29.6260 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-Network-Message-Id: 12388892-646d-4888-454c-08d8a5e38633 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mHivEUPIKfL9tNwFSMEcNe+EL9eeKGfb+suRu+9T6gZD9aP/1poK2S6b8GvzgmrlE9KUQEJssOFURMGNxoyxQmNCjtXdkOqzf+FzBh3QJk0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1652 Received-SPF: pass client-ip=40.107.2.117; envelope-from=vsementsov@virtuozzo.com; helo=EUR02-VE1-obe.outbound.protection.outlook.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: den@openvz.org, jasowang@redhat.com, vsementsov@virtuozzo.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi all. I have a work in progress around net/tap (and not sure, will it be done or we go another way), but some fixes and good refactoring I'd like to post anyway: Vladimir Sementsov-Ogievskiy (5): net/tap: fix net_init_tap(): set ret on failure path net/tap: drop duplicated tap stubs net/tap: tap_set_sndbuf(): return status net/tap: refactor and improve net_init_tap_one() net/tap: net_init_tap_one(): fix net-client leak on failure path include/net/vhost_net.h | 3 - net/tap_int.h | 2 +- net/tap-bsd.c | 53 ------------------ net/tap-linux.c | 5 +- net/tap-open-stub.c | 34 ++++++++++++ net/tap-solaris.c | 53 ------------------ net/tap-stub.c | 9 +-- net/tap.c | 119 ++++++++++++++++++++++------------------ net/meson.build | 3 + 9 files changed, 108 insertions(+), 173 deletions(-) create mode 100644 net/tap-open-stub.c