mbox series

[0/3] Bypass specific network traffic in COLO

Message ID 20201224010918.19275-1-chen.zhang@intel.com (mailing list archive)
Headers show
Series Bypass specific network traffic in COLO | expand

Message

Zhang, Chen Dec. 24, 2020, 1:09 a.m. UTC
From: Zhang Chen <chen.zhang@intel.com>

Since the real user scenario does not need to monitor all traffic.
This series give user ability to bypass kinds of network stream.

Zhang Chen (3):
  qapi/net: Add new QMP command for COLO passthrough
  hmp-commands: Add new HMP command for COLO passthrough
  net/colo-compare: Add handler for passthrough connection

 hmp-commands.hx       | 26 +++++++++++++++++++++++
 include/monitor/hmp.h |  2 ++
 monitor/hmp-cmds.c    | 20 ++++++++++++++++++
 net/colo-compare.c    | 49 +++++++++++++++++++++++++++++++++++++++++++
 net/colo-compare.h    |  2 ++
 net/net.c             | 39 ++++++++++++++++++++++++++++++++++
 qapi/net.json         | 46 ++++++++++++++++++++++++++++++++++++++++
 7 files changed, 184 insertions(+)

Comments

Jason Wang Dec. 25, 2020, 6:23 a.m. UTC | #1
On 2020/12/24 上午9:09, Zhang Chen wrote:
> From: Zhang Chen <chen.zhang@intel.com>
>
> Since the real user scenario does not need to monitor all traffic.


Hi Chen:

It would be better to elaborate more on this. E.g what scenario and who 
will use those new QMP/HMP commands.

Thanks


> This series give user ability to bypass kinds of network stream.
>
> Zhang Chen (3):
>    qapi/net: Add new QMP command for COLO passthrough
>    hmp-commands: Add new HMP command for COLO passthrough
>    net/colo-compare: Add handler for passthrough connection
>
>   hmp-commands.hx       | 26 +++++++++++++++++++++++
>   include/monitor/hmp.h |  2 ++
>   monitor/hmp-cmds.c    | 20 ++++++++++++++++++
>   net/colo-compare.c    | 49 +++++++++++++++++++++++++++++++++++++++++++
>   net/colo-compare.h    |  2 ++
>   net/net.c             | 39 ++++++++++++++++++++++++++++++++++
>   qapi/net.json         | 46 ++++++++++++++++++++++++++++++++++++++++
>   7 files changed, 184 insertions(+)
>
Zhang, Chen Dec. 28, 2020, 12:38 a.m. UTC | #2
> -----Original Message-----
> From: Jason Wang <jasowang@redhat.com>
> Sent: Friday, December 25, 2020 2:23 PM
> To: Zhang, Chen <chen.zhang@intel.com>; qemu-dev <qemu-
> devel@nongnu.org>; Eric Blake <eblake@redhat.com>; Dr. David Alan
> Gilbert <dgilbert@redhat.com>; Markus Armbruster <armbru@redhat.com>
> Cc: Zhang Chen <zhangckid@gmail.com>
> Subject: Re: [PATCH 0/3] Bypass specific network traffic in COLO
> 
> 
> On 2020/12/24 上午9:09, Zhang Chen wrote:
> > From: Zhang Chen <chen.zhang@intel.com>
> >
> > Since the real user scenario does not need to monitor all traffic.
> 
> 
> Hi Chen:
> 
> It would be better to elaborate more on this. E.g what scenario and who will
> use those new QMP/HMP commands.

OK, I will add more commit log in next version.

Thanks
Chen

> 
> Thanks
> 
> 
> > This series give user ability to bypass kinds of network stream.
> >
> > Zhang Chen (3):
> >    qapi/net: Add new QMP command for COLO passthrough
> >    hmp-commands: Add new HMP command for COLO passthrough
> >    net/colo-compare: Add handler for passthrough connection
> >
> >   hmp-commands.hx       | 26 +++++++++++++++++++++++
> >   include/monitor/hmp.h |  2 ++
> >   monitor/hmp-cmds.c    | 20 ++++++++++++++++++
> >   net/colo-compare.c    | 49
> +++++++++++++++++++++++++++++++++++++++++++
> >   net/colo-compare.h    |  2 ++
> >   net/net.c             | 39 ++++++++++++++++++++++++++++++++++
> >   qapi/net.json         | 46
> ++++++++++++++++++++++++++++++++++++++++
> >   7 files changed, 184 insertions(+)
> >
Dr. David Alan Gilbert (git) Jan. 4, 2021, 1:06 p.m. UTC | #3
* Zhang Chen (chen.zhang@intel.com) wrote:
> From: Zhang Chen <chen.zhang@intel.com>
> 
> Since the real user scenario does not need to monitor all traffic.

Can you explain the type of real user case where they only need to
compare some connections?

Dave

> This series give user ability to bypass kinds of network stream.
> 
> Zhang Chen (3):
>   qapi/net: Add new QMP command for COLO passthrough
>   hmp-commands: Add new HMP command for COLO passthrough
>   net/colo-compare: Add handler for passthrough connection
> 
>  hmp-commands.hx       | 26 +++++++++++++++++++++++
>  include/monitor/hmp.h |  2 ++
>  monitor/hmp-cmds.c    | 20 ++++++++++++++++++
>  net/colo-compare.c    | 49 +++++++++++++++++++++++++++++++++++++++++++
>  net/colo-compare.h    |  2 ++
>  net/net.c             | 39 ++++++++++++++++++++++++++++++++++
>  qapi/net.json         | 46 ++++++++++++++++++++++++++++++++++++++++
>  7 files changed, 184 insertions(+)
> 
> -- 
> 2.17.1
>
Zhang, Chen Jan. 5, 2021, 3:28 a.m. UTC | #4
> -----Original Message-----
> From: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Sent: Monday, January 4, 2021 9:07 PM
> To: Zhang, Chen <chen.zhang@intel.com>
> Cc: Jason Wang <jasowang@redhat.com>; qemu-dev <qemu-
> devel@nongnu.org>; Eric Blake <eblake@redhat.com>; Markus Armbruster
> <armbru@redhat.com>; Zhang Chen <zhangckid@gmail.com>
> Subject: Re: [PATCH 0/3] Bypass specific network traffic in COLO
> 
> * Zhang Chen (chen.zhang@intel.com) wrote:
> > From: Zhang Chen <chen.zhang@intel.com>
> >
> > Since the real user scenario does not need to monitor all traffic.
> 
> Can you explain the type of real user case where they only need to compare
> some connections?

Sure.
For example, windows guest user want to enable windows remote desktop to touch guest(UDP/TCP 3389),
This case use UDP and TCP mixed, and the tcp part payload always different caused by real desktop display data(for guest time/ mouse display....).
Another case is some real user application will actively transmit information include guest time part,  primary guest send data with time 10:01.000,
At the same time secondary guest send data with time 10:01.001, it will always trigger COLO checkpoint to drop guest performance.

Thanks
Chen


> 
> Dave
> 
> > This series give user ability to bypass kinds of network stream.
> >
> > Zhang Chen (3):
> >   qapi/net: Add new QMP command for COLO passthrough
> >   hmp-commands: Add new HMP command for COLO passthrough
> >   net/colo-compare: Add handler for passthrough connection
> >
> >  hmp-commands.hx       | 26 +++++++++++++++++++++++
> >  include/monitor/hmp.h |  2 ++
> >  monitor/hmp-cmds.c    | 20 ++++++++++++++++++
> >  net/colo-compare.c    | 49
> +++++++++++++++++++++++++++++++++++++++++++
> >  net/colo-compare.h    |  2 ++
> >  net/net.c             | 39 ++++++++++++++++++++++++++++++++++
> >  qapi/net.json         | 46
> ++++++++++++++++++++++++++++++++++++++++
> >  7 files changed, 184 insertions(+)
> >
> > --
> > 2.17.1
> >
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK