| Message ID | 20201228071129.24563-1-zhanghan64@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix some style problems in qobject | expand |
Patchew URL: https://patchew.org/QEMU/20201228071129.24563-1-zhanghan64@huawei.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20201228071129.24563-1-zhanghan64@huawei.com
Subject: [PATCH 0/4] Fix some style problems in qobject
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20201219104229.1964-1-mark.cave-ayland@ilande.co.uk -> patchew/20201219104229.1964-1-mark.cave-ayland@ilande.co.uk
- [tag update] patchew/20201226103347.868-1-gaojinhao@huawei.com -> patchew/20201226103347.868-1-gaojinhao@huawei.com
* [new tag] patchew/20201228071129.24563-1-zhanghan64@huawei.com -> patchew/20201228071129.24563-1-zhanghan64@huawei.com
Switched to a new branch 'test'
1caa0fd qobject: braces {} are necessary for all arms of this statement
b0ca07e qobject: spaces required around that operators
0adae60 qobject: code indent should never use tabs
4eea991 qobject: open brace '{' following struct go on the same line
=== OUTPUT BEGIN ===
1/4 Checking commit 4eea9919361d (qobject: open brace '{' following struct go on the same line)
2/4 Checking commit 0adae6079b21 (qobject: code indent should never use tabs)
3/4 Checking commit b0ca07e6cac6 (qobject: spaces required around that operators)
ERROR: braces {} are necessary for all arms of this statement
#22: FILE: qobject/qdict.c:45:
+ for (value = 0x238F13AF * strlen(name), i = 0; name[i]; i++)
[...]
total: 1 errors, 0 warnings, 10 lines checked
Patch 3/4 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/4 Checking commit 1caa0fdbcda9 (qobject: braces {} are necessary for all arms of this statement)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20201228071129.24563-1-zhanghan64@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Some style problems in qobject directory are found by checkpatch.pl. Fix these style problems. Zhang Han (4): qobject: open brace '{' following struct go on the same line qobject: code indent should never use tabs qobject: spaces required around that operators qobject: braces {} are necessary for all arms of this statement qobject/json-parser.c | 3 +-- qobject/qdict.c | 12 +++++++----- qobject/qjson.c | 3 +-- 3 files changed, 9 insertions(+), 9 deletions(-)