mbox series

[0/2] net/eth: Fix stack-buffer-overflow in _eth_get_rss_ex_dst_addr()

Message ID 20210114145041.2865440-1-philmd@redhat.com (mailing list archive)
Headers show
Series net/eth: Fix stack-buffer-overflow in _eth_get_rss_ex_dst_addr() | expand

Message

Philippe Mathieu-Daudé Jan. 14, 2021, 2:50 p.m. UTC
I had a look at the patch from Miroslav trying to silence a
compiler warning which in fact is a nasty bug. Here is a fix.
https://www.mail-archive.com/qemu-devel@nongnu.org/msg772735.html

Philippe Mathieu-Daudé (2):
  net/eth: Simplify _eth_get_rss_ex_dst_addr()
  net/eth: Fix stack-buffer-overflow in _eth_get_rss_ex_dst_addr()

 net/eth.c | 37 +++++++++++++++++--------------------
 1 file changed, 17 insertions(+), 20 deletions(-)

Comments

Miroslav Rezanina Jan. 15, 2021, 10:22 a.m. UTC | #1
On Thu, Jan 14, 2021 at 03:50:39PM +0100, Philippe Mathieu-Daudé wrote:
> I had a look at the patch from Miroslav trying to silence a
> compiler warning which in fact is a nasty bug. Here is a fix.
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg772735.html
> 
> Philippe Mathieu-Daudé (2):
>   net/eth: Simplify _eth_get_rss_ex_dst_addr()
>   net/eth: Fix stack-buffer-overflow in _eth_get_rss_ex_dst_addr()
> 
>  net/eth.c | 37 +++++++++++++++++--------------------
>  1 file changed, 17 insertions(+), 20 deletions(-)
> 
> -- 
> 2.26.2
> 
> 
> 

With qtest chunk included:

Reviewed-by: Miroslav Rezanina <mrezanin@redhat.com>