From patchwork Tue Feb 2 14:26:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 12061817 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BA68C433E0 for ; Tue, 2 Feb 2021 14:30:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F121361481 for ; Tue, 2 Feb 2021 14:30:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F121361481 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6wh0-0003IU-Vl for qemu-devel@archiver.kernel.org; Tue, 02 Feb 2021 09:30:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6wdf-0006ha-7T for qemu-devel@nongnu.org; Tue, 02 Feb 2021 09:26:43 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:35166) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l6wdd-0002iy-Bo for qemu-devel@nongnu.org; Tue, 02 Feb 2021 09:26:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612276000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=INCPcjCOpG8XNmX2qi4tZdE3fuDzl7gziqaFdPbsL4M=; b=R9fQogfv4hK0Q4w0hxIPWWZ81u1q0m27I9PDWetT1w5j/mC+ioe+Q/AYkXXeuQfvFYJ3NZ o6k0GK22dYfGlnMbL8QtJSgeD2y0WVxSNQEXoLXCllXV4DVx5Zl//Tx9MS2iNfQ3kfSoz+ lezARq5Zb+eu+t9Eizv03Dvlnxz0wWc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-216-Qeq_mDYJNMaEBCTWNnFB6Q-1; Tue, 02 Feb 2021 09:26:38 -0500 X-MC-Unique: Qeq_mDYJNMaEBCTWNnFB6Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 852D99CDA0 for ; Tue, 2 Feb 2021 14:26:36 +0000 (UTC) Received: from localhost (unknown [10.36.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6EFBF1A26A; Tue, 2 Feb 2021 14:26:28 +0000 (UTC) From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH 00/20] Various vhost-user-gpu & UI fixes Date: Tue, 2 Feb 2021 18:26:05 +0400 Message-Id: <20210202142625.609070-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=63.128.21.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.386, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Gerd Hoffmann , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Marc-André Lureau Hi, Here is a collection of fixes and improvements mostly around vhost-user-gpu. In combination with spice, they work best with the previously sent fixes ("[PATCH 0/2] Fix (non-vga) QXL async screendump" & "[PATCH v2] spice: delay starting until display are initialized"). I also use virgl from git, which seems to work better. You also need mesa with the recent fix !8663 from last week if you test this. The last patch is a simple RFC avocado test to have the basics under some control and avoid simple regressions. I have further refactoring work pending to separate the DisplayChangeListener from the GL context. This should allow to run a GL-less qemu with Spice client & vhost-user-gpu/virgl for example. Marc-André Lureau (20): vhost-user-gpu: check backend for EDID support vhost-user-gpu: handle vhost-user-gpu features in a callback vhost-user-gpu: use an extandable state enum for commands vhost-user-gpu: handle display-info in a callback ui: remove extra #ifdef CONFIG_OPENGL ui: remove gl_ctx_get_current ui: add gd_gl_area_scanout_disable ui: annotate DCLOps callback requirements ui: remove console_has_gl_dmabuf() vhost-user-gpu: add a configuration flag for dmabuf usage ui: add an optional get_flags callback to GraphicHwOps ui: add a DCLOps callback to check dmabuf support ui: check hw requirements during DCL registration ui: add qemu_egl_has_dmabuf helper ui: check gtk-egl dmabuf support ui: add egl dmabuf import to gtkglarea virtio-gpu: avoid re-entering cmdq processing display/ui: add a callback to indicate GL state is flushed chardev: check if the chardev is registered for yanking RFC: tests: add some virtio-gpu & vhost-user-gpu acceptance test contrib/vhost-user-gpu/vugpu.h | 10 +- include/hw/virtio/virtio-gpu.h | 6 +- include/ui/console.h | 35 +++++- include/ui/egl-context.h | 1 - include/ui/egl-helpers.h | 1 + include/ui/gtk.h | 4 + include/ui/sdl2.h | 1 - chardev/char-socket.c | 53 +++++---- contrib/vhost-user-gpu/vhost-user-gpu.c | 77 ++++++++---- contrib/vhost-user-gpu/virgl.c | 2 +- hw/display/vhost-user-gpu.c | 17 +-- hw/display/virtio-gpu-base.c | 31 ++++- hw/display/virtio-gpu.c | 9 +- hw/display/virtio-vga.c | 20 ++++ hw/vfio/display.c | 6 + ui/console.c | 61 +++++++--- ui/egl-context.c | 5 - ui/egl-headless.c | 1 - ui/egl-helpers.c | 9 ++ ui/gtk-egl.c | 3 + ui/gtk-gl-area.c | 28 +++++ ui/gtk.c | 43 +++++-- ui/sdl2-gl.c | 10 +- ui/sdl2.c | 1 - ui/spice-display.c | 2 +- tests/acceptance/virtio-gpu.py | 150 ++++++++++++++++++++++++ 26 files changed, 484 insertions(+), 102 deletions(-) create mode 100644 tests/acceptance/virtio-gpu.py