From patchwork Wed Feb 3 17:23:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cleber Rosa X-Patchwork-Id: 12064945 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F71BC433DB for ; Wed, 3 Feb 2021 17:36:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3FED46024A for ; Wed, 3 Feb 2021 17:36:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FED46024A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7M57-0001MZ-Pk for qemu-devel@archiver.kernel.org; Wed, 03 Feb 2021 12:36:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7Lt9-00012z-33 for qemu-devel@nongnu.org; Wed, 03 Feb 2021 12:24:24 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:37564) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l7Lt2-0004PT-Bh for qemu-devel@nongnu.org; Wed, 03 Feb 2021 12:24:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612373051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RrdQc1jkYOg/mu7Ru0B32fES8ZHQHHxFoKSHSsYhLFs=; b=A0d1GL5b/cAJu/87pulUdRD/JO4xFq8Iu5RCh/FmjQDousccxZUMiZmTidOyyy++GgHVLR cLRBeX2OI+BbkuPNjhi/gZK4LBdRKmtm8Dju5aPtC4nDQVCF1O2I0CUuFhh3rpcuhmdA+t X4tJ7vHZsURgRahtXEja4lYRjrQbYZw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-585-UI9Qb1cQNQeKIqBuPnVcvg-1; Wed, 03 Feb 2021 12:24:10 -0500 X-MC-Unique: UI9Qb1cQNQeKIqBuPnVcvg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D2E251936B7C; Wed, 3 Feb 2021 17:24:08 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-89.rdu2.redhat.com [10.10.116.89]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4FAF91971C; Wed, 3 Feb 2021 17:23:59 +0000 (UTC) From: Cleber Rosa To: qemu-devel@nongnu.org Subject: [PATCH 00/22] Acceptance Test: introduce base class for Linux based tests Date: Wed, 3 Feb 2021 12:23:35 -0500 Message-Id: <20210203172357.1422425-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=crosa@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.539, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Aleksandar Rikalo , Beraldo Leal , Wainer dos Santos Moschetta , =?utf-8?q?Alex_Benn?= =?utf-8?q?=C3=A9e?= , =?utf-8?q?Philippe_Mathieu-Da?= =?utf-8?q?ud=C3=A9?= , Max Reitz , John Snow , Eric Auger , Willian Rampazzo , Cleber Rosa , Thomas Huth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Aurelien Jarno , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This introduces a base class for tests that need to interact with a Linux guest. It generalizes the "boot_linux.py" code, already been used by the "virtiofs_submounts.py" and also SSH related code being used by that and "linux_ssh_mips_malta.py". While at it, a number of fixes on hopeful improvements to those tests were added. Cleber Rosa (22): tests/acceptance/boot_linux.py: fix typo on cloudinit error message tests/acceptance/boot_linux.py: rename misleading cloudinit method Acceptance Tests: remove unnecessary tag from documentation example tests/acceptance/virtiofs_submounts.py: use workdir property tests/acceptance/virtiofs_submounts.py: do not ask for ssh key password tests/acceptance/virtiofs_submounts.py: use a virtio-net device instead tests/acceptance/virtiofs_submounts.py: evaluate string not length tests/acceptance/virtiofs_submounts.py: standardize port as integer tests/acceptance/virtiofs_submounts.py: required space between IP and port Python: add utility function for retrieving port redirection tests/acceptance/linux_ssh_mips_malta.py: standardize port as integer Acceptance tests: clarify ssh connection failure reason tests/acceptance/virtiofs_submounts.py: add missing accel tag Acceptance Tests: introduce LinuxTest base class Acceptance Tests: move useful ssh methods to base class Acceptance Tests: introduce method for requiring an accelerator Acceptance Tests: fix population of public key in cloudinit image Acceptance Tests: set up existing ssh keys by default Acceptance Tests: add port redirection for ssh by default Acceptance Tests: add basic documentation on LinuxTest base class Acceptance Tests: introduce CPU hotplug test [NOTFORMERGE] Bump Avocado version to latest master docs/devel/testing.rst | 29 +++- python/qemu/utils.py | 35 +++++ tests/acceptance/avocado_qemu/__init__.py | 176 ++++++++++++++++++++++ tests/acceptance/boot_linux.py | 128 ++-------------- tests/acceptance/hotplug_cpu.py | 38 +++++ tests/acceptance/info_usernet.py | 29 ++++ tests/acceptance/linux_ssh_mips_malta.py | 44 +----- tests/acceptance/virtiofs_submounts.py | 73 +-------- tests/requirements.txt | 2 +- tests/vm/basevm.py | 7 +- 10 files changed, 334 insertions(+), 227 deletions(-) create mode 100644 python/qemu/utils.py create mode 100644 tests/acceptance/hotplug_cpu.py create mode 100644 tests/acceptance/info_usernet.py