[0/6] Detect reentrant RX casue by loopback

Message

Jason Wang Feb. 24, 2021, 5:53 a.m. UTC

Hi All:

Followed by commit 22dc8663d9 ("net: forbid the reentrant RX"), we
still need to fix the issues casued by loopback mode where the NIC
usually it via calling nc->info->receive() directly.

The fix is to introduce new network helper and check the
queue->delivering.

Thanks

Jason Wang (6):
  net: introduce qemu_receive_packet()
  e1000: switch to use qemu_receive_packet() for loopback
  dp8393x: switch to use qemu_receive_packet() for loopback packet
  msf2-mac: switch to use qemu_receive_packet() for loopback
  sungem: switch to use qemu_receive_packet() for loopback
  tx_pkt: switch to use qemu_receive_packet_iov() for loopback

 hw/net/dp8393x.c    |  2 +-
 hw/net/e1000.c      |  2 +-
 hw/net/msf2-emac.c  |  2 +-
 hw/net/net_tx_pkt.c |  2 +-
 hw/net/sungem.c     |  2 +-
 include/net/net.h   |  5 +++++
 include/net/queue.h |  8 ++++++++
 net/net.c           | 38 +++++++++++++++++++++++++++++++-------
 net/queue.c         | 22 ++++++++++++++++++++++
 9 files changed, 71 insertions(+), 12 deletions(-)

Comments

[e-mail] Feb. 24, 2021, 6:03 a.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: [e-mail]
Subject: [PATCH 0/6] Detect reentrant RX casue by loopback

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
6a41d09 tx_pkt: switch to use qemu_receive_packet_iov() for loopback
5480e55 sungem: switch to use qemu_receive_packet() for loopback
f35fab6 msf2-mac: switch to use qemu_receive_packet() for loopback
1dc29cf dp8393x: switch to use qemu_receive_packet() for loopback packet
6c79834 e1000: switch to use qemu_receive_packet() for loopback
04660c0 net: introduce qemu_receive_packet()

=== OUTPUT BEGIN ===
1/6 Checking commit 04660c06d88e (net: introduce qemu_receive_packet())
ERROR: space required after that ',' (ctx:VxV)
#42: FILE: include/net/net.h:154:
+ssize_t qemu_receive_packet(NetClientState *nc, const uint8_t *buf,int size);
                                                                   ^

total: 1 errors, 0 warnings, 115 lines checked

Patch 1/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/6 Checking commit 6c7983468e94 (e1000: switch to use qemu_receive_packet() for loopback)
3/6 Checking commit 1dc29cfa3117 (dp8393x: switch to use qemu_receive_packet() for loopback packet)
4/6 Checking commit f35fab6cb737 (msf2-mac: switch to use qemu_receive_packet() for loopback)
5/6 Checking commit 5480e5557678 (sungem: switch to use qemu_receive_packet() for loopback)
6/6 Checking commit 6a41d093a705 (tx_pkt: switch to use qemu_receive_packet_iov() for loopback)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]