[v5,00/13] target/mips: Extract MXU code to new mxu_translate.c file

Message

Philippe Mathieu-Daudé Feb. 26, 2021, 9:30 a.m. UTC

Series fully reviewed.

Since v4:
- Explicit decode_opc_mxu() -> decode_ase_mxu() renaming

Since v3:
- addressed Richard's review comments, elide code when possible

$ git backport-diff -u v4
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respective=
ly

001/13:[----] [--] 'target/mips/meson: Introduce mips_tcg source set'
002/13:[----] [--] 'target/mips/meson: Restrict mips-semi.c to TCG'
003/13:[----] [--] 'target/mips: Rewrite complex ifdef'ry'
004/13:[----] [--] 'target/mips: Remove XBurst Media eXtension Unit dead code'
005/13:[----] [--] 'target/mips: Remove unused CPUMIPSState* from MXU functio=
ns'
006/13:[----] [--] 'target/mips: Pass instruction opcode to decode_opc_mxu()'
007/13:[----] [--] 'target/mips: Use OPC_MUL instead of OPC__MXU_MUL'
008/13:[----] [--] 'target/mips: Move MUL opcode check from decode_mxu() to d=
ecode_legacy()'
009/13:[down] 'target/mips: Rename decode_opc_mxu() as decode_ase_mxu()'
010/13:[down] 'target/mips: Convert decode_ase_mxu() to decodetree prototype'
011/13:[----] [--] 'target/mips: Simplify decode_opc_mxu() ifdef'ry'
012/13:[----] [--] 'target/mips: Introduce mxu_translate_init() helper'
013/13:[----] [--] 'target/mips: Extract MXU code to new mxu_translate.c file'

Philippe Mathieu-Daud=C3=A9 (13):
  target/mips/meson: Introduce mips_tcg source set
  target/mips/meson: Restrict mips-semi.c to TCG
  target/mips: Rewrite complex ifdef'ry
  target/mips: Remove XBurst Media eXtension Unit dead code
  target/mips: Remove unused CPUMIPSState* from MXU functions
  target/mips: Pass instruction opcode to decode_opc_mxu()
  target/mips: Use OPC_MUL instead of OPC__MXU_MUL
  target/mips: Move MUL opcode check from decode_mxu() to
    decode_legacy()
  target/mips: Rename decode_opc_mxu() as decode_ase_mxu()
  target/mips: Convert decode_ase_mxu() to decodetree prototype
  target/mips: Simplify decode_opc_mxu() ifdef'ry
  target/mips: Introduce mxu_translate_init() helper
  target/mips: Extract MXU code to new mxu_translate.c file

 target/mips/translate.h     |    4 +
 target/mips/mxu_translate.c | 1609 +++++++++++++++++++
 target/mips/translate.c     | 2920 +----------------------------------
 target/mips/meson.build     |   13 +-
 4 files changed, 1636 insertions(+), 2910 deletions(-)
 create mode 100644 target/mips/mxu_translate.c

--=20
2.26.2

Comments

Philippe Mathieu-Daudé March 13, 2021, 11:45 p.m. UTC | #1

On 2/26/21 10:30 AM, Philippe Mathieu-Daudé wrote:
> Series fully reviewed.

> Philippe Mathieu-Daud=C3=A9 (13):
>   target/mips/meson: Introduce mips_tcg source set
>   target/mips/meson: Restrict mips-semi.c to TCG
>   target/mips: Rewrite complex ifdef'ry
>   target/mips: Remove XBurst Media eXtension Unit dead code
>   target/mips: Remove unused CPUMIPSState* from MXU functions
>   target/mips: Pass instruction opcode to decode_opc_mxu()
>   target/mips: Use OPC_MUL instead of OPC__MXU_MUL
>   target/mips: Move MUL opcode check from decode_mxu() to
>     decode_legacy()
>   target/mips: Rename decode_opc_mxu() as decode_ase_mxu()
>   target/mips: Convert decode_ase_mxu() to decodetree prototype
>   target/mips: Simplify decode_opc_mxu() ifdef'ry
>   target/mips: Introduce mxu_translate_init() helper
>   target/mips: Extract MXU code to new mxu_translate.c file
> 
>  target/mips/translate.h     |    4 +
>  target/mips/mxu_translate.c | 1609 +++++++++++++++++++
>  target/mips/translate.c     | 2920 +----------------------------------
>  target/mips/meson.build     |   13 +-
>  4 files changed, 1636 insertions(+), 2910 deletions(-)
>  create mode 100644 target/mips/mxu_translate.c
Thanks, applied to mips-next.