mbox series

[V4,0/8] hw/block/nvme: support namespace attachment

Message ID 20210302132617.18495-1-minwoo.im.dev@gmail.com (mailing list archive)
Headers show
Series hw/block/nvme: support namespace attachment | expand

Message

Minwoo Im March 2, 2021, 1:26 p.m. UTC
Hello,

This series supports namespace attachment: attach and detach.  This is
the fourth version of series with replacing changed namespace list to
bitmap to indicate changed namespace IDs.

Please review.

Thanks,

Since V3:
  - Replace changed ns list to bitmap to not only represent relationship
    between controller and namespace, but also avoid duplications of
    nsids in the list.  (Klaus)

Since V2:
  - Added command effects (namespace inventory changed) for namespace
    attach command.  (Keith)
  - Added [7/8] patch to support asynchronus event when namespace
    inventory is updated.  (Keith)
  - Added review and tested tag from Klaus to all the patches, but [6/8]
    and [7/8].

Since V1:
  - Fix to take 'ctrl' which is given from the command rather than 'n'.
    (Klaus)
  - Add a [7/7] patch to support CNS 12h Identify command (Namespace
    Attached Controller list).

Minwoo Im (8):
  hw/block/nvme: support namespace detach
  hw/block/nvme: fix namespaces array to 1-based
  hw/block/nvme: fix allocated namespace list to 256
  hw/block/nvme: support allocated namespace type
  hw/block/nvme: refactor nvme_select_ns_iocs
  hw/block/nvme: support namespace attachment command
  hw/block/nvme: support changed namespace asyncrohous event
  hw/block/nvme: support Identify NS Attached Controller List

 hw/block/nvme-ns.c     |   1 +
 hw/block/nvme-ns.h     |   2 +
 hw/block/nvme-subsys.h |  28 +++-
 hw/block/nvme.c        | 300 ++++++++++++++++++++++++++++++++++++-----
 hw/block/nvme.h        |  37 +++++
 hw/block/trace-events  |   3 +
 include/block/nvme.h   |  14 ++
 7 files changed, 349 insertions(+), 36 deletions(-)

Comments

Keith Busch March 4, 2021, 7:33 p.m. UTC | #1
On Tue, Mar 02, 2021 at 10:26:09PM +0900, Minwoo Im wrote:
> Hello,
> 
> This series supports namespace attachment: attach and detach.  This is
> the fourth version of series with replacing changed namespace list to
> bitmap to indicate changed namespace IDs.
> 
> Please review.

Looks good to me.

Reviewed-by: Keith Busch <kbusch@kernel.org>
Klaus Jensen March 8, 2021, 11:30 a.m. UTC | #2
On Mar  2 22:26, Minwoo Im wrote:
> Hello,
> 
> This series supports namespace attachment: attach and detach.  This is
> the fourth version of series with replacing changed namespace list to
> bitmap to indicate changed namespace IDs.
> 
> Please review.
> 
> Thanks,
> 
> Since V3:
>   - Replace changed ns list to bitmap to not only represent relationship
>     between controller and namespace, but also avoid duplications of
>     nsids in the list.  (Klaus)
> 
> Since V2:
>   - Added command effects (namespace inventory changed) for namespace
>     attach command.  (Keith)
>   - Added [7/8] patch to support asynchronus event when namespace
>     inventory is updated.  (Keith)
>   - Added review and tested tag from Klaus to all the patches, but [6/8]
>     and [7/8].
> 
> Since V1:
>   - Fix to take 'ctrl' which is given from the command rather than 'n'.
>     (Klaus)
>   - Add a [7/7] patch to support CNS 12h Identify command (Namespace
>     Attached Controller list).
> 
> Minwoo Im (8):
>   hw/block/nvme: support namespace detach
>   hw/block/nvme: fix namespaces array to 1-based
>   hw/block/nvme: fix allocated namespace list to 256
>   hw/block/nvme: support allocated namespace type
>   hw/block/nvme: refactor nvme_select_ns_iocs
>   hw/block/nvme: support namespace attachment command
>   hw/block/nvme: support changed namespace asyncrohous event
>   hw/block/nvme: support Identify NS Attached Controller List
> 
>  hw/block/nvme-ns.c     |   1 +
>  hw/block/nvme-ns.h     |   2 +
>  hw/block/nvme-subsys.h |  28 +++-
>  hw/block/nvme.c        | 300 ++++++++++++++++++++++++++++++++++++-----
>  hw/block/nvme.h        |  37 +++++
>  hw/block/trace-events  |   3 +
>  include/block/nvme.h   |  14 ++
>  7 files changed, 349 insertions(+), 36 deletions(-)
> 
> -- 
> 2.27.0
> 

Tested and applied to nvme-next! Thanks!