From patchwork Wed Mar 3 18:22:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12114011 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FD29C433E0 for ; Wed, 3 Mar 2021 18:23:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A276260295 for ; Wed, 3 Mar 2021 18:23:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A276260295 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53032 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHWA2-0006UJ-LH for qemu-devel@archiver.kernel.org; Wed, 03 Mar 2021 13:23:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHW8i-0004S8-Ni for qemu-devel@nongnu.org; Wed, 03 Mar 2021 13:22:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46447) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lHW8g-0000KS-Ic for qemu-devel@nongnu.org; Wed, 03 Mar 2021 13:22:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614795745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=c2RVdSAhN19HCcvNMcEKCSeQlJ0pBYd+9LH4EI/CKB0=; b=JaRwa39MfemudpofpVZoUtEzWJe5YQbBio0bPmEjqgIUoS9qTqZvY+fPQ7fDlSY3H4CAQN kn51fAchHBKFg8el2uayAj1QB2HD4hu4D6DTqMZ7smtYbWvmCi9eje13/jDOhXUmCF6xu7 FYj6Bt3RT0DRPIs+cr65O95N2BOSZpg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-273-C2gPXK33NlCE1y-N69HXJA-1; Wed, 03 Mar 2021 13:22:24 -0500 X-MC-Unique: C2gPXK33NlCE1y-N69HXJA-1 Received: by mail-wr1-f70.google.com with SMTP id h30so13180585wrh.10 for ; Wed, 03 Mar 2021 10:22:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pU0d9Mw8PQdbgfBbP+KMCl6F0o1+MOAeJgm+3OD11Xs=; b=Gt3IaA7DpjHILrooPF2Tq+YADIS8Pn3rvvrl1voTjlw+qYH4ic3TRm11Mw2FUOzej3 79m8auo5EmIPYlQHZ1cr7pjFBmhHFbavGqsPK8o9OC3LItq4ztq/dueKId3DHJQbDfb2 +LRPLQQjiqtQ/CYg6vbBbpfog92PLF1OD3J1dM3bVTd7+46KowZ6lziWJWn0zLOizOsr Co4VPlm0dGhVkL/jBx2ceL2Opmdua8SHi4nyAnfAqiZflgyFhcvqLr4EyBuXWQ1yP/F4 OOE0POeIL5DjREeroGXA7wrrLBp4Loa1TFufU9lwtNFSKXVAj7I0Tg8NrguHXznSK0Rt sTww== X-Gm-Message-State: AOAM533EunWYhsA6dsQCzaYy33zet3hNQDAGLDkSnvmp/oX43aisFAPG oq/vKyGtbtHdAf5DXFR119MTfl5DWqnvhf9ArfemotMB+NpIOaGNtXj9QFSa+ZS7xGigVNnSQid IuXPjvf/NirUVdAhbkBX9j+IxF85UcPmtIwprrUZv5VtT0kU+2WLBtQm97Uah9scW X-Received: by 2002:a5d:430a:: with SMTP id h10mr19981wrq.162.1614795742576; Wed, 03 Mar 2021 10:22:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJwUTywIC+KwxYJXuUyDhzg8Nuj7gHjGLk6CPjSdHmohYvyP+QZLu8kIXtLnUufcrNeJRgTWfQ== X-Received: by 2002:a5d:430a:: with SMTP id h10mr19929wrq.162.1614795742181; Wed, 03 Mar 2021 10:22:22 -0800 (PST) Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id i3sm35148487wra.66.2021.03.03.10.22.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 10:22:21 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 00/19] accel: Introduce AccelvCPUState opaque structure Date: Wed, 3 Mar 2021 19:22:00 +0100 Message-Id: <20210303182219.1631042-1-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Cornelia Huck , kvm@vger.kernel.org, David Hildenbrand , haxm-team@intel.com, Colin Xu , Halil Pasic , Christian Borntraeger , Claudio Fontana , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Thomas Huth , Eduardo Habkost , Richard Henderson , Greg Kurz , Cameron Esfahani , Roman Bolshakov , qemu-arm@nongnu.org, Sunil Muthuswamy , David Gibson , Marcelo Tosatti , qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, Wenchao Wang , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, This series introduces the 'AccelvCPUState' which is forward declared opaque in "cpu.h", then each accelerator define it. The opaque CPUState::accel_vcpu pointer is shared by all accelerators (not a problem because there can be at most one accelerator per vCPU). Series is organized as: - preliminary trivial cleanups - introduce AccelvCPUState - move WHPX fields (build-tested) - move HAX fields (not tested) - move KVM fields (build-tested) - move HVF fields (not tested) For now vcpu_dirty is still shared in CPUState. Sending as RFC to see if it is worthwhile. Regards, Phil. Philippe Mathieu-Daudé (19): target/i386/hvf: Use boolean value for vcpu_dirty target/s390x/kvm: Simplify debug code target/s390x/kvm: Reduce deref by declaring 'struct kvm_run' on stack cpu: Croup accelerator-specific fields altogether cpu: Introduce AccelvCPUState opaque structure accel/whpx: Add typedef for 'struct whpx_vcpu' accel/whpx: Rename struct whpx_vcpu -> AccelvCPUState accel/whpx: Use 'accel_vcpu' generic pointer accel/hax: Add typedef for 'struct hax_vcpu_state' accel/hax: Use 'accel_vcpu' generic pointer accel/kvm: Introduce kvm_vcpu_state() helper accel/kvm: Use kvm_vcpu_state() when possible accel/kvm: Declare and allocate AccelvCPUState struct accel/kvm: Move the 'kvm_fd' field to AccelvCPUState accel/kvm: Move the 'kvm_state' field to AccelvCPUState accel/kvm: Move the 'kvm_run' field to AccelvCPUState accel/hvf: Reduce deref by declaring 'hv_vcpuid_t hvf_fd' on stack accel/hvf: Declare and allocate AccelvCPUState struct accel/hvf: Move the 'hvf_fd' field to AccelvCPUState include/hw/core/cpu.h | 17 +-- include/sysemu/kvm.h | 2 + include/sysemu/kvm_int.h | 9 ++ target/i386/hax/hax-i386.h | 10 +- target/i386/hvf/hvf-i386.h | 4 + target/i386/hvf/vmx.h | 28 +++-- accel/kvm/kvm-all.c | 44 ++++--- hw/s390x/pv.c | 3 +- target/arm/kvm.c | 2 +- target/arm/kvm64.c | 12 +- target/i386/cpu.c | 4 +- target/i386/hax/hax-all.c | 22 ++-- target/i386/hax/hax-posix.c | 4 +- target/i386/hax/hax-windows.c | 4 +- target/i386/hvf/hvf.c | 118 +++++++++--------- target/i386/hvf/x86.c | 28 ++--- target/i386/hvf/x86_descr.c | 32 +++-- target/i386/hvf/x86_emu.c | 62 +++++----- target/i386/hvf/x86_mmu.c | 4 +- target/i386/hvf/x86_task.c | 14 ++- target/i386/hvf/x86hvf.c | 227 +++++++++++++++++----------------- target/i386/kvm/kvm.c | 36 +++--- target/i386/whpx/whpx-all.c | 34 ++--- target/ppc/kvm.c | 16 +-- target/s390x/kvm.c | 148 +++++++++++----------- 25 files changed, 466 insertions(+), 418 deletions(-)