Message ID | 20210316183035.9424-1-cfontana@suse.de (mailing list archive) |
---|---|
Headers | show |
Series | i386 cleanup PART 2 | expand |
Patchew URL: https://patchew.org/QEMU/20210316183035.9424-1-cfontana@suse.de/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210316183035.9424-1-cfontana@suse.de Subject: [PATCH v27 00/20] i386 cleanup PART 2 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20210315183812.27760-1-alxndr@bu.edu -> patchew/20210315183812.27760-1-alxndr@bu.edu - [tag update] patchew/20210316172449.3148634-1-philmd@redhat.com -> patchew/20210316172449.3148634-1-philmd@redhat.com * [new tag] patchew/20210316183035.9424-1-cfontana@suse.de -> patchew/20210316183035.9424-1-cfontana@suse.de Switched to a new branch 'test' d256d8f i386: make cpu_load_efer sysemu-only 747d1a6 target/i386: gdbstub: only write CR0/CR2/CR3/EFER for sysemu 426ca90 target/i386: gdbstub: introduce aux functions to read/write CS64 regs 826ed55 i386: split off sysemu part of cpu.c 99267fd i386: split seg_helper into user-only and sysemu parts 71112a7 i386: split svm_helper into sysemu and stub-only user 8d1e4df i386: separate fpu_helper sysemu-only parts dfe7b76 i386: split misc helper user stubs and sysemu part 77390ab i386: move TCG bpt_helper into sysemu/ 43ed79a i386: split tcg excp_helper into sysemu and user parts 46b0fc4 i386: split smm helper (sysemu) 5060073 i386: split off sysemu-only functionality in tcg-cpu ba28ee0 meson: add target_user_arch 6107138 accel-cpu: make cpu_realizefn return a bool 07256b7 target/i386: fix host_cpu_adjust_phys_bits error handling 52655dd accel: introduce new accessor functions 1d2059b cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn f2a8e60 i386: split cpu accelerators from cpu.c, using AccelCPUClass a019ffd target/i386: Split out do_fsave, do_frstor, do_fxsave, do_fxrstor 97ee99d target/i386: Rename helper_fldt, helper_fstt === OUTPUT BEGIN === 1/20 Checking commit 97ee99d1f288 (target/i386: Rename helper_fldt, helper_fstt) 2/20 Checking commit a019ffdf1f4e (target/i386: Split out do_fsave, do_frstor, do_fxsave, do_fxrstor) 3/20 Checking commit f2a8e60c78ee (i386: split cpu accelerators from cpu.c, using AccelCPUClass) WARNING: line over 80 characters #1337: FILE: target/i386/tcg/tcg-cpu.c:125: + memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, cpu->cpu_as_mem, 0); total: 0 errors, 1 warnings, 1256 lines checked Patch 3/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/20 Checking commit 1d2059be2cb2 (cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn) 5/20 Checking commit 52655dd7b9fc (accel: introduce new accessor functions) 6/20 Checking commit 07256b7f0f5e (target/i386: fix host_cpu_adjust_phys_bits error handling) 7/20 Checking commit 6107138de36e (accel-cpu: make cpu_realizefn return a bool) 8/20 Checking commit ba28ee02e80d (meson: add target_user_arch) 9/20 Checking commit 5060073ba933 (i386: split off sysemu-only functionality in tcg-cpu) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 WARNING: line over 80 characters #116: FILE: target/i386/tcg/sysemu/tcg-cpu.c:72: + memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, cpu->cpu_as_mem, 0); total: 0 errors, 2 warnings, 212 lines checked Patch 9/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/20 Checking commit 46b0fc4ea82f (i386: split smm helper (sysemu)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #24: target/i386/tcg/{ => sysemu}/smm_helper.c | 19 ++----------------- total: 0 errors, 1 warnings, 84 lines checked Patch 10/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/20 Checking commit 43ed79a4e724 (i386: split tcg excp_helper into sysemu and user parts) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #599: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #756: FILE: target/i386/tcg/sysemu/excp_helper.c:153: + /* Bits 20-13 provide bits 39-32 of the address, bit 21 is reserved. WARNING: Block comments use a leading /* on a separate line #830: FILE: target/i386/tcg/sysemu/excp_helper.c:227: +/* return value: WARNING: line over 80 characters #931: FILE: target/i386/tcg/sysemu/excp_helper.c:328: + pdpe_addr = ((pml4e & PG_ADDRESS_MASK) + (((addr >> 30) & 0x1ff) << 3)) & WARNING: Block comments use a leading /* on a separate line #1025: FILE: target/i386/tcg/sysemu/excp_helper.c:422: + /* Bits 20-13 provide bits 39-32 of the address, bit 21 is reserved. WARNING: Block comments use a leading /* on a separate line #1120: FILE: target/i386/tcg/sysemu/excp_helper.c:517: + /* only set write access if already dirty... otherwise wait WARNING: Block comments use * on subsequent lines #1121: FILE: target/i386/tcg/sysemu/excp_helper.c:518: + /* only set write access if already dirty... otherwise wait + for dirty access */ WARNING: Block comments use a trailing */ on a separate line #1121: FILE: target/i386/tcg/sysemu/excp_helper.c:518: + for dirty access */ WARNING: Block comments use a leading /* on a separate line #1134: FILE: target/i386/tcg/sysemu/excp_helper.c:531: + /* Even if 4MB pages, we map only one 4KB page in the cache to WARNING: Block comments use * on subsequent lines #1135: FILE: target/i386/tcg/sysemu/excp_helper.c:532: + /* Even if 4MB pages, we map only one 4KB page in the cache to + avoid filling it too fast */ WARNING: Block comments use a trailing */ on a separate line #1135: FILE: target/i386/tcg/sysemu/excp_helper.c:532: + avoid filling it too fast */ ERROR: braces {} are necessary for all arms of this statement #1149: FILE: target/i386/tcg/sysemu/excp_helper.c:546: + if (is_user) [...] total: 1 errors, 11 warnings, 631 lines checked Patch 11/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/20 Checking commit 77390ab94b9b (i386: move TCG bpt_helper into sysemu/) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #364: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #500: FILE: target/i386/tcg/sysemu/bpt_helper.c:132: + /* If nothing is changing except the global/local enable bits, WARNING: Block comments use * on subsequent lines #501: FILE: target/i386/tcg/sysemu/bpt_helper.c:133: + /* If nothing is changing except the global/local enable bits, + then we can make the change more efficient. */ WARNING: Block comments use a trailing */ on a separate line #501: FILE: target/i386/tcg/sysemu/bpt_helper.c:133: + then we can make the change more efficient. */ WARNING: Block comments use a leading /* on a separate line #503: FILE: target/i386/tcg/sysemu/bpt_helper.c:135: + /* Fold the global and local enable bits together into the WARNING: Block comments use * on subsequent lines #504: FILE: target/i386/tcg/sysemu/bpt_helper.c:136: + /* Fold the global and local enable bits together into the + global fields, then xor to show which registers have WARNING: Block comments use a trailing */ on a separate line #505: FILE: target/i386/tcg/sysemu/bpt_helper.c:137: + changed collective enable state. */ total: 0 errors, 7 warnings, 628 lines checked Patch 12/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/20 Checking commit dfe7b76acfef (i386: split misc helper user stubs and sysemu part) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #527: new file mode 100644 ERROR: switch and case should be at the same indent #820: FILE: target/i386/tcg/sysemu/misc_helper.c:289: + switch ((uint32_t)env->regs[R_ECX]) { [...] + case MSR_IA32_UCODE_REV: total: 1 errors, 1 warnings, 1012 lines checked Patch 13/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/20 Checking commit 8d1e4dfe80f4 (i386: separate fpu_helper sysemu-only parts) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #108: new file mode 100644 total: 0 errors, 1 warnings, 135 lines checked Patch 14/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/20 Checking commit 71112a72aa85 (i386: split svm_helper into sysemu and stub-only user) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: target/i386/tcg/{ => sysemu}/svm_helper.c | 62 +------------------------ total: 0 errors, 1 warnings, 169 lines checked Patch 15/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/20 Checking commit 99267fddda3d (i386: split seg_helper into user-only and sysemu parts) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #321: new file mode 100644 ERROR: do not use C99 // comments #348: FILE: target/i386/tcg/seg_helper.h:23: +//#define DEBUG_PCALL WARNING: Block comments use a leading /* on a separate line #621: FILE: target/i386/tcg/user/seg_helper.c:73: + /* Since we emulate only user space, we cannot do more than WARNING: Block comments use * on subsequent lines #622: FILE: target/i386/tcg/user/seg_helper.c:74: + /* Since we emulate only user space, we cannot do more than + exiting the emulation with the suitable exception and error WARNING: Block comments use a trailing */ on a separate line #623: FILE: target/i386/tcg/user/seg_helper.c:75: + code. So update EIP for INT 0x80 and EXCP_SYSCALL. */ WARNING: Block comments use a leading /* on a separate line #634: FILE: target/i386/tcg/user/seg_helper.c:86: + /* if user mode only, we simulate a fake exception WARNING: Block comments use * on subsequent lines #635: FILE: target/i386/tcg/user/seg_helper.c:87: + /* if user mode only, we simulate a fake exception + which will be handled outside the cpu execution WARNING: Block comments use a trailing */ on a separate line #636: FILE: target/i386/tcg/user/seg_helper.c:88: + loop */ total: 1 errors, 7 warnings, 595 lines checked Patch 16/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/20 Checking commit 826ed555ac88 (i386: split off sysemu part of cpu.c) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #52: FILE: target/i386/cpu-internal.h:30: + /* feature flags names are taken from "Intel Processor Identification and WARNING: Block comments use a leading /* on a separate line #135: FILE: target/i386/cpu-sysemu.c:37: +/* Return a QDict containing keys for all properties that can be included WARNING: Block comments use a leading /* on a separate line #188: FILE: target/i386/cpu-sysemu.c:90: +/* Convert CPU model data from X86CPU object to a property dictionary WARNING: Block comments use a leading /* on a separate line #202: FILE: target/i386/cpu-sysemu.c:104: +/* Convert CPU model data from X86CPU object to a property dictionary WARNING: Block comments use a leading /* on a separate line #218: FILE: target/i386/cpu-sysemu.c:120: + /* "hotplugged" is the only property that is configurable WARNING: Block comments use a leading /* on a separate line #308: FILE: target/i386/cpu-sysemu.c:210: + /* As we don't return every single property, full expansion needs total: 0 errors, 7 warnings, 901 lines checked Patch 17/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/20 Checking commit 426ca9022c02 (target/i386: gdbstub: introduce aux functions to read/write CS64 regs) WARNING: line over 80 characters #62: FILE: target/i386/gdbstub.c:163: + return gdb_read_reg_cs64(env->hflags, mem_buf, env->segs[R_FS].base); WARNING: line over 80 characters #68: FILE: target/i386/gdbstub.c:165: + return gdb_read_reg_cs64(env->hflags, mem_buf, env->segs[R_GS].base); WARNING: line over 80 characters #156: FILE: target/i386/gdbstub.c:318: + return gdb_write_reg_cs64(env->hflags, mem_buf, &env->segs[R_FS].base); WARNING: line over 80 characters #165: FILE: target/i386/gdbstub.c:320: + return gdb_write_reg_cs64(env->hflags, mem_buf, &env->segs[R_GS].base); total: 0 errors, 4 warnings, 221 lines checked Patch 18/20 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/20 Checking commit 747d1a64f4ad (target/i386: gdbstub: only write CR0/CR2/CR3/EFER for sysemu) 20/20 Checking commit d256d8fd0bad (i386: make cpu_load_efer sysemu-only) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210316183035.9424-1-cfontana@suse.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com