mbox series

[v4,00/11] 64bit block-layer: part II

Message ID 20210324205132.464899-1-vsementsov@virtuozzo.com (mailing list archive)
Headers show
Series 64bit block-layer: part II | expand

Message

Vladimir Sementsov-Ogievskiy March 24, 2021, 8:51 p.m. UTC
Hi all!

Here is part II of 64bit block-layer, when part I already landed
 ([PATCH v4 00/16] 64bit block-layer: part I
  <20201211183934.169161-1-vsementsov@virtuozzo.com>)

This is called v4 too, because it follows old
 ([PATCH v3 00/17] 64bit block-layer
  <20200430111033.29980-1-vsementsov@virtuozzo.com>)

Make patchew consider the old series obsolete:
Supersedes: <20200430111033.29980-1-vsementsov@virtuozzo.com>
 (still actually, it is split into parts. And one more part that will
  update blk layer is still needed.)

The old series is so old that I don't want to compare :) I've changed a
lot of things and new patches added.

part II aims to update block drivers to int64_t.

I remind that main aim of this update of the whole block-layer to 64bit
is to implement 64bit write-zeroes NBD request.

Vladimir Sementsov-Ogievskiy (11):
  block/io: bring request check to bdrv_co_{read,write}v_vmstate
  qcow2: check request on vmstate save/load path
  block: use int64_t instead of uint64_t in driver read handlers
  block: use int64_t instead of uint64_t in driver write handlers
  block: use int64_t instead of uint64_t in copy_range driver handlers
  block: make BlockLimits::max_pwrite_zeroes 64bit
  block: use int64_t instead of int in driver write_zeroes handlers
  block/io: allow 64bit write-zeroes requests
  block: make BlockLimits::max_pdiscard 64bit
  block: use int64_t instead of int in driver discard handlers
  block/io: allow 64bit discard requests

 include/block/block_int.h        | 62 ++++++++++++++--------------
 block/backup-top.c               | 14 +++----
 block/blkdebug.c                 | 12 +++---
 block/blklogwrites.c             | 16 ++++----
 block/blkreplay.c                |  8 ++--
 block/blkverify.c                |  8 ++--
 block/bochs.c                    |  4 +-
 block/cloop.c                    |  4 +-
 block/commit.c                   |  2 +-
 block/copy-on-read.c             | 19 +++++----
 block/crypto.c                   |  8 ++--
 block/curl.c                     |  3 +-
 block/dmg.c                      |  4 +-
 block/file-posix.c               | 35 ++++++++--------
 block/file-win32.c               |  8 ++--
 block/filter-compress.c          | 15 +++----
 block/gluster.c                  | 13 +++---
 block/io.c                       | 44 +++++++++++++++-----
 block/iscsi.c                    | 53 ++++++++++++++----------
 block/mirror.c                   |  8 ++--
 block/nbd.c                      | 22 ++++++----
 block/nfs.c                      | 12 +++---
 block/null.c                     | 18 ++++----
 block/nvme.c                     | 47 +++++++++++++++++----
 block/preallocate.c              | 14 +++----
 block/qcow.c                     | 16 ++++----
 block/qcow2-cluster.c            | 14 ++++++-
 block/qcow2.c                    | 70 +++++++++++++++++++++++---------
 block/qed.c                      |  9 +++-
 block/quorum.c                   | 11 ++---
 block/raw-format.c               | 36 ++++++++--------
 block/rbd.c                      | 10 +++--
 block/sheepdog.c                 | 15 ++++++-
 block/throttle.c                 | 18 ++++----
 block/vdi.c                      |  8 ++--
 block/vmdk.c                     | 14 +++----
 block/vpc.c                      |  8 ++--
 block/vvfat.c                    | 12 +++---
 tests/unit/test-bdrv-drain.c     | 16 ++++----
 tests/unit/test-block-iothread.c | 21 +++++++---
 block/trace-events               | 10 ++---
 41 files changed, 451 insertions(+), 290 deletions(-)

Comments

no-reply@patchew.org March 24, 2021, 9:13 p.m. UTC | #1
Patchew URL: https://patchew.org/QEMU/20210324205132.464899-1-vsementsov@virtuozzo.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210324205132.464899-1-vsementsov@virtuozzo.com
Subject: [PATCH v4 00/11] 64bit block-layer: part II

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210323221539.3532660-1-crosa@redhat.com -> patchew/20210323221539.3532660-1-crosa@redhat.com
 * [new tag]         patchew/20210324205132.464899-1-vsementsov@virtuozzo.com -> patchew/20210324205132.464899-1-vsementsov@virtuozzo.com
Switched to a new branch 'test'
bed608a block/io: allow 64bit discard requests
9b3b5c7 block: use int64_t instead of int in driver discard handlers
9d5776f block: make BlockLimits::max_pdiscard 64bit
1dc4bab block/io: allow 64bit write-zeroes requests
05ca540 block: use int64_t instead of int in driver write_zeroes handlers
5864b0d block: make BlockLimits::max_pwrite_zeroes 64bit
9698c13 block: use int64_t instead of uint64_t in copy_range driver handlers
4e60566 block: use int64_t instead of uint64_t in driver write handlers
8aa3af1 block: use int64_t instead of uint64_t in driver read handlers
fc695f9 qcow2: check request on vmstate save/load path
a13a9ef block/io: bring request check to bdrv_co_{read, write}v_vmstate

=== OUTPUT BEGIN ===
1/11 Checking commit a13a9efd128c (block/io: bring request check to bdrv_co_{read, write}v_vmstate)
ERROR: Author email address is mangled by the mailing list
#2: 
Author: Vladimir Sementsov-Ogievskiy via <qemu-devel@nongnu.org>

total: 1 errors, 0 warnings, 42 lines checked

Patch 1/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/11 Checking commit fc695f91df62 (qcow2: check request on vmstate save/load path)
3/11 Checking commit 8aa3af15763f (block: use int64_t instead of uint64_t in driver read handlers)
4/11 Checking commit 4e60566f8a2c (block: use int64_t instead of uint64_t in driver write handlers)
WARNING: line over 80 characters
#379: FILE: block/nvme.c:1233:
+                                        QEMUIOVector *qiov, BdrvRequestFlags flags)

total: 0 errors, 1 warnings, 440 lines checked

Patch 4/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/11 Checking commit 9698c13fe02d (block: use int64_t instead of uint64_t in copy_range driver handlers)
6/11 Checking commit 5864b0dfbf2d (block: make BlockLimits::max_pwrite_zeroes 64bit)
WARNING: Block comments use a leading /* on a separate line
#56: FILE: include/block/block_int.h:679:
+    /* Maximum number of bytes that can zeroized at once. Must be multiple of

WARNING: Block comments use a trailing */ on a separate line
#57: FILE: include/block/block_int.h:680:
+     * pwrite_zeroes_alignment. May be 0 if no inherent 64-bit limit */

total: 0 errors, 2 warnings, 21 lines checked

Patch 6/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/11 Checking commit 05ca54013452 (block: use int64_t instead of int in driver write_zeroes handlers)
8/11 Checking commit 1dc4bab7ab4e (block/io: allow 64bit write-zeroes requests)
9/11 Checking commit 9d5776fcbb03 (block: make BlockLimits::max_pdiscard 64bit)
WARNING: Block comments use a leading /* on a separate line
#55: FILE: include/block/block_int.h:667:
+    /* Maximum number of bytes that can be discarded at once. Must be multiple

WARNING: Block comments use a trailing */ on a separate line
#57: FILE: include/block/block_int.h:669:
+     * inherent 64-bit limit */

total: 0 errors, 2 warnings, 24 lines checked

Patch 9/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/11 Checking commit 9b3b5c7f1465 (block: use int64_t instead of int in driver discard handlers)
11/11 Checking commit bed608a58181 (block/io: allow 64bit discard requests)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210324205132.464899-1-vsementsov@virtuozzo.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Vladimir Sementsov-Ogievskiy March 25, 2021, 7:42 a.m. UTC | #2
25.03.2021 00:13, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20210324205132.464899-1-vsementsov@virtuozzo.com/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Type: series
> Message-id: 20210324205132.464899-1-vsementsov@virtuozzo.com
> Subject: [PATCH v4 00/11] 64bit block-layer: part II
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
> 
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
>  From https://github.com/patchew-project/qemu
>   - [tag update]      patchew/20210323221539.3532660-1-crosa@redhat.com -> patchew/20210323221539.3532660-1-crosa@redhat.com
>   * [new tag]         patchew/20210324205132.464899-1-vsementsov@virtuozzo.com -> patchew/20210324205132.464899-1-vsementsov@virtuozzo.com
> Switched to a new branch 'test'
> bed608a block/io: allow 64bit discard requests
> 9b3b5c7 block: use int64_t instead of int in driver discard handlers
> 9d5776f block: make BlockLimits::max_pdiscard 64bit
> 1dc4bab block/io: allow 64bit write-zeroes requests
> 05ca540 block: use int64_t instead of int in driver write_zeroes handlers
> 5864b0d block: make BlockLimits::max_pwrite_zeroes 64bit
> 9698c13 block: use int64_t instead of uint64_t in copy_range driver handlers
> 4e60566 block: use int64_t instead of uint64_t in driver write handlers
> 8aa3af1 block: use int64_t instead of uint64_t in driver read handlers
> fc695f9 qcow2: check request on vmstate save/load path
> a13a9ef block/io: bring request check to bdrv_co_{read, write}v_vmstate
> 
> === OUTPUT BEGIN ===
> 1/11 Checking commit a13a9efd128c (block/io: bring request check to bdrv_co_{read, write}v_vmstate)
> ERROR: Author email address is mangled by the mailing list
> #2:
> Author: Vladimir Sementsov-Ogievskiy via <qemu-devel@nongnu.org>

That's a strange false-positive.

Look at 1/11: it's not mangled in any way. Looking at the source I see clean "From:" header:

   From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

And there is no any "Author" in the message source at all. "qemu-devel" is noted only in Cc: list.
Vladimir Sementsov-Ogievskiy March 25, 2021, 8:10 a.m. UTC | #3
25.03.2021 10:42, Vladimir Sementsov-Ogievskiy wrote:
> 25.03.2021 00:13, no-reply@patchew.org wrote:
>> Patchew URL: https://patchew.org/QEMU/20210324205132.464899-1-vsementsov@virtuozzo.com/
>>
>>
>>
>> Hi,
>>
>> This series seems to have some coding style problems. See output below for
>> more information:
>>
>> Type: series
>> Message-id: 20210324205132.464899-1-vsementsov@virtuozzo.com
>> Subject: [PATCH v4 00/11] 64bit block-layer: part II
>>
>> === TEST SCRIPT BEGIN ===
>> #!/bin/bash
>> git rev-parse base > /dev/null || exit 0
>> git config --local diff.renamelimit 0
>> git config --local diff.renames True
>> git config --local diff.algorithm histogram
>> ./scripts/checkpatch.pl --mailback base..
>> === TEST SCRIPT END ===
>>
>> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
>>  From https://github.com/patchew-project/qemu
>>   - [tag update]      patchew/20210323221539.3532660-1-crosa@redhat.com -> patchew/20210323221539.3532660-1-crosa@redhat.com
>>   * [new tag]         patchew/20210324205132.464899-1-vsementsov@virtuozzo.com -> patchew/20210324205132.464899-1-vsementsov@virtuozzo.com
>> Switched to a new branch 'test'
>> bed608a block/io: allow 64bit discard requests
>> 9b3b5c7 block: use int64_t instead of int in driver discard handlers
>> 9d5776f block: make BlockLimits::max_pdiscard 64bit
>> 1dc4bab block/io: allow 64bit write-zeroes requests
>> 05ca540 block: use int64_t instead of int in driver write_zeroes handlers
>> 5864b0d block: make BlockLimits::max_pwrite_zeroes 64bit
>> 9698c13 block: use int64_t instead of uint64_t in copy_range driver handlers
>> 4e60566 block: use int64_t instead of uint64_t in driver write handlers
>> 8aa3af1 block: use int64_t instead of uint64_t in driver read handlers
>> fc695f9 qcow2: check request on vmstate save/load path
>> a13a9ef block/io: bring request check to bdrv_co_{read, write}v_vmstate
>>
>> === OUTPUT BEGIN ===
>> 1/11 Checking commit a13a9efd128c (block/io: bring request check to bdrv_co_{read, write}v_vmstate)
>> ERROR: Author email address is mangled by the mailing list
>> #2:
>> Author: Vladimir Sementsov-Ogievskiy via <qemu-devel@nongnu.org>
> 
> That's a strange false-positive.
> 
> Look at 1/11: it's not mangled in any way. Looking at the source I see clean "From:" header:
> 
>    From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> 
> And there is no any "Author" in the message source at all. "qemu-devel" is noted only in Cc: list.
> 

Hmm, but if look at mail on patchew, https://patchew.org/QEMU/20210324205132.464899-1-vsementsov@virtuozzo.com/20210324205132.464899-2-vsementsov@virtuozzo.com/
yes it is mangled..

I hope everyone who is in CC (as me) gets this email not-mangled.