| Message ID | 20210414221457.1653745-1-crosa@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Acceptance Tests: support choosing specific distro and version | expand |
On 4/15/21 12:14 AM, Cleber Rosa wrote: > Cleber Rosa (3): > Acceptance Tests: rename attribute holding the distro image checksum > Acceptance Tests: move definition of distro checksums to the framework > Acceptance Tests: support choosing specific distro and version > > docs/devel/testing.rst | 65 ++++++++++++++++++++++ > tests/acceptance/avocado_qemu/__init__.py | 67 +++++++++++++++++++++-- > tests/acceptance/boot_linux.py | 8 --- > 3 files changed, 127 insertions(+), 13 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Hi CLeber, On 4/15/21 12:14 AM, Cleber Rosa wrote: > Because Fedora 31 will not suit all tests that depend on a Linux > guest, this allows for the configuration of the guest distribution. > It came out of a suggestion from Eric Auger, and it was actually a > feature I planned to submit for a while. > > This is based on the following series: > > [PATCH v3 00/11] Acceptance Test: introduce base class for Linux based tests What is the state of this series, do you plan to respin. My SMMU avocado-qemu tests depend on it. Also I have added some intel iommu tests on top of it. Thanks Eric > > A GitLab CI pipeline can be seen here: > > https://gitlab.com/cleber.gnu/qemu/-/pipelines > > Note: I'll address the line length caught in the check-patch job as > soon as I find what was the outcome of the line limits for Python > code discussion. > > Based-On: <20210412044644.55083-1-crosa@redhat.com> > > Cleber Rosa (3): > Acceptance Tests: rename attribute holding the distro image checksum > Acceptance Tests: move definition of distro checksums to the framework > Acceptance Tests: support choosing specific distro and version > > docs/devel/testing.rst | 65 ++++++++++++++++++++++ > tests/acceptance/avocado_qemu/__init__.py | 67 +++++++++++++++++++++-- > tests/acceptance/boot_linux.py | 8 --- > 3 files changed, 127 insertions(+), 13 deletions(-) >
On 6/9/21 8:11 AM, Eric Auger wrote: > Hi CLeber, > > On 4/15/21 12:14 AM, Cleber Rosa wrote: >> Because Fedora 31 will not suit all tests that depend on a Linux >> guest, this allows for the configuration of the guest distribution. >> It came out of a suggestion from Eric Auger, and it was actually a >> feature I planned to submit for a while. >> >> This is based on the following series: >> >> [PATCH v3 00/11] Acceptance Test: introduce base class for Linux based tests > What is the state of this series, do you plan to respin. My SMMU > avocado-qemu tests depend on it. Also I have added some intel iommu > tests on top of it. Hi Eric, Again, sorry for dropping the ball here. This series has enough reviews, and I can queue it on my upcoming pre-freeze PR. I'll just wait for your ACK on patch 2/3 about keeping the KNOWN_DISTROS info, for now, on the same file. Thanks, - Cleber.
Hi Cleber, On 7/8/21 4:51 PM, Cleber Rosa wrote: > > On 6/9/21 8:11 AM, Eric Auger wrote: >> Hi CLeber, >> >> On 4/15/21 12:14 AM, Cleber Rosa wrote: >>> Because Fedora 31 will not suit all tests that depend on a Linux >>> guest, this allows for the configuration of the guest distribution. >>> It came out of a suggestion from Eric Auger, and it was actually a >>> feature I planned to submit for a while. >>> >>> This is based on the following series: >>> >>> [PATCH v3 00/11] Acceptance Test: introduce base class for Linux >>> based tests >> What is the state of this series, do you plan to respin. My SMMU >> avocado-qemu tests depend on it. Also I have added some intel iommu >> tests on top of it. > > > Hi Eric, > > > Again, sorry for dropping the ball here. This series has enough > reviews, and I can queue it on my upcoming pre-freeze PR. I'll just > wait for your ACK on patch 2/3 about keeping the KNOWN_DISTROS info, > for now, on the same file. No worries. I just sent the ACK for 2/3 of your series. Thanks Eric > > > Thanks, > > - Cleber. >