Message ID | 20210510221511.14205-1-imp@bsdimp.com (mailing list archive) |
---|---|
Headers | show |
Series | bsd-user cleanup | expand |
Patchew URL: https://patchew.org/QEMU/20210510221511.14205-1-imp@bsdimp.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210510221511.14205-1-imp@bsdimp.com Subject: [PATCH 0/3] bsd-user cleanup === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210510221511.14205-1-imp@bsdimp.com -> patchew/20210510221511.14205-1-imp@bsdimp.com - [tag update] patchew/a898b0d5-7086-9699-ae8b-9524ad319b01@t-online.de -> patchew/a898b0d5-7086-9699-ae8b-9524ad319b01@t-online.de Switched to a new branch 'test' 29436b2 bsd-user: rename linux_binprm to bsd_binprm 6dfc63b bsd-user: Stop building the sparc platforms 7664bfd bsd-user: remove target_signal.h, it's unused === OUTPUT BEGIN === 1/3 Checking commit 7664bfde8daf (bsd-user: remove target_signal.h, it's unused) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #22: deleted file mode 100644 total: 0 errors, 1 warnings, 14 lines checked Patch 1/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/3 Checking commit 6dfc63b98ef1 (bsd-user: Stop building the sparc platforms) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: deleted file mode 100644 total: 0 errors, 1 warnings, 0 lines checked Patch 2/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/3 Checking commit 29436b2be985 (bsd-user: rename linux_binprm to bsd_binprm) ERROR: "foo * bar" should be "foo *bar" #58: FILE: bsd-user/elfload.c:1146: +int load_elf_binary(struct bsd_binprm * bprm, struct target_pt_regs * regs, ERROR: "foo * bar" should be "foo *bar" #80: FILE: bsd-user/qemu.h:134: +int load_elf_binary(struct bsd_binprm * bprm, struct target_pt_regs * regs, ERROR: "foo * bar" should be "foo *bar" #83: FILE: bsd-user/qemu.h:136: +int load_flt_binary(struct bsd_binprm * bprm, struct target_pt_regs * regs, total: 3 errors, 0 warnings, 51 lines checked Patch 3/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210510221511.14205-1-imp@bsdimp.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On 5/10/21 5:15 PM, Warner Losh wrote: > Warner Losh (3): > bsd-user: remove target_signal.h, it's unused > bsd-user: Stop building the sparc platforms > bsd-user: rename linux_binprm to bsd_binprm Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~