[v2,0/6] Python: delint python library

Message

John Snow May 17, 2021, 6:48 p.m. UTC

gitlab CI: https://gitlab.com/jsnow/qemu/-/pipelines/304224309
branch: https://gitlab.com/jsnow/qemu/-/commits/python-package-pre-cleanup

This series serves as a pre-requisite for packaging the python series
and getting the linters running via CI. The first patch fixes a linter
error we've had for a while now; the subsequent ones fix a new warning
that was recently added to pylint 2.8.x.

V2:
 - iotest bits already handled, dropped here.
 - Changed patch #3 based on feedback from Wainer.

John Snow (6):
  python/console_socket: avoid one-letter variable
  python/machine: use subprocess.DEVNULL instead of
    open(os.path.devnull)
  python/machine: use subprocess.run instead of subprocess.Popen
  python/console_socket: Add a pylint ignore
  python/machine: Disable pylint warning for open() in _pre_launch
  python/machine: disable warning for Popen in _launch()

 python/qemu/console_socket.py | 11 ++++++-----
 python/qemu/machine.py        | 28 ++++++++++++++++++----------
 2 files changed, 24 insertions(+), 15 deletions(-)

Comments

John Snow May 18, 2021, 1:33 p.m. UTC | #1

On 5/17/21 2:48 PM, John Snow wrote:
> gitlab CI: https://gitlab.com/jsnow/qemu/-/pipelines/304224309
> branch: https://gitlab.com/jsnow/qemu/-/commits/python-package-pre-cleanup
> 
> This series serves as a pre-requisite for packaging the python series
> and getting the linters running via CI. The first patch fixes a linter
> error we've had for a while now; the subsequent ones fix a new warning
> that was recently added to pylint 2.8.x.
> 
> V2:
>   - iotest bits already handled, dropped here.
>   - Changed patch #3 based on feedback from Wainer.
> 
> John Snow (6):
>    python/console_socket: avoid one-letter variable
>    python/machine: use subprocess.DEVNULL instead of
>      open(os.path.devnull)
>    python/machine: use subprocess.run instead of subprocess.Popen
>    python/console_socket: Add a pylint ignore
>    python/machine: Disable pylint warning for open() in _pre_launch
>    python/machine: disable warning for Popen in _launch()
> 
>   python/qemu/console_socket.py | 11 ++++++-----
>   python/qemu/machine.py        | 28 ++++++++++++++++++----------
>   2 files changed, 24 insertions(+), 15 deletions(-)
> 

Thank you for reviews! Staged to my Python branch.

--js