[RFC,0/4] target/ppc: mmu cleanup

Message

Lucas Mateus Martins Araujo e Castro June 2, 2021, 7:26 p.m. UTC

This patch series aims to clean up some of the code in mmu-hash64.c and
mmu_helper.c, including removing the includes inside ifdef of those
files.

Helpers are in mmu_helper.c now and code that is needed in a !TCG build
are in mmu-hash64.c and mmu_common.c.

Comments are welcome, thanks,
Lucas Mateus.
Based-on: 558f3e1031caf539b74d2891f6a8fb491735a1ac

Lucas Mateus Castro (alqotel) (4):
  target/ppc: Don't compile ppc_tlb_invalid_all without TCG
  target/ppc: divided mmu_helper.c in 2 files
  target/ppc: moved ppc_store_sdr1 to mmu_common.c
  target/ppc: Moved helpers to mmu_helper.c

 target/ppc/cpu.c        |   28 -
 target/ppc/cpu.h        |   35 +
 target/ppc/cpu_init.c   |    4 +
 target/ppc/internal.h   |   26 +
 target/ppc/meson.build  |    6 +-
 target/ppc/mmu-hash64.c |  219 +----
 target/ppc/mmu-hash64.h |    1 +
 target/ppc/mmu_common.c | 1634 +++++++++++++++++++++++++++++++
 target/ppc/mmu_helper.c | 2023 ++++++---------------------------------
 9 files changed, 2019 insertions(+), 1957 deletions(-)
 create mode 100644 target/ppc/mmu_common.c

Comments

[e-mail] June 9, 2021, 2:13 p.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: [e-mail]
Subject: [RFC PATCH 0/4] target/ppc: mmu cleanup

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
183d120 target/ppc: Moved helpers to mmu_helper.c
c3d77cb target/ppc: moved ppc_store_sdr1 to mmu_common.c
7c84c42 target/ppc: divided mmu_helper.c in 2 files
90a38ae target/ppc: Don't compile ppc_tlb_invalid_all without TCG

=== OUTPUT BEGIN ===
1/4 Checking commit 90a38ae56c59 (target/ppc: Don't compile ppc_tlb_invalid_all without TCG)
WARNING: line over 80 characters
#30: FILE: target/ppc/cpu_init.c:8915:
+       cpu_abort(env_cpu(env),"PowerPC not in real mode, invalid in this build\n");

ERROR: code indent should never use tabs
#30: FILE: target/ppc/cpu_init.c:8915:
+^Icpu_abort(env_cpu(env),"PowerPC not in real mode, invalid in this build\n");$

ERROR: space required after that ',' (ctx:VxV)
#30: FILE: target/ppc/cpu_init.c:8915:
+       cpu_abort(env_cpu(env),"PowerPC not in real mode, invalid in this build\n");
                              ^

total: 2 errors, 1 warnings, 39 lines checked

Patch 1/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/4 Checking commit 7c84c4276936 (target/ppc: divided mmu_helper.c in 2 files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#125: 
new file mode 100644

WARNING: line over 80 characters
#1538: FILE: target/ppc/mmu_common.c:1409:
+                    env->spr[SPR_BOOKE_ESR] = mmubooke206_esr(mmu_idx, MMU_DATA_LOAD);

WARNING: line over 80 characters
#1625: FILE: target/ppc/mmu_common.c:1496:
+                    booke206_update_mas_tlb_miss(env, address, access_type, mmu_idx);

WARNING: line over 80 characters
#1631: FILE: target/ppc/mmu_common.c:1502:
+                    env->spr[SPR_BOOKE_ESR] = mmubooke206_esr(mmu_idx, access_type);

WARNING: line over 80 characters
#1655: FILE: target/ppc/mmu_common.c:1526:
+                    env->spr[SPR_BOOKE_ESR] = mmubooke206_esr(mmu_idx, access_type);

total: 0 errors, 5 warnings, 3351 lines checked

Patch 2/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/4 Checking commit c3d77cbc7606 (target/ppc: moved ppc_store_sdr1 to mmu_common.c)
4/4 Checking commit 183d120bd746 (target/ppc: Moved helpers to mmu_helper.c)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]