Message ID | 20210604200353.1206897-1-danielhb413@gmail.com (mailing list archive) |
---|---|
Headers | show |
Series | DEVICE_UNPLUG_ERROR QAPI event | expand |
On Fri, Jun 04, 2021 at 05:03:51PM -0300, Daniel Henrique Barboza wrote: > Hi, > > This is the v2 of a series that started with 2 events, > DEVICE_UNPLUG_ERROR and DEVICE_NOT_DELETED [1]. After discussions in v1 > we reached the conclussion that the DEVICE_NOT_DELETED wasn't doing much > of anything. It was an event that was trying to say 'I think something > happen, but I'm not sure', forcing the QAPI listener to inspect the > guest itself to see what went wrong, or just wait for some sort of > internal timeout (as Libvirt will do) and fail the operation regardless. > > During this period between v1 and this v2 the PowerPC kernel was changed > to add a reliable error report mechanism in the device_removal path of > CPUs, which in turn gave QEMU the opportunity to do the same. This made > the DEVICE_UNPLUG_ERROR more relevant because now we can report CPU and > DIMM hotunplug errors. > > > changes from v1: > - former patches 1 and 2: dropped > - patch 1 (former 3): changed the version to '6.1' > - patch 2 (former 4): add a DEVICE_UNPLUG_ERROR event in the device > unplug error path of CPUs and DIMMs > > [1] v1 link: > https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg04682.html It would be nice to add a patch making x86 also issue the new error format (as well as the old) on memory hot unplug errors. > > > > Daniel Henrique Barboza (2): > qapi/machine.json: add DEVICE_UNPLUG_ERROR QAPI event > spapr: use DEVICE_UNPLUG_ERROR to report unplug errors > > hw/ppc/spapr.c | 2 +- > hw/ppc/spapr_drc.c | 15 +++++++++------ > qapi/machine.json | 23 +++++++++++++++++++++++ > 3 files changed, 33 insertions(+), 7 deletions(-) >