[0/2] tcg: Fixes for temp_allocate_frame

Message

Richard Henderson June 19, 2021, 4:56 a.m. UTC

Stefan, I think this will resolve #367 for you -- please test.


r~


Richard Henderson (2):
  tcg/sparc: Fix temp_allocate_frame vs sparc stack bias
  tcg: Allocate sufficient storage in temp_allocate_frame

 tcg/tcg.c                  | 41 ++++++++++++++++++++++++++++----------
 tcg/sparc/tcg-target.c.inc | 16 +++++++++------
 2 files changed, 40 insertions(+), 17 deletions(-)

Comments

Stefan Weil June 19, 2021, 8:16 a.m. UTC | #1

Am 19.06.21 um 06:56 schrieb Richard Henderson:

> Stefan, I think this will resolve #367 for you -- please test.


Tested-by: Stefan Weil <[e-mail]>


Thank you, yes, it seems to resolve that issue.

I had to make two additional changes for building on Windows:

- Downgrade to support glib 2.54 (that's the version provided by Cygwin 
for mingw-w64). Daniel, could we go back from 2.56 to 2.54?

- Fix assertion in oslib-win32.c (I already have sent a patch for that, 
see 
http://patchwork.ozlabs.org/project/qemu-devel/patch/[e-mail]/)

Stefan

Daniel P. Berrangé June 21, 2021, 8:42 a.m. UTC | #2

On Sat, Jun 19, 2021 at 10:16:55AM +0200, Stefan Weil wrote:
> Am 19.06.21 um 06:56 schrieb Richard Henderson:
> 
> > Stefan, I think this will resolve #367 for you -- please test.
> 
> 
> Tested-by: Stefan Weil <[e-mail]>
> 
> 
> Thank you, yes, it seems to resolve that issue.
> 
> I had to make two additional changes for building on Windows:
> 
> - Downgrade to support glib 2.54 (that's the version provided by Cygwin for
> mingw-w64). Daniel, could we go back from 2.56 to 2.54?

2.55.1 introduced support for autoptr with GSList/GList and we have already
started using this functionality, so it isn't a clean downgrade.

I'm pretty surprised cygwin would be on 2.54, as that is almost a 3 year
old release at this point in time. What's their timeframe for actually
pulling in a new release ? 

Regards,
Daniel