mbox series

[v5,00/11] block: file-posix queue

Message ID 20210624180423.1322165-1-pbonzini@redhat.com (mailing list archive)
Headers show
Series block: file-posix queue | expand

Message

Paolo Bonzini June 24, 2021, 6:04 p.m. UTC
New patches:
- 3/4 (for review comments),
- 9 (split for ease of review),
- 11 (new bugfix)

v1->v2: add missing patch

v2->v3: add max_hw_transfer to BlockLimits

v3->v4: fix compilation after patch 1, tweak commit messages according
        to Vladimir's review

v4->v5: round down max_transfer and max_hw_transfer to request alignment
        checkpatch fixes
        return -ENOTSUP, -not -EIO if block limits ioctls fail
        handle host_cdrom like host_device in QAPI
        split "block: try BSD disk size ioctls one after another"
        new bugfix patch "file-posix: handle EINTR during ioctl"

Joelle van Dyne (3):
  block: feature detection for host block support
  block: check for sys/disk.h
  block: detect DKIOCGETBLOCKCOUNT/SIZE before use

Paolo Bonzini (8):
  file-posix: fix max_iov for /dev/sg devices
  scsi-generic: pass max_segments via max_iov field in BlockLimits
  osdep: provide ROUND_DOWN macro
  block-backend: align max_transfer to request alignment
  block: add max_hw_transfer to BlockLimits
  file-posix: try BLKSECTGET on block devices too, do not round to power of 2
  block: try BSD disk size ioctls one after another
  file-posix: handle EINTR during ioctl

 block.c                        |   2 +-
 block/block-backend.c          |  19 ++++-
 block/file-posix.c             | 144 ++++++++++++++++++++-------------
 block/io.c                     |   2 +
 hw/scsi/scsi-generic.c         |   6 +-
 include/block/block_int.h      |   7 ++
 include/qemu/osdep.h           |  28 +++++--
 include/sysemu/block-backend.h |   1 +
 meson.build                    |   7 +-
 qapi/block-core.json           |  14 +++-
 10 files changed, 156 insertions(+), 74 deletions(-)

Comments

Max Reitz June 25, 2021, 8:37 a.m. UTC | #1
On 24.06.21 20:04, Paolo Bonzini wrote:
> New patches:
> - 3/4 (for review comments),
> - 9 (split for ease of review),
> - 11 (new bugfix)
>
> v1->v2: add missing patch
>
> v2->v3: add max_hw_transfer to BlockLimits
>
> v3->v4: fix compilation after patch 1, tweak commit messages according
>          to Vladimir's review
>
> v4->v5: round down max_transfer and max_hw_transfer to request alignment
>          checkpatch fixes
>          return -ENOTSUP, -not -EIO if block limits ioctls fail
>          handle host_cdrom like host_device in QAPI
>          split "block: try BSD disk size ioctls one after another"
>          new bugfix patch "file-posix: handle EINTR during ioctl"

Thanks, looks good to me, though I’m afraid I’ll be on PTO the next two 
weeks so I can’t take this series through my tree... (I don’t really 
want to send a pull request today when I probably wouldn’t be able to 
deal with potential problems)

Max
Paolo Bonzini June 25, 2021, 8:52 a.m. UTC | #2
On 25/06/21 10:37, Max Reitz wrote:
> Thanks, looks good to me, though I’m afraid I’ll be on PTO the next two 
> weeks so I can’t take this series through my tree... (I don’t really 
> want to send a pull request today when I probably wouldn’t be able to 
> deal with potential problems)

I can take it too, if it's okay for you.

Paolo
Max Reitz June 25, 2021, 9:28 a.m. UTC | #3
On 25.06.21 10:52, Paolo Bonzini wrote:
> On 25/06/21 10:37, Max Reitz wrote:
>> Thanks, looks good to me, though I’m afraid I’ll be on PTO the next 
>> two weeks so I can’t take this series through my tree... (I don’t 
>> really want to send a pull request today when I probably wouldn’t be 
>> able to deal with potential problems)
>
> I can take it too, if it's okay for you.

Sure!