From patchwork Fri Jul 9 05:31:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jeffery X-Patchwork-Id: 12366763 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9AACC07E99 for ; Fri, 9 Jul 2021 05:46:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85C0161442 for ; Fri, 9 Jul 2021 05:46:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85C0161442 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aj.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1jLb-0003ls-Nb for qemu-devel@archiver.kernel.org; Fri, 09 Jul 2021 01:46:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1j6j-0004n1-0R; Fri, 09 Jul 2021 01:31:25 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:43619) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1j6h-0008IU-3b; Fri, 09 Jul 2021 01:31:24 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6DB4B5C00EB; Fri, 9 Jul 2021 01:31:20 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 09 Jul 2021 01:31:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=from :to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm3; bh=TXhzzxIW+IcWhVU0QMlhUaNeFs 7ytRFgGqBuU9GSSgA=; b=pE4c7ptfpcgzlMesFjGcnMMpxqMLGiVgXUpM4I1pDq mn3TMVyjzHGL92F393QlpR3PCUSMlwXBcMNxjqJWChr2vezWLaW+2S23agK5wpFd JDLfghNM5qDlK7QtwX8Vb+0tydDLZlSr3oBbbXVlEoS6N0Yrg7KqCZ/Zg4+sORNC +3zNeUD8x+/8/wm6HdI974gYHXwu1JbMwUVUobjfS8Ies19UhzmszCV8Fm73h/tb bJAfyzWZxteRmP4L/Clw3mKoI3nr4o1AxIxtrZZoo+QDInlH5sFghMdwaCSfdRl2 kvFe78JcyHDaScPXU8PdSftT2TFHG6/UVX17/4nbeT+g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=TXhzzxIW+IcWhVU0Q MlhUaNeFs7ytRFgGqBuU9GSSgA=; b=q9sJQmtiNyqHMBcM0u+W4nSDrV5vsjwbw 8Jt3ok2+ZLD9iyak8pmOaNC/LvhgnSmzzD9EFhq9f4Ovam9Up2po5210zn/b0MCp mbxTKFvES4a86VMaPgv2CdGTquo31QJhDcwJmLRYOFhBwMh6rlGNMlKd1i2o5Rkb SFRAXm/JdKdZ7eXdLHK2bhZKBgUICDqvaHmJJWZlMegYQt1/AakfySHp7Km0/7j3 HfGTrv3yjVGKWvNy1Ze4241IQLWDhyxtRbRd8Ycy4kAzMIqqdBrQ7s0bFE1zGVYK 8lXQd4qfPKg7xRDkhy8dGQdrUtaZp7owSQdfgmGmlAI4+i2UqlXAA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrtdehgdeijecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffoggfgsedtkeertdertd dtnecuhfhrohhmpeetnhgurhgvficulfgvfhhfvghrhicuoegrnhgurhgvfiesrghjrdhi ugdrrghuqeenucggtffrrghtthgvrhhnpeekhfeiffejveefveehtdeiiefhfedvjeelvd dvtdehffetudejtefhueeuleeftdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpegrnhgurhgvfiesrghjrdhiugdrrghu X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 9 Jul 2021 01:31:17 -0400 (EDT) From: Andrew Jeffery To: qemu-devel@nongnu.org Subject: [PATCH 0/2] wdt_aspeed: Fix behaviour of control register Date: Fri, 9 Jul 2021 15:01:05 +0930 Message-Id: <20210709053107.1829304-1-andrew@aj.id.au> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Received-SPF: pass client-ip=66.111.4.25; envelope-from=andrew@aj.id.au; helo=out1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, clg@kaod.org, joel@jms.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hello, I discovered a couple of bugs in the watchdog while testing a tool to poke Aspeed BMCs over their various AHB bridges. The immediate observation was that the model for the 2500 wasn't signalling use of the fixed 1MHz clock, which is resolved in the first patch. The other observation was that sequential writes to control weren't sticking if the enable bit wasn't toggled, which is fixed in the second patch. Please review. Andrew Andrew Jeffery (2): watchdog: aspeed: Sanitize control register values watchdog: aspeed: Fix sequential control writes hw/watchdog/wdt_aspeed.c | 26 ++++++++++++++++++++++++-- include/hw/watchdog/wdt_aspeed.h | 1 + 2 files changed, 25 insertions(+), 2 deletions(-)