mbox series

[RFC,v3,0/5] pSeries FORM2 affinity support

Message ID 20210713194045.916263-1-danielhb413@gmail.com (mailing list archive)
Headers show
Series pSeries FORM2 affinity support | expand

Message

Daniel Henrique Barboza July 13, 2021, 7:40 p.m. UTC
Hi,

This new version drops all the NVDIMM related changes from the
previous iteraction after the reviews done in the kernel mailing
list [1]. FORM2 will not use ibm,associativity-reference-points to
determine a second NUMA mode for different operation modes of
PAPR-SCM.

[1] https://lore.kernel.org/linuxppc-dev/20210628151117.545935-1-aneesh.kumar@linux.ibm.com/


changes from v2:
- patch 3:
  * reworded commit msg and comments to reflect the current state of
the specification
- patches 5 and 6: removed
- v2 link: https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg04056.html 


changes from v1:
- patches 1 and 2: switched places
- patch 3: folded into patch 2
- patch 2:
    * only make CAS related changes when using the newest
    machine version
- patch 3 (former 4):
    * only advertise FORM2 support for the newest machine version
- patches 5 and 6 (former 6 and 7):
    * detect if 'device-node' was set in the command line, and if not,
    use the 'node' value when writing in the device tree

v1 link: https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg03617.html


Daniel Henrique Barboza (5):
  spapr_numa.c: split FORM1 code into helpers
  spapr: move NUMA data init to post-CAS
  spapr_numa.c: base FORM2 NUMA affinity support
  spapr: simplify spapr_numa_associativity_init params
  spapr: move memory/cpu less check to spapr_numa_FORM1_affinity_init()

 hw/ppc/spapr.c              |  60 ++++------
 hw/ppc/spapr_hcall.c        |   4 +
 hw/ppc/spapr_numa.c         | 224 +++++++++++++++++++++++++++++++++---
 include/hw/ppc/spapr.h      |   1 +
 include/hw/ppc/spapr_numa.h |   3 +-
 include/hw/ppc/spapr_ovec.h |   1 +
 6 files changed, 236 insertions(+), 57 deletions(-)

Comments

David Gibson July 22, 2021, 2:39 a.m. UTC | #1
On Tue, Jul 13, 2021 at 04:40:40PM -0300, Daniel Henrique Barboza wrote:
> Hi,
> 
> This new version drops all the NVDIMM related changes from the
> previous iteraction after the reviews done in the kernel mailing
> list [1]. FORM2 will not use ibm,associativity-reference-points to
> determine a second NUMA mode for different operation modes of
> PAPR-SCM.
> 
> [1]
> https://lore.kernel.org/linuxppc-dev/20210628151117.545935-1-aneesh.kumar@linux.ibm.com/

Sorry, I'm going to punt on reviewing this again, until the kernel
side patches are sorted out.

> 
> 
> changes from v2:
> - patch 3:
>   * reworded commit msg and comments to reflect the current state of
> the specification
> - patches 5 and 6: removed
> - v2 link: https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg04056.html 
> 
> 
> changes from v1:
> - patches 1 and 2: switched places
> - patch 3: folded into patch 2
> - patch 2:
>     * only make CAS related changes when using the newest
>     machine version
> - patch 3 (former 4):
>     * only advertise FORM2 support for the newest machine version
> - patches 5 and 6 (former 6 and 7):
>     * detect if 'device-node' was set in the command line, and if not,
>     use the 'node' value when writing in the device tree
> 
> v1 link: https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg03617.html
> 
> 
> Daniel Henrique Barboza (5):
>   spapr_numa.c: split FORM1 code into helpers
>   spapr: move NUMA data init to post-CAS
>   spapr_numa.c: base FORM2 NUMA affinity support
>   spapr: simplify spapr_numa_associativity_init params
>   spapr: move memory/cpu less check to spapr_numa_FORM1_affinity_init()
> 
>  hw/ppc/spapr.c              |  60 ++++------
>  hw/ppc/spapr_hcall.c        |   4 +
>  hw/ppc/spapr_numa.c         | 224 +++++++++++++++++++++++++++++++++---
>  include/hw/ppc/spapr.h      |   1 +
>  include/hw/ppc/spapr_numa.h |   3 +-
>  include/hw/ppc/spapr_ovec.h |   1 +
>  6 files changed, 236 insertions(+), 57 deletions(-)
>