From patchwork Mon Aug 16 14:58:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 12438761 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35265C432BE for ; Mon, 16 Aug 2021 15:02:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC8E860F39 for ; Mon, 16 Aug 2021 15:02:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DC8E860F39 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:32872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFe86-0004jc-2A for qemu-devel@archiver.kernel.org; Mon, 16 Aug 2021 11:02:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFe4Z-0007Bf-R8 for qemu-devel@nongnu.org; Mon, 16 Aug 2021 10:58:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:33799) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFe4Y-0004DQ-FH for qemu-devel@nongnu.org; Mon, 16 Aug 2021 10:58:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629125921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8MLyPSdACvEeb433ANrYrj8i7aeh2t4uYIu8HISJEp8=; b=FpkJ9hwvycmQD8jiNSnX4+DDvEEtz6YMPBZlNyJFvE6edTeuhdfZQ0oYW928rW93y6qrM0 ES2lhRqUHyRCBHq7cYoI0+kIMEqscXBKK0/6XHnlZeCSjca8zQhp+139efeIsdiWwpu/vS y3RjiCZHW3cONC3DqEynYxdhWh6fY20= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-442-pPZmZ1naMVeEAqPchHef5w-1; Mon, 16 Aug 2021 10:58:40 -0400 X-MC-Unique: pPZmZ1naMVeEAqPchHef5w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BA0131937FC2; Mon, 16 Aug 2021 14:58:39 +0000 (UTC) Received: from thinkpad.redhat.com (unknown [10.39.194.70]) by smtp.corp.redhat.com (Postfix) with ESMTP id D2951620DE; Mon, 16 Aug 2021 14:58:25 +0000 (UTC) From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [RFC PATCH 0/6] virtio-net failover cleanup and new features Date: Mon, 16 Aug 2021 16:58:18 +0200 Message-Id: <20210816145824.15825-1-lvivier@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lvivier@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=lvivier@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.698, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Eduardo Habkost , "Michael S. Tsirkin" , Jason Wang , Juan Quintela , Alex Williamson , Paolo Bonzini , Jens Freimann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This series moves the code used by virtio-net failover from the virtio-net device to the PCI subsystem. Doing that, we can use failover with a regular QEMU PCI device (we can add the function call to unregister the ROM vmstate) and we can also use this code to unplug a PCI card before migration and plug it back after migration without using a failover device (of course, connectivity is lost during all the migration). In contrary of failover, this does not need support from the guest system to work. Laurent Vivier (6): qdev: add an Error parameter to the DeviceListener hide_device() function qdev/qbus: remove failover specific code failover: virtio-net: remove failover_primary_hidden flag failover: pci: move failover hotplug/unplug code into pci subsystem failover: pci: unregister ROM on unplug pci: automatically unplug a PCI card before migration include/hw/pci/pci.h | 5 + include/hw/qdev-core.h | 6 +- include/hw/virtio/virtio-net.h | 4 - include/hw/virtio/virtio.h | 1 - hw/core/qdev.c | 4 +- hw/net/virtio-net.c | 144 ------------------- hw/pci/pci.c | 245 +++++++++++++++++++++++++++++++-- hw/vfio/pci.c | 2 +- softmmu/qdev-monitor.c | 14 +- 9 files changed, 252 insertions(+), 173 deletions(-)