From patchwork Fri Sep 24 12:27:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Mammedov X-Patchwork-Id: 12515209 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D886C433EF for ; Fri, 24 Sep 2021 12:42:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2FE4961107 for ; Fri, 24 Sep 2021 12:42:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2FE4961107 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:41686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTkXA-00085W-Aw for qemu-devel@archiver.kernel.org; Fri, 24 Sep 2021 08:42:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTkJK-00045k-8v for qemu-devel@nongnu.org; Fri, 24 Sep 2021 08:28:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30673) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTkJH-00014d-FV for qemu-devel@nongnu.org; Fri, 24 Sep 2021 08:28:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632486489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=92dKoxfV9Q3K5rKNQSEMLMnAVjzWkSkCwOuUQ38P5NY=; b=Hb51epALp7DYl2YUUE9kyBAV2O0YPDyrgKRruRoGHTYZjCZNpAO96Tgj5s+I6xni43hVs/ dG1y/FHw4RaNIkYIAcAoiN74oWfSkQxdq17mZ+NZlfV70vBiUy9ZZbisVm5EIT+qHNs3Up hW7nKx92wWKkDptil42fBtBnSPrtutg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-485-zehFwHioPMi3Pw3UnR4G-g-1; Fri, 24 Sep 2021 08:28:08 -0400 X-MC-Unique: zehFwHioPMi3Pw3UnR4G-g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 72010101F002; Fri, 24 Sep 2021 12:28:07 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2B2AF6A904; Fri, 24 Sep 2021 12:28:04 +0000 (UTC) From: Igor Mammedov To: qemu-devel@nongnu.org Subject: [PATCH v4 00/35] acpi: refactor error prone build_header() and packed structures usage in ACPI tables Date: Fri, 24 Sep 2021 08:27:27 -0400 Message-Id: <20210924122802.1455362-1-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.473, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ani@anisinha.ca, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" v4: 1. comments fixups and diing missing comments 2. clean up spurious changes 3. rebase on top of (4be8bfcb4d hw/i386/acpi-build: Fix a typo) 4. convert build_iort: * keep nb_nodes variable * encode 'Memory access properties' as separate entries according to Table 13 v3: 1. s/acpi_init_table()|acpi_table_composed()/acpi_table_begin()|acpi_table_end()/ 2. arm:madt fix incorrect length 3. various comment improvments 4. rewrite IORT conversion patch due to heavy conflicts with bypass iommu code merged recently 5 pick up Eric's Reviewed-By where there wasn't significant change (1) v2: - drop test related patches, they will be sent as a separate series - fix bios_loader pointer initialization ordering when using TPM1.2 - extend commit message of [1/35] and add extra comment about table length patching Highlights: * drop pointer arithmetic in ACPI tables code * use endian agnostic API * simplifies review of tables. /in most cases just line by line comparision with spec/ Series replaces build_header() with acpi_table_begin()/acpi_table_end() API that hides pointer/offset arithmetic from user, to prevent errors caused by it [1]. While doing above, it was necessary to split table header from packed structure that was describing the table, which is counter-productive since it still leaves packed structure drawbacks. So that sort of forced me to rewrite tables that were composed with help of packed structures to preferred build_append_int_noprefix() API. In cases where refactoring to build_append_int_noprefix() was small, it was squashed with acpi_table_begin()/acpi_table_end() patch. Conversion reduced code size quite a bit despite me adding doc comments for every table row. 1) commits bb9feea43179 x86: acpi: use offset instead of pointer when using build_header() 4d027afeb3a9 Virt: ACPI: fix qemu assert due to re-assigned table data address Link to repo with this series and tests to validate it: https://gitlab.com/imammedo/qemu/-/commits/acpi_build_header_refactoring_v4 Previous v3 revision can be found at: https://lore.kernel.org/qemu-devel/20210907144814.741785-22-imammedo@redhat.com/T/ CC: mst@redhat.com CC: ani@anisinha.ca Igor Mammedov (35): acpi: add helper routines to initialize ACPI tables acpi: build_rsdt: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: build_xsdt: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: build_slit: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: build_fadt: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: build_tpm2: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: acpi_build_hest: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: build_mcfg: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: build_hmat: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: nvdimm_build_nfit: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: nvdimm_build_ssdt: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: vmgenid_build_acpi: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: x86: build_dsdt: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: build_hpet: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: build_tpm_tcpa: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: arm/x86: build_srat: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: use build_append_int_noprefix() API to compose SRAT table acpi: build_dmar_q35: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: build_waet: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: build_amd_iommu: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: madt: arm/x86: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: x86: remove dead code acpi: x86: set enabled when composing _MAT entries acpi: x86: madt: use build_append_int_noprefix() API to compose MADT table acpi: arm/virt: madt: use build_append_int_noprefix() API to compose MADT table acpi: build_dsdt_microvm: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: arm: virt: build_dsdt: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: arm: virt: build_iort: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: arm/virt: convert build_iort() to endian agnostic build_append_FOO() API acpi: arm/virt: build_spcr: fix invalid cast acpi: arm/virt: build_spcr: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: arm/virt: build_gtdt: use acpi_table_begin()/acpi_table_end() instead of build_header() acpi: build_facs: use build_append_int_noprefix() API to compose table acpi: remove no longer used build_header() acpi: AcpiGenericAddress no longer used to map/access fields of MMIO, drop packed attribute include/hw/acpi/acpi-defs.h | 528 +----------------------- include/hw/acpi/acpi_dev_interface.h | 3 +- include/hw/acpi/aml-build.h | 37 +- include/hw/i386/pc.h | 6 +- hw/acpi/acpi-x86-stub.c | 3 +- hw/acpi/aml-build.c | 203 ++++++---- hw/acpi/cpu.c | 17 +- hw/acpi/ghes.c | 10 +- hw/acpi/hmat.c | 14 +- hw/acpi/nvdimm.c | 64 ++- hw/acpi/pci.c | 18 +- hw/acpi/vmgenid.c | 13 +- hw/arm/virt-acpi-build.c | 577 +++++++++++++++------------ hw/i386/acpi-build.c | 294 ++++++++------ hw/i386/acpi-common.c | 160 ++++---- hw/i386/acpi-microvm.c | 13 +- 16 files changed, 801 insertions(+), 1159 deletions(-)