From patchwork Wed Sep 29 14:43:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 12525691 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E201C433EF for ; Wed, 29 Sep 2021 14:45:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C8CE61288 for ; Wed, 29 Sep 2021 14:45:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1C8CE61288 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:43266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVaq4-0007wi-5U for qemu-devel@archiver.kernel.org; Wed, 29 Sep 2021 10:45:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVanm-0006V7-6f for qemu-devel@nongnu.org; Wed, 29 Sep 2021 10:43:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:35092) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVank-0007Aj-Rd for qemu-devel@nongnu.org; Wed, 29 Sep 2021 10:43:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632926595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AEye2avFIwyDDCaft0Bs+75h9Cj69fqj1vbKM2JMyy0=; b=J7VE50HP0u2Nj4AQF2mxL6DsBlSwhfw3kdwvF0emuMqXHm/Kcnj4FTbN2BZ0KW81RcYWIl 3cHR3NSAscmXTngib39wADMQJmqP+Z8VMhlkeNCR2MiPdkxUkpyXyQct4NrTkujSO58oi4 yWp7VtASgjlbNaU91MUTvnHQ5Z+cqm8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-340-2VdUJ6OzP5mZK5_dPGo9zg-1; Wed, 29 Sep 2021 10:43:14 -0400 X-MC-Unique: 2VdUJ6OzP5mZK5_dPGo9zg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B6F48100CCF0 for ; Wed, 29 Sep 2021 14:43:13 +0000 (UTC) Received: from thinkpad.redhat.com (unknown [10.39.192.246]) by smtp.corp.redhat.com (Postfix) with ESMTP id 57A5410016F4; Wed, 29 Sep 2021 14:43:12 +0000 (UTC) From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PATCH 0/2] failover: don't allow to migrate a paused VM that needs PCI unplug Date: Wed, 29 Sep 2021 16:43:09 +0200 Message-Id: <20210929144311.1168561-1-lvivier@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lvivier@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=lvivier@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , Juan Quintela , "Dr. David Alan Gilbert" , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" As the guest OS is paused, we will never receive the unplug event from the kernel and the migration cannot continue. The first patch is optional, it provides the error message to display to migration_cancel() rather than to have to call migrate_set_error() from the caller. Laurent Vivier (2): migration: provide an error message to migration_cancel() failover: don't allow to migrate a paused VM that needs PCI unplug migration/migration.h | 2 +- hw/net/virtio-net.c | 10 +++++++++- migration/migration.c | 9 ++++++--- migration/ram.c | 3 +-- 4 files changed, 17 insertions(+), 7 deletions(-)