From patchwork Tue Oct 5 08:07:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emanuele Giuseppe Esposito X-Patchwork-Id: 12535811 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2437C433EF for ; Tue, 5 Oct 2021 08:24:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B92F76137C for ; Tue, 5 Oct 2021 08:24:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B92F76137C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:48890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXfkY-0002Ct-LT for qemu-devel@archiver.kernel.org; Tue, 05 Oct 2021 04:24:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXfUv-0004qF-4q for qemu-devel@nongnu.org; Tue, 05 Oct 2021 04:08:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42742) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXfUt-0004A2-ME for qemu-devel@nongnu.org; Tue, 05 Oct 2021 04:08:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633421301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+v71AO6jtKaB3HCXPDemq5ZlFwT76ZHoedpNVD75QXc=; b=M7MXsAlkWn8NSCnoKa+4YyQoijad1vgd/HPF9mOeR68KR7yC+TwDsVs9wo7blNmbqoEPi/ ++yygHLRT8OAt2TBETKgFzGp4JoTocirpZTSBkIPWFI3BzD4kdby29h6xvK/d7OBErT3j+ owSlkdQG2E3H2a2gz43zbhvPy0kGank= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-121-C21SSmArNWiLNdwKG9FQPA-1; Tue, 05 Oct 2021 04:08:20 -0400 X-MC-Unique: C21SSmArNWiLNdwKG9FQPA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 459F984A5E3; Tue, 5 Oct 2021 08:08:19 +0000 (UTC) Received: from virtlab701.virt.lab.eng.bos.redhat.com (virtlab701.virt.lab.eng.bos.redhat.com [10.19.152.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7BAF010013C1; Tue, 5 Oct 2021 08:08:14 +0000 (UTC) From: Emanuele Giuseppe Esposito To: qemu-block@nongnu.org Subject: [PATCH v1 0/2] Migration: fix missing iothread locking Date: Tue, 5 Oct 2021 04:07:49 -0400 Message-Id: <20211005080751.3797161-1-eesposit@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eesposit@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=eesposit@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.066, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Emanuele Giuseppe Esposito , Vladimir Sementsov-Ogievskiy , Juan Quintela , Eric Blake , "Dr. David Alan Gilbert" , qemu-devel@nongnu.org, Stefan Hajnoczi , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Some functions (in this case qemu_savevm_state_complete_postcopy() and init_dirty_bitmap_migration()) assume and document that qemu_mutex_lock_iothread() is hold. This seems to have been forgotten in some places, and this series aims to fix that. Patch 1 was part of my RFC block layer series "block layer: split block APIs in graph and I/O" but I decided to do a separate series for these two bugs, as they are independent from the API split. Signed-off-by: Emanuele Giuseppe Esposito Emanuele Giuseppe Esposito (2): migration: block-dirty-bitmap: add missing qemu_mutex_lock_iothread migration: add missing qemu_mutex_lock_iothread in migration_completion migration/block-dirty-bitmap.c | 5 ++++- migration/migration.c | 3 +++ 2 files changed, 7 insertions(+), 1 deletion(-)