mbox series

[RFC,v1,0/2] Improvements to SIGP handling [QEMU]

Message ID 20211008203811.1980478-1-farman@linux.ibm.com (mailing list archive)
Headers show
Series Improvements to SIGP handling [QEMU] | expand

Message

Eric Farman Oct. 8, 2021, 8:38 p.m. UTC 
I'm cleaning up some of the SIGP code in KVM and QEMU,
and would like to propose the following changes.

Patch 1 should be less concerning than its KVM counterpart,
since the CZAM bit in question is already present in QEMU.

Patch 2 provides some handshaking with KVM. Since QEMU
injects a Stop IRQ for a couple of the SIGP orders, we
can provide the flags associated with it, to provide some
direction for how KVM should process it.

While this has no dependency on the KVM code, the KVM series
that I'm working on in parallel is here:

https://lore.kernel.org/r/20211008203112.1979843-1-farman@linux.ibm.com/

Eric Farman (2):
  s390x: sigp: Force Set Architecture to return Invalid Parameter
  s390x/kvm: Pass SIGP Stop flags

 target/s390x/kvm/kvm.c |  4 ++++
 target/s390x/sigp.c    | 18 +-----------------
 2 files changed, 5 insertions(+), 17 deletions(-)

Comments

Thomas Huth Oct. 12, 2021, 6:58 a.m. UTC | #1 
On 08/10/2021 22.38, Eric Farman wrote:
> I'm cleaning up some of the SIGP code in KVM and QEMU,
> and would like to propose the following changes.
> 
> Patch 1 should be less concerning than its KVM counterpart,
> since the CZAM bit in question is already present in QEMU.
> 
> Patch 2 provides some handshaking with KVM. Since QEMU
> injects a Stop IRQ for a couple of the SIGP orders, we
> can provide the flags associated with it, to provide some
> direction for how KVM should process it.
> 
> While this has no dependency on the KVM code, the KVM series
> that I'm working on in parallel is here:
> 
> https://lore.kernel.org/r/20211008203112.1979843-1-farman@linux.ibm.com/
> 
> Eric Farman (2):
>    s390x: sigp: Force Set Architecture to return Invalid Parameter
>    s390x/kvm: Pass SIGP Stop flags
> 
>   target/s390x/kvm/kvm.c |  4 ++++
>   target/s390x/sigp.c    | 18 +-----------------
>   2 files changed, 5 insertions(+), 17 deletions(-)
> 

FYI, I've queued the first patch to my s390x-next branch:

https://gitlab.com/thuth/qemu/-/commits/s390x-next

... for the second patch, I'll wait for the discussion to settle.

  Thomas