[0/2] failover: fix a regression introduced by JSON'ification of -device

Message

Laurent Vivier Oct. 19, 2021, 7:15 a.m. UTC

Kevin's series "qdev: Add JSON -device" has introduced a regression
in failover by removing the QemuOpts parameter.

This series fixes that (see PATCH 1) and also makes some cleanup
in the hide_device function caller to remove the failover specific
code from qdev_device_add_from_qdict() and clarify the fact that
a primary device must have an id.

Laurent Vivier (2):
  failover: fix a regression introduced by JSON'ification of -device
  qdev/qbus: remove failover specific code

 hw/net/virtio-net.c    | 36 +++++++++++++++++++++++++++++-------
 softmmu/qdev-monitor.c | 18 ++++++------------
 2 files changed, 35 insertions(+), 19 deletions(-)

Comments

Kevin Wolf Oct. 19, 2021, 10:54 a.m. UTC | #1

Am 19.10.2021 um 09:15 hat Laurent Vivier geschrieben:
> Kevin's series "qdev: Add JSON -device" has introduced a regression
> in failover by removing the QemuOpts parameter.
> 
> This series fixes that (see PATCH 1) and also makes some cleanup
> in the hide_device function caller to remove the failover specific
> code from qdev_device_add_from_qdict() and clarify the fact that
> a primary device must have an id.

Reviewed-by: Kevin Wolf <[e-mail]>