| Message ID | 20211029230147.2465055-1-philmd@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | hw/core: Remove uses of obsolete QERR_ definitions | expand |
On 10/30/21 01:01, Philippe Mathieu-Daudé wrote: > QERR_ definitions are obsolete since 2015... Remove their > uses in hw/core/. > > Philippe Mathieu-Daudé (5): > hw/core: Remove use of QERR_UNSUPPORTED > hw/core: Remove use of QERR_FEATURE_DISABLED > hw/core: Remove uses of QERR_DEVICE_NO_HOTPLUG > hw/core: Remove uses of QERR_PROPERTY_VALUE_BAD > hw/core: Remove uses of QERR_INVALID_PARAMETER_VALUE > > include/qapi/qmp/qerror.h | 6 ------ > hw/core/machine-qmp-cmds.c | 3 ++- > hw/core/nmi.c | 2 +- > hw/core/qdev-properties-system.c | 2 +- > hw/core/qdev-properties.c | 2 +- > hw/core/qdev.c | 3 ++- > monitor/misc.c | 3 +-- > softmmu/cpus.c | 3 +-- > softmmu/qdev-monitor.c | 9 ++++----- > target/i386/cpu.c | 2 +- > 10 files changed, 14 insertions(+), 21 deletions(-) > Hi Philippe, In my patches you just pulled (patch 9). There is a new QERR_INVALID_PARAMETER_VALUE in qdev-monitor.c. Maybe it is worth fixing it as well. anyway Reviewed-by: Damien Hedde <damien.hedde@greensocs.com> Thanks, Damien
On 11/2/21 10:51, Damien Hedde wrote: > On 10/30/21 01:01, Philippe Mathieu-Daudé wrote: >> QERR_ definitions are obsolete since 2015... Remove their >> uses in hw/core/. >> >> Philippe Mathieu-Daudé (5): >> hw/core: Remove use of QERR_UNSUPPORTED >> hw/core: Remove use of QERR_FEATURE_DISABLED >> hw/core: Remove uses of QERR_DEVICE_NO_HOTPLUG >> hw/core: Remove uses of QERR_PROPERTY_VALUE_BAD >> hw/core: Remove uses of QERR_INVALID_PARAMETER_VALUE >> >> include/qapi/qmp/qerror.h | 6 ------ >> hw/core/machine-qmp-cmds.c | 3 ++- >> hw/core/nmi.c | 2 +- >> hw/core/qdev-properties-system.c | 2 +- >> hw/core/qdev-properties.c | 2 +- >> hw/core/qdev.c | 3 ++- >> monitor/misc.c | 3 +-- >> softmmu/cpus.c | 3 +-- >> softmmu/qdev-monitor.c | 9 ++++----- >> target/i386/cpu.c | 2 +- >> 10 files changed, 14 insertions(+), 21 deletions(-) >> > > Hi Philippe, > > In my patches you just pulled (patch 9). There is a new > QERR_INVALID_PARAMETER_VALUE in qdev-monitor.c. Maybe it is worth > fixing it as well. I didn't want to delay your series and miss the soft freeze for this cleanup, so I decided to let it go and get it merged after the release, eventually via QAPI or qemu-trivial tree. > anyway > Reviewed-by: Damien Hedde <damien.hedde@greensocs.com> Thanks :)
Philippe Mathieu-Daudé <philmd@redhat.com> writes: > QERR_ definitions are obsolete since 2015... Remove their > uses in hw/core/. Eleven down, 220 to go. Thanks!