From patchwork Wed Nov 10 13:56:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 12612213 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87351C433F5 for ; Wed, 10 Nov 2021 13:58:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B794610FC for ; Wed, 10 Nov 2021 13:58:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4B794610FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:59324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mko7s-0003LW-CI for qemu-devel@archiver.kernel.org; Wed, 10 Nov 2021 08:58:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40178) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mko5U-0007wL-7h for qemu-devel@nongnu.org; Wed, 10 Nov 2021 08:56:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:33263) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mko5R-0006ys-4e for qemu-devel@nongnu.org; Wed, 10 Nov 2021 08:56:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636552583; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=24BlDxfagQyKFv/HBo2XI9MsFX0dLK513/DBIwKf61g=; b=i2q9b83R3/oXedXLWByMkghrSx4yBTe1i94pd/OsGNRpR+K12s7wqVzG+RyU4Ey+AxAAC9 xEY7JouVgkkFqqNVg0Dx97alOERgQcaDIh3VDSKIK7/LF4w0A2R3ckOhjQx7ih0JMah9dj /UwrrDpkjZHJlZC4c6jmbkzbEhPOT64= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-406-AyhOW9azMcmIma3GXLkQPA-1; Wed, 10 Nov 2021 08:56:20 -0500 X-MC-Unique: AyhOW9azMcmIma3GXLkQPA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CB5B710144E3; Wed, 10 Nov 2021 13:56:19 +0000 (UTC) Received: from thinkpad.redhat.com (unknown [10.39.194.156]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6BB5760854; Wed, 10 Nov 2021 13:56:17 +0000 (UTC) From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PATCH 0/3] tests/qtest: add some tests for virtio-net failover Date: Wed, 10 Nov 2021 14:56:13 +0100 Message-Id: <20211110135616.1188725-1-lvivier@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lvivier@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=lvivier@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Laurent Vivier , Thomas Huth , qemu-block@nongnu.org, "Michael S. Tsirkin" , Markus Armbruster , Hanna Reitz , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This series adds a qtest entry to test virtio-net failover feature. We check following error cases: - check missing id on device with failover_pair_id triggers an error - check a primary device plugged on a bus that doesn't support hotplug triggers an error We check the status of the machine before and after hotplugging cards and feature negotiation: - check we don't see the primary device at boot if failover is on - check we see the primary device at boot if failover is off - check we don't see the primary device if failover is on but failover_pair_id is not the one with on (I think this should be changed) - check the primary device is plugged after the feature negotiation - check the result if the primary device is plugged before standby device and vice-versa - check the if the primary device is coldplugged and the standy device hotplugged and vice-versa - check the migration triggers the unplug -> this one needs to be improved as we can't actualy unplug the card as the qtest framework doesn't allow to really do the OS level unplug. So we receive the UNPLUG_PRIMARY event but nothing more. There are two preliminary patches in the series: - PATCH 1 makes available functions that helped me to debug the qmp command result. I think it's a good point to have them available widely - PATCH 2 introduces a function to enable PCI bridge. Failover needs to be plugged on a pcie-root-port and while the root port is not configured the cards behind it are not available Laurent Vivier (3): qdict: make available dump_qobject(), dump_qdict(), dump_qlist() qtest/libqos: add a function to initialize secondary PCI buses tests/qtest: add some tests for virtio-net failover block/qapi.c | 82 +---- include/hw/pci/pci_bridge.h | 8 + include/qapi/qmp/qdict.h | 2 + include/qapi/qmp/qlist.h | 1 + include/qapi/qmp/qobject.h | 1 + qobject/qdict.c | 25 ++ qobject/qlist.c | 17 + qobject/qobject.c | 35 ++ tests/qtest/libqos/pci.c | 118 +++++++ tests/qtest/libqos/pci.h | 1 + tests/qtest/meson.build | 3 + tests/qtest/virtio-net-failover.c | 567 ++++++++++++++++++++++++++++++ 12 files changed, 779 insertions(+), 81 deletions(-) create mode 100644 tests/qtest/virtio-net-failover.c