From patchwork Fri Nov 19 09:07:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 12628519 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D478AC433F5 for ; Fri, 19 Nov 2021 09:11:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6681261A86 for ; Fri, 19 Nov 2021 09:11:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6681261A86 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:47372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnzvJ-0005Hh-F0 for qemu-devel@archiver.kernel.org; Fri, 19 Nov 2021 04:11:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnzsH-0003PV-Cf for qemu-devel@nongnu.org; Fri, 19 Nov 2021 04:08:01 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:57376) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnzsF-0003jg-A8 for qemu-devel@nongnu.org; Fri, 19 Nov 2021 04:08:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637312878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5xNdXmgbCCfPfPFx/7UZit2eQi+15580AcgIWScTNqU=; b=giEl6kaiEcsWSiHMp7JfOc7Dxn3RtWStKBcEty8oubFHJQ/1GnfiLMYLXJrRTnH7UFwGyh oDsrrcwZHydcWygpJ5HmcXp/IpEmz6XMmAOofMBsKPB9N6n1TP5QElmy8yzf1Wd/a1XmZT jie9t9haIRsZgLeEtM0znA/pxjbJ3uQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-252-v-9A7Yp0Pb6nJhGXNEQK1g-1; Fri, 19 Nov 2021 04:07:55 -0500 X-MC-Unique: v-9A7Yp0Pb6nJhGXNEQK1g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7B0FF87504B; Fri, 19 Nov 2021 09:07:54 +0000 (UTC) Received: from thinkpad.redhat.com (unknown [10.39.194.176]) by smtp.corp.redhat.com (Postfix) with ESMTP id 256845D740; Fri, 19 Nov 2021 09:07:19 +0000 (UTC) From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PATCH v5 0/4] tests/qtest: add some tests for virtio-net failover Date: Fri, 19 Nov 2021 10:07:14 +0100 Message-Id: <20211119090718.440793-1-lvivier@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lvivier@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=lvivier@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , =?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= , Juan Quintela , Michael Roth , "Michael S. Tsirkin" , Gerd Hoffmann , Igor Mammedov , Ani Sinha , Paolo Bonzini , Jens Freimann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This series adds a qtest entry to test virtio-net failover feature. We check following error cases: - check missing id on device with failover_pair_id triggers an error - check a primary device plugged on a bus that doesn't support hotplug triggers an error We check the status of the machine before and after hotplugging cards and feature negotiation: - check we don't see the primary device at boot if failover is on - check we see the primary device at boot if failover is off - check we don't see the primary device if failover is on but failover_pair_id is not the one with on (I think this should be changed) - check the primary device is plugged after the feature negotiation - check the result if the primary device is plugged before standby device and vice-versa - check the if the primary device is coldplugged and the standy device hotplugged and vice-versa - check the migration triggers the unplug and the hotplug There is one preliminary patch in the series: - PATCH 1 introduces a function to enable PCI bridge. Failover needs to be plugged on a pcie-root-port and while the root port is not configured the cards behind it are not available v5: - re-add the wait-unplug test that has been removed from v4 by mistake. v4: - rely on query-migrate status to know the migration state rather than to wait the STOP event. - remove the patch to add time out to qtest_qmp_eventwait() v3: - fix a bug with ACPI unplug and add the related test v2: - remove PATCH 1 that introduced a function that can be replaced by qobject_to_json_pretty() (Markus) - Add migration to a file and from the file to check the card is correctly unplugged on the source, and hotplugged on the dest - Add an ACPI call to eject the card as the kernel would do Laurent Vivier (4): qtest/libqos: add a function to initialize secondary PCI buses tests/qtest: add some tests for virtio-net failover failover: fix unplug pending detection tests/libqtest: update virtio-net failover test hw/acpi/pcihp.c | 30 +- include/hw/pci/pci_bridge.h | 8 + tests/qtest/libqos/pci.c | 118 ++++++ tests/qtest/libqos/pci.h | 1 + tests/qtest/meson.build | 3 + tests/qtest/virtio-net-failover.c | 681 ++++++++++++++++++++++++++++++ 6 files changed, 838 insertions(+), 3 deletions(-) create mode 100644 tests/qtest/virtio-net-failover.c Reviewed-by: Michael S. Tsirkin