From patchwork Wed Dec 8 13:03:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 12664429 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CCB1C433EF for ; Wed, 8 Dec 2021 13:09:49 +0000 (UTC) Received: from localhost ([::1]:56062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1muwhg-0000je-Ec for qemu-devel@archiver.kernel.org; Wed, 08 Dec 2021 08:09:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muwdo-0006PG-80 for qemu-devel@nongnu.org; Wed, 08 Dec 2021 08:05:48 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:27973) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muwdm-0001Qb-9M for qemu-devel@nongnu.org; Wed, 08 Dec 2021 08:05:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638968745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=01GZZu5laj8TvuAx4bhibvExTxwAU76XCxYMfmr9e8w=; b=Tl8wmCUzOMiKFYW0pF8J8eA3XjmcO9jqf2Ue84akx2GyUEJUvE8wNaYJyaQZo6TQaNZoiT XkMZuYj9hVtAnYBuuPs7mSbDPgRPftqSdiI9cXNvcvnuOioZDhKMFqV13wQ7Cs4tG2wMWC PIHkctyMY97R3hwsQ1J5AkCPuqZ86Z4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-431-cvOY2u6-PzKF7Fijq2_HWQ-1; Wed, 08 Dec 2021 08:04:32 -0500 X-MC-Unique: cvOY2u6-PzKF7Fijq2_HWQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7868E805747 for ; Wed, 8 Dec 2021 13:04:31 +0000 (UTC) Received: from thinkpad.redhat.com (unknown [10.39.192.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id E60D66107E; Wed, 8 Dec 2021 13:03:51 +0000 (UTC) From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PATCH v8 0/4] tests/qtest: add some tests for virtio-net failover Date: Wed, 8 Dec 2021 14:03:46 +0100 Message-Id: <20211208130350.10178-1-lvivier@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lvivier@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=lvivier@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.619, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Juan Quintela , "Michael S. Tsirkin" , Paolo Bonzini , Jens Freimann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This series adds a qtest entry to test virtio-net failover feature. We check following error cases: - check missing id on device with failover_pair_id triggers an error - check a primary device plugged on a bus that doesn't support hotplug triggers an error We check the status of the machine before and after hotplugging cards and feature negotiation: - check we don't see the primary device at boot if failover is on - check we see the primary device at boot if failover is off - check we don't see the primary device if failover is on but failover_pair_id is not the one with on (I think this should be changed) - check the primary device is plugged after the feature negotiation - check the result if the primary device is plugged before standby device and vice-versa - check the if the primary device is coldplugged and the standy device hotplugged and vice-versa - check the migration triggers the unplug and the hotplug There is one preliminary patch in the series: - PATCH 1 introduces a function to enable PCI bridge. Failover needs to be plugged on a pcie-root-port and while the root port is not configured the cards behind it are not available v8: - fix checkpatch.pl error (space after "(") - fix sanitizer errors: * migrate_status() qobject_unref() cleanup * release QVirtioPCIDevice with qos_object_destroy() * add a missing g_free() in qpci_secondary_buses_rec() * add qobject_unref() in get_bus() and find_device() when an object is popped from a list. v7: - merge patch 3 and 4 as the fix for ACPI unplug has been merged - address Thomas' comments - add a dependency on slirp in meson.build - check FAILOVER_NEGOCIATED device-id and MIGRATION status on destination, update UNPLUG_PRIMARY event checking - fix an object_unref() in test_migrate_abort_active() - fix typo s/whan/when/ v6: - manage more than 2 root ports - add a function to check if a card is available or not - check migration state - add cancelled migration test cases - rename tests v5: - re-add the wait-unplug test that has been removed from v4 by mistake. v4: - rely on query-migrate status to know the migration state rather than to wait the STOP event. - remove the patch to add time out to qtest_qmp_eventwait() v3: - fix a bug with ACPI unplug and add the related test v2: - remove PATCH 1 that introduced a function that can be replaced by qobject_to_json_pretty() (Markus) - Add migration to a file and from the file to check the card is correctly unplugged on the source, and hotplugged on the dest - Add an ACPI call to eject the card as the kernel would do Laurent Vivier (4): qtest/libqos: add a function to initialize secondary PCI buses tests/qtest: add some tests for virtio-net failover test/libqtest: add some virtio-net failover migration cancelling tests tests/libqtest: add a migration test with two couples of failover devices include/hw/pci/pci_bridge.h | 8 + tests/qtest/libqos/pci.c | 119 +++ tests/qtest/libqos/pci.h | 1 + tests/qtest/meson.build | 4 + tests/qtest/virtio-net-failover.c | 1352 +++++++++++++++++++++++++++++ 5 files changed, 1484 insertions(+) create mode 100644 tests/qtest/virtio-net-failover.c