| Message ID | 20211228193806.1198496-1-danielhb413@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ppc/pnv: enable pnv-phb4 user devices | expand |
Hello Daniel, On 12/28/21 20:37, Daniel Henrique Barboza wrote: > Hi, > > This series implements pnv-phb4 user devices for the powernv9 machine. > It also includes a couple of pnv-phb3 and pnv-phb3-root-port fixes that > were also applied for the pnv4 equivalents. > > During the enablement I had to rollback from the previously added > support for user creatable pnv-phb4-pec devices. The most important > reason is user experience. PEC devices that doesn't spawn the PHB > devices will be just a placeholder to add PHBs, having no use of their > own as far as the user sees it. From this standpoint it makes more sense > to just create all PECs and attach the PHBs the user wants on them. > Patch 14 also describes technical reasons to rollback this support. > > The series is rebased using Cedric's 'powernv-6.2' branch [1]i, which > includes the '[PATCH 0/5] ppc/pnv: Preliminary cleanups before user > created PHBs' patches [2]. It would be easier if you based the patchset on mainline. It's not a problem to resend patches of another person or/and even rework them to fit your needs. Thanks, C.
On 1/3/22 05:21, Cédric Le Goater wrote: > Hello Daniel, > > On 12/28/21 20:37, Daniel Henrique Barboza wrote: >> Hi, >> >> This series implements pnv-phb4 user devices for the powernv9 machine. >> It also includes a couple of pnv-phb3 and pnv-phb3-root-port fixes that >> were also applied for the pnv4 equivalents. >> >> During the enablement I had to rollback from the previously added >> support for user creatable pnv-phb4-pec devices. The most important >> reason is user experience. PEC devices that doesn't spawn the PHB >> devices will be just a placeholder to add PHBs, having no use of their >> own as far as the user sees it. From this standpoint it makes more sense >> to just create all PECs and attach the PHBs the user wants on them. >> Patch 14 also describes technical reasons to rollback this support. >> >> The series is rebased using Cedric's 'powernv-6.2' branch [1]i, which >> includes the '[PATCH 0/5] ppc/pnv: Preliminary cleanups before user >> created PHBs' patches [2]. > > It would be easier if you based the patchset on mainline. It's not > a problem to resend patches of another person or/and even rework > them to fit your needs. Sure, I'll send the v2 based on the mainline + the required patches. Thanks, Daniel > > Thanks, > > C.
On 1/3/22 19:58, Daniel Henrique Barboza wrote: > > > On 1/3/22 05:21, Cédric Le Goater wrote: >> Hello Daniel, >> >> On 12/28/21 20:37, Daniel Henrique Barboza wrote: >>> Hi, >>> >>> This series implements pnv-phb4 user devices for the powernv9 machine. >>> It also includes a couple of pnv-phb3 and pnv-phb3-root-port fixes that >>> were also applied for the pnv4 equivalents. >>> >>> During the enablement I had to rollback from the previously added >>> support for user creatable pnv-phb4-pec devices. The most important >>> reason is user experience. PEC devices that doesn't spawn the PHB >>> devices will be just a placeholder to add PHBs, having no use of their >>> own as far as the user sees it. From this standpoint it makes more sense >>> to just create all PECs and attach the PHBs the user wants on them. >>> Patch 14 also describes technical reasons to rollback this support. >>> >>> The series is rebased using Cedric's 'powernv-6.2' branch [1]i, which >>> includes the '[PATCH 0/5] ppc/pnv: Preliminary cleanups before user >>> created PHBs' patches [2]. >> >> It would be easier if you based the patchset on mainline. It's not >> a problem to resend patches of another person or/and even rework >> them to fit your needs. > > Sure, I'll send the v2 based on the mainline + the required patches. Let me merge a couple first. It should reduce the overhead. I will drop these : ppc/pnv: Attach PHB3 root port device when defaults are enabled ppc/pnv: Attach PHB4 root port device when defaults are enabled They are in the way for your changes. Thanks, C.
On 1/3/22 18:20, Cédric Le Goater wrote: > On 1/3/22 19:58, Daniel Henrique Barboza wrote: >> >> >> On 1/3/22 05:21, Cédric Le Goater wrote: >>> Hello Daniel, >>> >>> On 12/28/21 20:37, Daniel Henrique Barboza wrote: >>>> Hi, >>>> >>>> This series implements pnv-phb4 user devices for the powernv9 machine. >>>> It also includes a couple of pnv-phb3 and pnv-phb3-root-port fixes that >>>> were also applied for the pnv4 equivalents. >>>> >>>> During the enablement I had to rollback from the previously added >>>> support for user creatable pnv-phb4-pec devices. The most important >>>> reason is user experience. PEC devices that doesn't spawn the PHB >>>> devices will be just a placeholder to add PHBs, having no use of their >>>> own as far as the user sees it. From this standpoint it makes more sense >>>> to just create all PECs and attach the PHBs the user wants on them. >>>> Patch 14 also describes technical reasons to rollback this support. >>>> >>>> The series is rebased using Cedric's 'powernv-6.2' branch [1]i, which >>>> includes the '[PATCH 0/5] ppc/pnv: Preliminary cleanups before user >>>> created PHBs' patches [2]. >>> >>> It would be easier if you based the patchset on mainline. It's not >>> a problem to resend patches of another person or/and even rework >>> them to fit your needs. >> >> Sure, I'll send the v2 based on the mainline + the required patches. > > Let me merge a couple first. It should reduce the overhead. I will drop > these : No problem. I'll re-send the v2 after the merge. > > ppc/pnv: Attach PHB3 root port device when defaults are enabled > ppc/pnv: Attach PHB4 root port device when defaults are enabled > > They are in the way for your changes. I`ll drop these in my side as well. Thanks, Daniel > > Thanks, > > C.
On 12/28/21 20:37, Daniel Henrique Barboza wrote: > Hi, > > This series implements pnv-phb4 user devices for the powernv9 machine. > It also includes a couple of pnv-phb3 and pnv-phb3-root-port fixes that > were also applied for the pnv4 equivalents. > > During the enablement I had to rollback from the previously added > support for user creatable pnv-phb4-pec devices. The most important > reason is user experience. PEC devices that doesn't spawn the PHB > devices will be just a placeholder to add PHBs, having no use of their > own as far as the user sees it. From this standpoint it makes more sense > to just create all PECs and attach the PHBs the user wants on them. > Patch 14 also describes technical reasons to rollback this support. > > The series is rebased using Cedric's 'powernv-6.2' branch [1]i, which > includes the '[PATCH 0/5] ppc/pnv: Preliminary cleanups before user > created PHBs' patches [2]. > > [1] https://github.com/legoater/qemu/tree/powernv-6.2 > [2] https://lists.gnu.org/archive/html/qemu-devel/2021-12/msg03810.html Applied patches 2-16 in ppc-next. Thanks, C.