From patchwork Tue Jan 4 08:54:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12703266 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 976DFC433EF for ; Tue, 4 Jan 2022 08:57:14 +0000 (UTC) Received: from localhost ([::1]:37366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n4fd3-0001tV-FI for qemu-devel@archiver.kernel.org; Tue, 04 Jan 2022 03:57:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4faW-0007ZN-SV; Tue, 04 Jan 2022 03:54:36 -0500 Received: from [2a00:1450:4864:20::429] (port=39447 helo=mail-wr1-x429.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n4faV-0007nI-6q; Tue, 04 Jan 2022 03:54:36 -0500 Received: by mail-wr1-x429.google.com with SMTP id s1so74689328wra.6; Tue, 04 Jan 2022 00:54:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6b+AzP7QtPC4iYk44vVICIt8IMgGta8unOAFiOt1PK8=; b=c57EwDbL1aq4UfIaTJ5g2cnJEpifhScHxIqhPgYX2r97Zbt6Q//b0MoX0+mwiK+agH OebGr8KGNed8LbrKBnZpgJkg6GeC6kyNerdOr9xS8raQLZzwzr5SXbTV7O7ZXpPnNawN C5aX0WKne3ar8OzQSZLze2Y5CNGGDMmuXm44i2nw4okH20wQhqGTK8vVpkmurbOm92Ca qcimJkL+D4ayJavAFKUdO9vJLmI/95fh2lRXknJXkU4ivsvCy5vviCOUttOps3isyZqH EtpWpCtDLb+LBC9HIPDvYUnSUIkLkYSxYD+urPEEgFc72536gMxkNONalUnZWZuLudsI Meqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=6b+AzP7QtPC4iYk44vVICIt8IMgGta8unOAFiOt1PK8=; b=Qqu5hlxXLMezT0qGqpeU92/bXcgBW1OSMWwPXEjnR0GrMDSWtcv2P4LgW3PJICZ+ij O2+3KQauV/ARTRCUS6jjcLlMeKWJEcp5znHoHBsBsq1lLvuRJIIEj0egEZgIAeQYVodp bFf3bvOPTbu5bm2qJL3qTe4XI9JEIkJNFmkqucxlx5M3MP2exMPhQvOF2ldujcjNaUAy wm3hdlnAKtCWge4WmZbKOZ5vNO6qek+Oab/8+4ZIpNe/89SRdMU9Vnnbmdis7Yb2cglN WfGOAg2NgYQjQYh1hDbLltInvtbenPQcMRyh/JC5VXuvXksXh39QodsdROEuldXLJK4e OaiQ== X-Gm-Message-State: AOAM533snFT+N1YV3PQ8yGUJ8ibc7Us1PemXa95NmnnF5rSy9P4h52Io qEWG83g16sgazC2Lz8kb/bOK6QzBZosKTw== X-Google-Smtp-Source: ABdhPJxTJmC6bWam5S+efkthT2v/gu0qRx69monBJhttFhexNt/TXmYOHd9fUrxPfCjWM2h1S+9cHQ== X-Received: by 2002:a5d:6e8a:: with SMTP id k10mr34621994wrz.113.1641286473209; Tue, 04 Jan 2022 00:54:33 -0800 (PST) Received: from x1w.. (26.red-83-50-86.dynamicip.rima-tde.net. [83.50.86.26]) by smtp.gmail.com with ESMTPSA id b14sm35520421wri.112.2022.01.04.00.54.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jan 2022 00:54:32 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 0/9] hw/dma: Use dma_addr_t type definition when relevant Date: Tue, 4 Jan 2022 09:54:22 +0100 Message-Id: <20220104085431.2122999-1-f4bug@amsat.org> X-Mailer: git-send-email 2.33.1 MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::429 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x429.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Hannes Reinecke , qemu-block@nongnu.org, "Michael S. Tsirkin" , David Hildenbrand , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Xu , Yuval Shaia , Klaus Jensen , Keith Busch , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Since v1: - Addressed David review comment (stick to dma_addr_t type) - Addressed Peter review comment (incorrect doc string) Hi, This series aims to clarify a bit the DMA API, in particular the 'size' argument which is not clear enough (as we use multiple types for it). This helps avoiding build failures on 32-bit host [*] (and likely overflows calculation too IMO). Some units using the DMA API are first removed from user-mode emulation to avoid build failure (they shouldn't be there in the first place). Then some variables are renamed for clarity (no functional change). Finally we replace misuses with dma_addr_t typedef. The previous patch which failed on 32-bit host applied on top (not failing anymore). Regards, Phil. [*] https://www.mail-archive.com/qemu-devel@nongnu.org/msg858825.html Supersedes: <20211231114901.976937-1-philmd@redhat.com> Philippe Mathieu-Daudé (9): hw/nvram: Restrict stub to sysemu and tools hw/pci: Restrict pci-bus stub to sysemu hw/pci: Document pci_dma_map() hw/dma: Remove CONFIG_USER_ONLY check hw/rdma/rdma_utils: Rename rdma_pci_dma_map 'len' argument hw/scsi: Rename SCSIRequest::resid as 'residual' hw/dma: Fix format string issues using dma_addr_t hw/dma: Use dma_addr_t type definition when relevant hw/dma: Let dma_buf_read() / dma_buf_write() propagate MemTxResult hw/rdma/rdma_utils.h | 2 +- include/hw/pci/pci.h | 12 ++++++ include/hw/scsi/scsi.h | 4 +- include/sysemu/dma.h | 31 ++++++++------- hw/ide/ahci.c | 10 ++--- hw/nvme/ctrl.c | 6 +-- hw/rdma/rdma_utils.c | 14 +++---- hw/scsi/megasas.c | 85 +++++++++++++++++++++++++++++------------- hw/scsi/scsi-bus.c | 12 +++--- hw/scsi/scsi-disk.c | 4 +- softmmu/dma-helpers.c | 34 +++++++---------- hw/nvram/meson.build | 6 ++- hw/rdma/trace-events | 2 +- stubs/meson.build | 4 +- 14 files changed, 134 insertions(+), 92 deletions(-) Reviewed-by: Michael S. Tsirkin