[v4,0/1] Patch to adjust coroutine pool size adaptively

Message

成川 弘樹 Feb. 14, 2022, 11:53 a.m. UTC

Resending with correct commit message

Resending patch with decreasing coroutine pool size on device remove

We encountered random disk IO performance drop since qemu-5.0.0, and this patch fixes it.

Commit message in 4d68e86b implied to adjust coroutine pool size adaptively, so I tried to implement this.

Changes from v3:
No code changed. Changed commit message so that first line indicates to
correct commit ID.

Changes from v2:
Decrease coroutine pool size on device remove

Changes from v1:
Use qatomic_read properly

Hiroki Narukawa (1):
  util: adjust coroutine pool size to virtio block queue

 hw/block/virtio-blk.c    |  5 +++++
 include/qemu/coroutine.h | 10 ++++++++++
 util/qemu-coroutine.c    | 20 ++++++++++++++++----
 3 files changed, 31 insertions(+), 4 deletions(-)

Comments

Stefan Hajnoczi Feb. 14, 2022, 5:11 p.m. UTC | #1

On Mon, Feb 14, 2022 at 08:53:01PM +0900, Hiroki Narukawa wrote:
> Resending with correct commit message
> 
> Resending patch with decreasing coroutine pool size on device remove
> 
> We encountered random disk IO performance drop since qemu-5.0.0, and this patch fixes it.
> 
> Commit message in 4d68e86b implied to adjust coroutine pool size adaptively, so I tried to implement this.
> 
> Changes from v3:
> No code changed. Changed commit message so that first line indicates to
> correct commit ID.
> 
> Changes from v2:
> Decrease coroutine pool size on device remove
> 
> Changes from v1:
> Use qatomic_read properly
> 
> Hiroki Narukawa (1):
>   util: adjust coroutine pool size to virtio block queue
> 
>  hw/block/virtio-blk.c    |  5 +++++
>  include/qemu/coroutine.h | 10 ++++++++++
>  util/qemu-coroutine.c    | 20 ++++++++++++++++----
>  3 files changed, 31 insertions(+), 4 deletions(-)
> 
> -- 
> 2.17.1
> 

Thanks, applied to my block tree:
https://gitlab.com/stefanha/qemu/commits/block

Stefan