| Message ID | 20220504173025.650167-1-marcandre.lureau@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Misc cleanups | expand |
Looks good apart from the two patches I comment on. Paolo Il 4 maggio 2022 19:30:09 CEST, marcandre.lureau@redhat.com ha scritto: >From: Marc-André Lureau <marcandre.lureau@redhat.com> > >Hi, > >Perhaps the last series of preliminary patches before I propose a longer series >to add qemu-common & qga meson subprojects. That's why they are mostly >QGA-related cleanups. > >Thanks for the reviews! > >Marc-André Lureau (16): > include: move qemu_*_exec_dir() to cutils > util/win32: simplify qemu_get_local_state_dir() > tests: make libqmp buildable for win32 > compiler.h: add QEMU_{BEGIN,END}_IGNORE_INITIALIZER_OVERRIDES > qobject/json-lexer: disable -Winitializer-overrides warnings > include: adjust header guards after renaming > qga: flatten safe_open_or_create() > osdep: export qemu_open_cloexec() > qga: use qemu_open_cloexec() for safe_open_or_create() > qapi/error: add g_autoptr(Error) support > qga: replace qemu_open_old() with qemu_open_cloexec() > test/qga: use G_TEST_DIR to locate os-release test file > qga/wixl: prefer variables over environment > qga/wixl: require Mingw_bin > qga/wixl: simplify some pre-processing > qga/wixl: replace QEMU_GA_MSI_MINGW_BIN_PATH with glib bindir > > configure | 9 +- > meson.build | 5 +- > include/qapi/error.h | 2 + > include/qemu/compiler.h | 11 ++ > include/qemu/cutils.h | 7 ++ > include/qemu/help-texts.h | 4 +- > include/qemu/osdep.h | 9 +- > tests/qtest/libqmp.h | 2 + > qemu-io.c | 1 + > qga/channel-posix.c | 18 ++-- > qga/commands-posix.c | 146 +++++++++++++-------------- > qobject/json-lexer.c | 4 + > storage-daemon/qemu-storage-daemon.c | 1 + > tests/qtest/fuzz/fuzz.c | 1 + > tests/qtest/libqmp.c | 35 +++++-- > tests/unit/test-qga.c | 11 +- > util/cutils.c | 108 ++++++++++++++++++++ > util/osdep.c | 10 +- > util/oslib-posix.c | 81 --------------- > util/oslib-win32.c | 53 +--------- > qga/installer/qemu-ga.wxs | 83 +++++---------- > qga/meson.build | 11 +- > 22 files changed, 313 insertions(+), 299 deletions(-) >
From: Marc-André Lureau <marcandre.lureau@redhat.com> Hi, Perhaps the last series of preliminary patches before I propose a longer series to add qemu-common & qga meson subprojects. That's why they are mostly QGA-related cleanups. Thanks for the reviews! Marc-André Lureau (16): include: move qemu_*_exec_dir() to cutils util/win32: simplify qemu_get_local_state_dir() tests: make libqmp buildable for win32 compiler.h: add QEMU_{BEGIN,END}_IGNORE_INITIALIZER_OVERRIDES qobject/json-lexer: disable -Winitializer-overrides warnings include: adjust header guards after renaming qga: flatten safe_open_or_create() osdep: export qemu_open_cloexec() qga: use qemu_open_cloexec() for safe_open_or_create() qapi/error: add g_autoptr(Error) support qga: replace qemu_open_old() with qemu_open_cloexec() test/qga: use G_TEST_DIR to locate os-release test file qga/wixl: prefer variables over environment qga/wixl: require Mingw_bin qga/wixl: simplify some pre-processing qga/wixl: replace QEMU_GA_MSI_MINGW_BIN_PATH with glib bindir configure | 9 +- meson.build | 5 +- include/qapi/error.h | 2 + include/qemu/compiler.h | 11 ++ include/qemu/cutils.h | 7 ++ include/qemu/help-texts.h | 4 +- include/qemu/osdep.h | 9 +- tests/qtest/libqmp.h | 2 + qemu-io.c | 1 + qga/channel-posix.c | 18 ++-- qga/commands-posix.c | 146 +++++++++++++-------------- qobject/json-lexer.c | 4 + storage-daemon/qemu-storage-daemon.c | 1 + tests/qtest/fuzz/fuzz.c | 1 + tests/qtest/libqmp.c | 35 +++++-- tests/unit/test-qga.c | 11 +- util/cutils.c | 108 ++++++++++++++++++++ util/osdep.c | 10 +- util/oslib-posix.c | 81 --------------- util/oslib-win32.c | 53 +--------- qga/installer/qemu-ga.wxs | 83 +++++---------- qga/meson.build | 11 +- 22 files changed, 313 insertions(+), 299 deletions(-)