From patchwork Wed Oct 19 12:52:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eugenio Perez Martin X-Patchwork-Id: 13011711 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E523BC43217 for ; Wed, 19 Oct 2022 13:02:30 +0000 (UTC) Received: from localhost ([::1]:53160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ol8iL-0001v0-CD for qemu-devel@archiver.kernel.org; Wed, 19 Oct 2022 09:02:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36424) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ol8Yg-0005tw-6w for qemu-devel@nongnu.org; Wed, 19 Oct 2022 08:52:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:33105) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ol8Yd-0002Gc-17 for qemu-devel@nongnu.org; Wed, 19 Oct 2022 08:52:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666183945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yu6+ZMnyRMzz8DCissTykVrm3bd+EJbtvyNtvffS1zE=; b=AbIFMwVeOnMCHQ1c5OPuihxX+M4993JdIrd9pGcthLyKFAVemG6JLh2TuSXNtFIyDJbeTH zNVBromN4mM+zeUMVK3kwPuLlqemRHbKk0TDNuBqlwavmihym6YzIyPeCrG29GQhpM069D HEyTVJS87CD7buxmO9IBEQwSvqFROXo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-219-MemkbNqIPke_eZwCzC7uFA-1; Wed, 19 Oct 2022 08:52:18 -0400 X-MC-Unique: MemkbNqIPke_eZwCzC7uFA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D5137185A792; Wed, 19 Oct 2022 12:52:17 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.192.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7224E4081B60; Wed, 19 Oct 2022 12:52:15 +0000 (UTC) From: =?utf-8?q?Eugenio_P=C3=A9rez?= To: qemu-devel@nongnu.org Cc: Zhu Lingshan , Harpreet Singh Anand , Stefano Garzarella , Si-Wei Liu , Jason Wang , "Michael S. Tsirkin" , Cindy Lu , Laurent Vivier , Eli Cohen , Liuxiangdong , Parav Pandit , Gautam Dawar Subject: [RFC PATCH v2 0/8] Guest announce feature emulation using Shadow VirtQueue Date: Wed, 19 Oct 2022 14:52:02 +0200 Message-Id: <20221019125210.226291-1-eperezma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Received-SPF: pass client-ip=170.10.129.124; envelope-from=eperezma@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.256, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" A gratuitous ARP is recommended after a live migration to reduce the amount of time needed by the network links to be aware of the new location. A hypervisor may not have the knowledge of the guest network configuration, and this is especially true on passthrough devices, so its simpler to ask the guest to do it. However, the device control part of this feature can be totally emulated by qemu and shadow virtqueue, not needing any special feature from the actual vdpa device. VIRTIO_NET_F_STATUS is also needed for the guest to access the status of virtio net config where announcement status bit is set. Emulating it as always active in case backend does not support it. v2: * Add VIRTIO_NET_F_STATUS emulation. Eugenio Pérez (8): vdpa: Delete duplicated vdpa_feature_bits entry vdpa: Save emulated features list in vhost_vdpa vhost_net: Emulate link state up if backend doesn't expose it vdpa: Expose VIRTIO_NET_F_STATUS unconditionally vdpa: Remove shadow CVQ command check vdpa: handle VIRTIO_NET_CTRL_ANNOUNCE in vhost_vdpa_net_handle_ctrl_avail vhost_net: return VIRTIO_NET_S_ANNOUNCE is device model has it set vdpa: Offer VIRTIO_NET_F_GUEST_ANNOUNCE feature if SVQ is enabled include/hw/virtio/vhost-vdpa.h | 2 + hw/net/vhost_net.c | 35 +++++++++++++++- hw/virtio/vhost-vdpa.c | 8 ++-- net/vhost-vdpa.c | 74 ++++++++++------------------------ 4 files changed, 62 insertions(+), 57 deletions(-)