Message ID | 20221025084952.2139888-1-eesposit@redhat.com (mailing list archive) |
---|---|
Headers | show |
Series | Refactor bdrv_try_set_aio_context using transactions | expand |
Am 25.10.2022 um 10:49 hat Emanuele Giuseppe Esposito geschrieben: > The aim of this series is to reorganize bdrv_try_set_aio_context > and drop BDS ->set_aio_context and ->can_set_aio_ctx callbacks in > favour of a new one, ->change_aio_ctx. > > More informations in patch 3 (which is also RFC, due to the doubts > I have with AioContext locks). > > Patch 1 just add assertions in the code, 2 extends the transactions API to be able to add also transactions in the tail > of the list. > Patch 3 is the core of this series, and introduces the new callback. > It is marked as RFC and the reason is explained in the commit message. > Patches 4-5-6 implement ->change_aio_ctx in the various block, blockjob > and block-backend BDSes. > Patch 7 substitutes ->change_aio_ctx with the old callbacks, and > patch 8 takes care of deleting the old callbacks and unused code. > > This series is based on "job: replace AioContext lock with job_mutex", > but just because it uses job_set_aio_context() introduced there. > > Suggested-by: Paolo Bonzini <pbonzini@redhat.com> > Based-on: <20220706201533.289775-1-eesposit@redhat.com> > --- > v3: > * add aiocontext lock acquire/remove around bdrv_detach_aio_context > * typos and nitpicks > * remove patch 4: bdrv_child_try_change_aio_context: add transaction parameter Thanks, applied to the block branch. Kevin