From patchwork Thu Oct 27 18:58:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Snow X-Patchwork-Id: 13022636 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DB95FA3740 for ; Thu, 27 Oct 2022 19:30:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oo86y-0002bx-AR; Thu, 27 Oct 2022 15:00:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo86u-0002b7-0R for qemu-devel@nongnu.org; Thu, 27 Oct 2022 15:00:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo86r-0006vb-NH for qemu-devel@nongnu.org; Thu, 27 Oct 2022 15:00:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666897207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XwjCKwZkYO76WGB1XuQy+uVijiHxFq5fTbHZ5p4xypA=; b=TwXmgaTEDFiwpctowiqpGLquj+v7QuMj2aH8COMTTE1wF4mXRcJUCELvFwMqju7jxW7dKl oLlSiWAE8eVqkFK2l51rGgazgHVhRW3gpyRaSyToo+rat20BCHZdwY+Th2UQV4wuX87emP UD906HHkj/5y4XhxfzGseG2evOlTj8M= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-1-vf3X8GOWMBa3YNfGc8FA8w-1; Thu, 27 Oct 2022 14:59:03 -0400 X-MC-Unique: vf3X8GOWMBa3YNfGc8FA8w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DE184101A5B3 for ; Thu, 27 Oct 2022 18:58:36 +0000 (UTC) Received: from scv.redhat.com (unknown [10.22.33.29]) by smtp.corp.redhat.com (Postfix) with ESMTP id 94AFA2024CB7; Thu, 27 Oct 2022 18:58:36 +0000 (UTC) From: John Snow To: qemu-devel@nongnu.org Cc: John Snow , =?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= , Cleber Rosa , Beraldo Leal Subject: [PATCH v2 0/2] python: misc machine.py improvements Date: Thu, 27 Oct 2022 14:58:34 -0400 Message-Id: <20221027185836.1455810-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.515, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Qemu-devel" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Improve machine.py logging and fix a shutdown bug that we *probably* weren't actually hitting anywhere. Changes for console input logging are on the way, but separate because it will touch avocado. More comprehensive fixes for multiple socket polling are also on the way, but decidedly separate. This is the simple stuff that might make it easier to diagnose failures in the meantime. V2: - Adjusted messages just a pinch. (Can't leave well enough alone.) - Added exc_info=True for a log message in the shutdown failover case. (danpb) John Snow (2): python/machine: Add debug logging to key state changes python/machine: Handle termination cases without QMP python/qemu/machine/machine.py | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+)