From patchwork Tue Nov 1 14:55:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Akihiko Odaki X-Patchwork-Id: 13027280 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B88DC4332F for ; Tue, 1 Nov 2022 17:28:20 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1opsgY-0006mo-SN; Tue, 01 Nov 2022 10:56:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opsgX-0006mE-I9 for qemu-devel@nongnu.org; Tue, 01 Nov 2022 10:56:13 -0400 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1opsgT-0003Fp-7h for qemu-devel@nongnu.org; Tue, 01 Nov 2022 10:56:13 -0400 Received: by mail-pl1-x634.google.com with SMTP id 4so13820648pli.0 for ; Tue, 01 Nov 2022 07:56:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=NzRNXyzMHzpUT2aPtRhgR6GeDDKNKPP691o2qPYLJos=; b=bDfIdk7BhGMZhX7pDDPw31QnIRs6q5cCpp3eOk2EKonzJyB7H7fGq//kahVVSrUmsZ Igpnw/tR2ZDXHsSqzfqHSFO9Aa3KvuHCGu/3uBvgo8sIC7daOocDa6RMs2RJ4k3U9SYb u77Y+xh2bcDE2T7CXIzPE1daq+AvSU6xPd4xYue/7gjL63bjXuvukE7Up3ejnM/lVFAI 8tdXOyDsZ5R0KnbwhM68d15o2/OOj0ToDYhl/lAqt203VhMX8skB5JUDjq5rJFdRNlJu LRPA41f+xC/w9uiaF6zzuA6ysmOSj/0pvQXV5P+s083Pd60W2RhOxTUDB03fGP2LNng6 vzKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NzRNXyzMHzpUT2aPtRhgR6GeDDKNKPP691o2qPYLJos=; b=5Z9/+y5Mv0arMxhltzQgOG+3zV9NxvR/iQHfQ+HKE1uRZhr3pRGGfTZkPlNLHP6Xmw ay8EoZo0SYptQdABN4b8A7DCujGj9kjZKtEgzz7dVFq+hZ9WZIQMIzyTCDZ0ymMEUql2 DdKUuWw7uCwUomfFDpCoDZBqcd1HET1KwbZCkqgo9967+lKg9xL2vNqBA7uQiimmXbsD 2rnh1yH5Tu+p1pbaGSm4R1LF8hiwRQVffycuzL+JLNKbWQv1iRw5quNK5h2amLLVi7D4 ksBdRzDeLQqw0UZQoOza4BLfpaR8wFK50s7+dA6brGpPNxibTkVUWZCrviRrt4tFcrjU YBPg== X-Gm-Message-State: ACrzQf2VpfnaSd/kaqtTpgL0EfkADHcUVaHfmAd+7g2v8ztXUScskEKL G9khOZfIwgfvQ2ni8ZN02fzIeFzCXJ69/2z4 X-Google-Smtp-Source: AMsMyM7bYTw+PRLCQD0fc0WJJPqEmfNP6Who+t8xKFRDXcepnUSgnEXhMt31dzB98FJtaymsYKR81A== X-Received: by 2002:a17:90b:1e49:b0:20b:36a3:aba6 with SMTP id pi9-20020a17090b1e4900b0020b36a3aba6mr38881079pjb.2.1667314567446; Tue, 01 Nov 2022 07:56:07 -0700 (PDT) Received: from fedora.flets-east.jp ([2400:4050:c360:8200:8ae8:3c4:c0da:7419]) by smtp.gmail.com with ESMTPSA id 22-20020a631656000000b0046f9f4a2de6sm4783219pgw.74.2022.11.01.07.56.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Nov 2022 07:56:06 -0700 (PDT) From: Akihiko Odaki To: Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, qemu-arm@nongnu.org, "Michael S . Tsirkin" , Marcel Apfelbaum , Gerd Hoffmann , Paolo Bonzini , Richard Henderson , Eduardo Habkost , John Snow , Dmitry Fleytman , Jason Wang , Stefan Weil , Keith Busch , Klaus Jensen , Peter Maydell , Andrey Smirnov , Paul Burton , Aleksandar Rikalo , Yan Vugenfirer , Yuri Benditovich , =?utf-8?q?Philippe_Mathieu-?= =?utf-8?q?Daud=C3=A9?= , Akihiko Odaki Subject: [PATCH v9 00/17] pci: Abort if pci_add_capability fails Date: Tue, 1 Nov 2022 23:55:41 +0900 Message-Id: <20221101145558.3998-1-akihiko.odaki@daynix.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Received-SPF: none client-ip=2607:f8b0:4864:20::634; envelope-from=akihiko.odaki@daynix.com; helo=mail-pl1-x634.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Qemu-devel" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org pci_add_capability appears most PCI devices. Its error handling required lots of code, and led to inconsistent behaviors such as: - passing error_abort - passing error_fatal - asserting the returned value - propagating the error to the caller - skipping the rest of the function - just ignoring The code generating errors in pci_add_capability had a comment which says: > Verify that capabilities don't overlap. Note: device assignment > depends on this check to verify that the device is not broken. > Should never trigger for emulated devices, but it's helpful for > debugging these. Indeed vfio has some code that passes capability offsets and sizes from a physical device, but it explicitly pays attention so that the capabilities never overlap and the only exception are MSI and MSI-X capabilities. Therefore, we can add code specific to the case, and always assert that capabilities never overlap in the other cases, resolving these inconsistencies. v9: - Return correct value with pci_check_capability_overlap() (Philippe Mathieu-Daudé) - Use scripts/git.orderfile (Philippe Mathieu-Daudé) - Simplify error checking in pci_add_capability() (Philippe Mathieu-Daudé) - Improve comments (Philippe Mathieu-Daudé) v8: - Return boolean with pci_check_capability_overlap() (Philippe Mathieu-Daudé) v7: - Perform checks in vfio_msi_setup() and vfio_msix_setup() (Alex Williamson) v6: - Error in case of MSI/MSI-X capability overlap (Alex Williamson) v5: - Fix capability ID specification in vfio_msi_early_setup (Alex Williamson) - Use range_covers_byte() (Alex Williamson) - warn_report() in case of MSI/MSI-X capability overlap (Alex Williamson) v4: - Fix typos in messages (Markus Armbruster) - hw/vfio/pci: Ensure MSI and MSI-X do not overlap (Alex Williamson) v3: - Correct patch split between virtio-pci and pci (Markus Armbruster) - Add messages for individual patches (Markus Armbruster) - Acked-by: Jonathan Cameron Akihiko Odaki (17): hw/vfio/pci: Ensure MSI and MSI-X do not overlap pci: Allow to omit errp for pci_add_capability hw/i386/amd_iommu: Omit errp for pci_add_capability ahci: Omit errp for pci_add_capability e1000e: Omit errp for pci_add_capability eepro100: Omit errp for pci_add_capability hw/nvme: Omit errp for pci_add_capability msi: Omit errp for pci_add_capability hw/pci/pci_bridge: Omit errp for pci_add_capability pcie: Omit errp for pci_add_capability pci/shpc: Omit errp for pci_add_capability msix: Omit errp for pci_add_capability pci/slotid: Omit errp for pci_add_capability hw/pci-bridge/pcie_pci_bridge: Omit errp for pci_add_capability hw/vfio/pci: Omit errp for pci_add_capability virtio-pci: Omit errp for pci_add_capability pci: Remove legacy errp from pci_add_capability docs/pcie_sriov.txt | 4 +-- include/hw/pci/pci.h | 12 +++++-- include/hw/pci/pci_bridge.h | 5 ++- include/hw/pci/pcie.h | 11 +++---- include/hw/pci/shpc.h | 3 +- include/hw/virtio/virtio-pci.h | 2 +- hw/display/bochs-display.c | 4 +-- hw/i386/amd_iommu.c | 21 +++--------- hw/ide/ich.c | 8 ++--- hw/net/e1000e.c | 22 +++---------- hw/net/eepro100.c | 7 +--- hw/nvme/ctrl.c | 14 ++------ hw/pci-bridge/cxl_downstream.c | 9 ++---- hw/pci-bridge/cxl_upstream.c | 8 ++--- hw/pci-bridge/i82801b11.c | 14 ++------ hw/pci-bridge/pci_bridge_dev.c | 2 +- hw/pci-bridge/pcie_pci_bridge.c | 19 +++-------- hw/pci-bridge/pcie_root_port.c | 16 ++------- hw/pci-bridge/xio3130_downstream.c | 15 ++------- hw/pci-bridge/xio3130_upstream.c | 15 ++------- hw/pci-host/designware.c | 3 +- hw/pci-host/xilinx-pcie.c | 4 +-- hw/pci/msi.c | 9 +----- hw/pci/msix.c | 8 ++--- hw/pci/pci.c | 47 +++++++++++++-------------- hw/pci/pci_bridge.c | 21 ++++-------- hw/pci/pcie.c | 52 ++++++++---------------------- hw/pci/shpc.c | 23 ++++--------- hw/pci/slotid_cap.c | 8 ++--- hw/usb/hcd-xhci-pci.c | 3 +- hw/vfio/pci-quirks.c | 15 ++------- hw/vfio/pci.c | 29 +++++++++++------ hw/virtio/virtio-pci.c | 12 ++----- 33 files changed, 136 insertions(+), 309 deletions(-)