mbox series

[v3,for-7.2,0/6] Add format attributes and fix format strings

Message ID 20221126152507.283271-1-sw@weilnetz.de (mailing list archive)
Headers show
Series Add format attributes and fix format strings | expand

Message

Stefan Weil Nov. 26, 2022, 3:25 p.m. UTC 
v3:
- Fix description for patch 3
- Add patches 5 and 6

The patches 3 and 5 still need reviews!

[PATCH v3 for-7.2 1/6] libvhost-user: Fix wrong type of argument to
[PATCH v3 for-7.2 2/6] libvhost-user: Fix format strings
[PATCH v3 for-7.2 3/6] libvhost-user: Fix two more format strings
[PATCH v3 for-7.2 4/6] libvhost-user: Add format attribute to local
[PATCH v3 for-7.2 5/6] MAINTAINERS: Add subprojects/libvhost-user to
[PATCH v3 for-7.2 6/6] Add G_GNUC_PRINTF to function

Comments

Stefan Hajnoczi Nov. 27, 2022, 6:23 p.m. UTC | #1 
We need to wait for Michael to agree to maintainership in patch 5. If
we run out of time I suggest splitting out patch 5.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Stefan Weil Nov. 27, 2022, 6:31 p.m. UTC | #2 
Am 27.11.22 um 19:23 schrieb Stefan Hajnoczi:

> We need to wait for Michael to agree to maintainership in patch 5. If
> we run out of time I suggest splitting out patch 5.
>
> Reviewed-by: Stefan Hajnoczi<stefanha@redhat.com>


Citing Michael from a v2 email: "pls do".

Stefan


>     Hello Michael,
>
>     I just noticed that MAINTAINERS has no entry for the files in
>     subprojects/libvhost-user, so I did not cc you in my previous e-mails.
>     Should that directory be added to the "vhost" section"?
>
>     Stefan

    pls do
Stefan Hajnoczi Nov. 27, 2022, 6:38 p.m. UTC | #3 
On Sun, 27 Nov 2022 at 13:31, Stefan Weil <sw@weilnetz.de> wrote:
>
> Am 27.11.22 um 19:23 schrieb Stefan Hajnoczi:
>
> We need to wait for Michael to agree to maintainership in patch 5. If
> we run out of time I suggest splitting out patch 5.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>
>
> Citing Michael from a v2 email: "pls do".
>
> Stefan
>
>
> Hello Michael,
>
> I just noticed that MAINTAINERS has no entry for the files in
> subprojects/libvhost-user, so I did not cc you in my previous e-mails.
> Should that directory be added to the "vhost" section"?
>
> Stefan
>
> pls do

Perfect, thank you! I have added a reference to that email in the
commit description.

This series is running through CI now and will be merged upon success
later today.

Thanks,
Stefan
Stefan Hajnoczi Nov. 28, 2022, 12:31 a.m. UTC | #4 
Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes.
Michael S. Tsirkin Nov. 28, 2022, 10:29 a.m. UTC | #5 
On Sat, Nov 26, 2022 at 04:25:01PM +0100, Stefan Weil wrote:
> v3:
> - Fix description for patch 3
> - Add patches 5 and 6
> 
> The patches 3 and 5 still need reviews!

Series:
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

Stefan you said you want to merge this?

> [PATCH v3 for-7.2 1/6] libvhost-user: Fix wrong type of argument to
> [PATCH v3 for-7.2 2/6] libvhost-user: Fix format strings
> [PATCH v3 for-7.2 3/6] libvhost-user: Fix two more format strings
> [PATCH v3 for-7.2 4/6] libvhost-user: Add format attribute to local
> [PATCH v3 for-7.2 5/6] MAINTAINERS: Add subprojects/libvhost-user to
> [PATCH v3 for-7.2 6/6] Add G_GNUC_PRINTF to function
Stefan Hajnoczi Nov. 28, 2022, 11:05 a.m. UTC | #6 
On Mon, Nov 28, 2022, 05:29 Michael S. Tsirkin <mst@redhat.com> wrote:

> On Sat, Nov 26, 2022 at 04:25:01PM +0100, Stefan Weil wrote:
> > v3:
> > - Fix description for patch 3
> > - Add patches 5 and 6
> >
> > The patches 3 and 5 still need reviews!
>
> Series:
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>
> Stefan you said you want to merge this?
>

Yes.

Stefan

>