mbox series

[v12,0/1] vhost-vdpa: add support for vIOMMU

Message ID 20221209130805.3614970-1-lulu@redhat.com (mailing list archive)
Headers show
Series vhost-vdpa: add support for vIOMMU | expand

Message

Cindy Lu Dec. 9, 2022, 1:08 p.m. UTC
These patches are to support vIOMMU in vdpa device
Verified in vp_vdpa/vdpa_sim_net driverand intel_iommu
virtio-iommu device

changes in V3
1. Move function vfio_get_xlat_addr to memory.c
2. Use the existing memory listener, while the MR is
iommu MR then call the function iommu_region_add/
iommu_region_del

changes in V4
1.make the comments in vfio_get_xlat_addr more general

changes in V5
1. Address the comments in the last version
2. Add a new arg in the function vfio_get_xlat_addr, which shows whether
the memory is backed by a discard manager. So the device can have its
own warning.

changes in V6
move the error_report for the unpopulated discard back to
memeory_get_xlat_addr

changes in V7
organize the error massage to avoid the duplicate information

changes in V8
Organize the code follow the comments in the last version

changes in V9
Organize the code follow the comments

changes in V10
Address the comments

changes in V11
Address the comments
fix the crash found in test

changes in V12
Address the comments, squash patch 1 into the next patch
improve the code style issue

Cindy Lu (1):
  vhost-vdpa: add support for vIOMMU

 hw/virtio/vhost-vdpa.c         | 162 ++++++++++++++++++++++++++++++---
 include/hw/virtio/vhost-vdpa.h |  10 ++
 2 files changed, 161 insertions(+), 11 deletions(-)

Comments

Michael S. Tsirkin Dec. 20, 2022, 2:33 p.m. UTC | #1
On Fri, Dec 09, 2022 at 09:08:04PM +0800, Cindy Lu wrote:
> These patches are to support vIOMMU in vdpa device
> Verified in vp_vdpa/vdpa_sim_net driverand intel_iommu
> virtio-iommu device

Pls address comments and repost.

> changes in V3
> 1. Move function vfio_get_xlat_addr to memory.c
> 2. Use the existing memory listener, while the MR is
> iommu MR then call the function iommu_region_add/
> iommu_region_del
> 
> changes in V4
> 1.make the comments in vfio_get_xlat_addr more general
> 
> changes in V5
> 1. Address the comments in the last version
> 2. Add a new arg in the function vfio_get_xlat_addr, which shows whether
> the memory is backed by a discard manager. So the device can have its
> own warning.
> 
> changes in V6
> move the error_report for the unpopulated discard back to
> memeory_get_xlat_addr
> 
> changes in V7
> organize the error massage to avoid the duplicate information
> 
> changes in V8
> Organize the code follow the comments in the last version
> 
> changes in V9
> Organize the code follow the comments
> 
> changes in V10
> Address the comments
> 
> changes in V11
> Address the comments
> fix the crash found in test
> 
> changes in V12
> Address the comments, squash patch 1 into the next patch
> improve the code style issue
> 
> Cindy Lu (1):
>   vhost-vdpa: add support for vIOMMU
> 
>  hw/virtio/vhost-vdpa.c         | 162 ++++++++++++++++++++++++++++++---
>  include/hw/virtio/vhost-vdpa.h |  10 ++
>  2 files changed, 161 insertions(+), 11 deletions(-)
> 
> -- 
> 2.34.3
Cindy Lu Dec. 21, 2022, 6:13 a.m. UTC | #2
On Tue, 20 Dec 2022 at 22:33, Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Fri, Dec 09, 2022 at 09:08:04PM +0800, Cindy Lu wrote:
> > These patches are to support vIOMMU in vdpa device
> > Verified in vp_vdpa/vdpa_sim_net driverand intel_iommu
> > virtio-iommu device
>
> Pls address comments and repost.
>
Hi Micheal
There are some issues found while dpdk running with svq enable
we are still working on it, and will post a new version after we
address the bugs
Thanks
Cindy
> > changes in V3
> > 1. Move function vfio_get_xlat_addr to memory.c
> > 2. Use the existing memory listener, while the MR is
> > iommu MR then call the function iommu_region_add/
> > iommu_region_del
> >
> > changes in V4
> > 1.make the comments in vfio_get_xlat_addr more general
> >
> > changes in V5
> > 1. Address the comments in the last version
> > 2. Add a new arg in the function vfio_get_xlat_addr, which shows whether
> > the memory is backed by a discard manager. So the device can have its
> > own warning.
> >
> > changes in V6
> > move the error_report for the unpopulated discard back to
> > memeory_get_xlat_addr
> >
> > changes in V7
> > organize the error massage to avoid the duplicate information
> >
> > changes in V8
> > Organize the code follow the comments in the last version
> >
> > changes in V9
> > Organize the code follow the comments
> >
> > changes in V10
> > Address the comments
> >
> > changes in V11
> > Address the comments
> > fix the crash found in test
> >
> > changes in V12
> > Address the comments, squash patch 1 into the next patch
> > improve the code style issue
> >
> > Cindy Lu (1):
> >   vhost-vdpa: add support for vIOMMU
> >
> >  hw/virtio/vhost-vdpa.c         | 162 ++++++++++++++++++++++++++++++---
> >  include/hw/virtio/vhost-vdpa.h |  10 ++
> >  2 files changed, 161 insertions(+), 11 deletions(-)
> >
> > --
> > 2.34.3
>