mbox series

[v2,0/7] Clean up dependencies of ACPI controllers

Message ID 20221216130355.41667-1-shentey@gmail.com (mailing list archive)
Headers show
Series Clean up dependencies of ACPI controllers | expand

Message

Bernhard Beschow Dec. 16, 2022, 1:03 p.m. UTC
This small series establishes consistency between ICH9, PIIX4 and VT82C686 ACPI
controllers to select ACPI, ACPI_SMBUS and APM since they are provided by the
device models.

Due to the PIIX4 PM cleanup PEGASOS2's dependency can be reduced to just ACPI,
eliminating 9 dependencies from the softmmu-ppc build.

v2:
- Turn "depends on ACPI" into "select ACPI" (Phil)
- Remove "select ACPI" from PEGASOS2 (Phil)
- Move already reviewed patches to bottom
- Split some patches into "add missing dependencies" and "remove redundant
  dependencies" for ease of review

Bernhard Beschow (7):
  hw/acpi/Kconfig: Rename ACPI_X86_ICH to ACPI_ICH9
  hw/acpi/Kconfig: Add missing dependencies to ACPI_ICH9
  hw/acpi/Kconfig: Do not needlessly build TYPE_PIIX4_PM in non-PC/Malta
    machines
  hw/acpi/Kconfig: Add missing dependencies to ACPI_PIIX4
  hw/isa/Kconfig: Add missing dependency to VT82C686
  i386, mips: Resolve redundant ACPI and APM dependencies
  hw/ppc/Kconfig: Remove unused dependencies from PEGASOS2

 configs/devices/mips-softmmu/common.mak | 3 ---
 hw/acpi/Kconfig                         | 9 ++++++---
 hw/acpi/meson.build                     | 2 +-
 hw/i2c/meson.build                      | 2 +-
 hw/i386/Kconfig                         | 3 +--
 hw/isa/Kconfig                          | 4 ++--
 hw/ppc/Kconfig                          | 2 --
 7 files changed, 11 insertions(+), 14 deletions(-)

Comments

Bernhard Beschow Dec. 17, 2022, 9:35 p.m. UTC | #1
Am 16. Dezember 2022 13:03:48 UTC schrieb Bernhard Beschow <shentey@gmail.com>:
>This small series establishes consistency between ICH9, PIIX4 and VT82C686 ACPI
>
>controllers to select ACPI, ACPI_SMBUS and APM since they are provided by the
>
>device models.
>
>
>
>Due to the PIIX4 PM cleanup PEGASOS2's dependency can be reduced to just ACPI,
>
>eliminating 9 dependencies from the softmmu-ppc build.
>
>
>
>v2:
>
>- Turn "depends on ACPI" into "select ACPI" (Phil)
>
>- Remove "select ACPI" from PEGASOS2 (Phil)
>

Ping

Patches 4 & 6 still need review.

>- Move already reviewed patches to bottom
>
>- Split some patches into "add missing dependencies" and "remove redundant
>
>  dependencies" for ease of review
>
>
>
>Bernhard Beschow (7):
>
>  hw/acpi/Kconfig: Rename ACPI_X86_ICH to ACPI_ICH9
>
>  hw/acpi/Kconfig: Add missing dependencies to ACPI_ICH9
>
>  hw/acpi/Kconfig: Do not needlessly build TYPE_PIIX4_PM in non-PC/Malta
>
>    machines
>
>  hw/acpi/Kconfig: Add missing dependencies to ACPI_PIIX4
>
>  hw/isa/Kconfig: Add missing dependency to VT82C686
>
>  i386, mips: Resolve redundant ACPI and APM dependencies
>
>  hw/ppc/Kconfig: Remove unused dependencies from PEGASOS2
>
>
>
> configs/devices/mips-softmmu/common.mak | 3 ---
>
> hw/acpi/Kconfig                         | 9 ++++++---
>
> hw/acpi/meson.build                     | 2 +-
>
> hw/i2c/meson.build                      | 2 +-
>
> hw/i386/Kconfig                         | 3 +--
>
> hw/isa/Kconfig                          | 4 ++--
>
> hw/ppc/Kconfig                          | 2 --
>
> 7 files changed, 11 insertions(+), 14 deletions(-)
>
>
>
>-- >
>2.39.0
>
>
>
Bernhard Beschow Dec. 21, 2022, 5:56 p.m. UTC | #2
Am 16. Dezember 2022 13:03:48 UTC schrieb Bernhard Beschow <shentey@gmail.com>:
>This small series establishes consistency between ICH9, PIIX4 and VT82C686 ACPI
>
>controllers to select ACPI, ACPI_SMBUS and APM since they are provided by the
>
>device models.
>
>
>
>Due to the PIIX4 PM cleanup PEGASOS2's dependency can be reduced to just ACPI,
>
>eliminating 9 dependencies from the softmmu-ppc build.
>

Ping

Looks like all patches are reviewed, i.e. ready to be queued.

Best regards,
Bernhard

>
>
>v2:
>
>- Turn "depends on ACPI" into "select ACPI" (Phil)
>
>- Remove "select ACPI" from PEGASOS2 (Phil)
>
>- Move already reviewed patches to bottom
>
>- Split some patches into "add missing dependencies" and "remove redundant
>
>  dependencies" for ease of review
>
>
>
>Bernhard Beschow (7):
>
>  hw/acpi/Kconfig: Rename ACPI_X86_ICH to ACPI_ICH9
>
>  hw/acpi/Kconfig: Add missing dependencies to ACPI_ICH9
>
>  hw/acpi/Kconfig: Do not needlessly build TYPE_PIIX4_PM in non-PC/Malta
>
>    machines
>
>  hw/acpi/Kconfig: Add missing dependencies to ACPI_PIIX4
>
>  hw/isa/Kconfig: Add missing dependency to VT82C686
>
>  i386, mips: Resolve redundant ACPI and APM dependencies
>
>  hw/ppc/Kconfig: Remove unused dependencies from PEGASOS2
>
>
>
> configs/devices/mips-softmmu/common.mak | 3 ---
>
> hw/acpi/Kconfig                         | 9 ++++++---
>
> hw/acpi/meson.build                     | 2 +-
>
> hw/i2c/meson.build                      | 2 +-
>
> hw/i386/Kconfig                         | 3 +--
>
> hw/isa/Kconfig                          | 4 ++--
>
> hw/ppc/Kconfig                          | 2 --
>
> 7 files changed, 11 insertions(+), 14 deletions(-)
>
>
>
>-- >
>2.39.0
>
>
>
Michael S. Tsirkin Dec. 21, 2022, 7:11 p.m. UTC | #3
On Wed, Dec 21, 2022 at 05:56:56PM +0000, Bernhard Beschow wrote:
> 
> 
> Am 16. Dezember 2022 13:03:48 UTC schrieb Bernhard Beschow <shentey@gmail.com>:
> >This small series establishes consistency between ICH9, PIIX4 and VT82C686 ACPI
> >
> >controllers to select ACPI, ACPI_SMBUS and APM since they are provided by the
> >
> >device models.
> >
> >
> >
> >Due to the PIIX4 PM cleanup PEGASOS2's dependency can be reduced to just ACPI,
> >
> >eliminating 9 dependencies from the softmmu-ppc build.
> >
> 
> Ping
> 
> Looks like all patches are reviewed, i.e. ready to be queued.
> 
> Best regards,
> Bernhard


Sure, next pull.

> >
> >
> >v2:
> >
> >- Turn "depends on ACPI" into "select ACPI" (Phil)
> >
> >- Remove "select ACPI" from PEGASOS2 (Phil)
> >
> >- Move already reviewed patches to bottom
> >
> >- Split some patches into "add missing dependencies" and "remove redundant
> >
> >  dependencies" for ease of review
> >
> >
> >
> >Bernhard Beschow (7):
> >
> >  hw/acpi/Kconfig: Rename ACPI_X86_ICH to ACPI_ICH9
> >
> >  hw/acpi/Kconfig: Add missing dependencies to ACPI_ICH9
> >
> >  hw/acpi/Kconfig: Do not needlessly build TYPE_PIIX4_PM in non-PC/Malta
> >
> >    machines
> >
> >  hw/acpi/Kconfig: Add missing dependencies to ACPI_PIIX4
> >
> >  hw/isa/Kconfig: Add missing dependency to VT82C686
> >
> >  i386, mips: Resolve redundant ACPI and APM dependencies
> >
> >  hw/ppc/Kconfig: Remove unused dependencies from PEGASOS2
> >
> >
> >
> > configs/devices/mips-softmmu/common.mak | 3 ---
> >
> > hw/acpi/Kconfig                         | 9 ++++++---
> >
> > hw/acpi/meson.build                     | 2 +-
> >
> > hw/i2c/meson.build                      | 2 +-
> >
> > hw/i386/Kconfig                         | 3 +--
> >
> > hw/isa/Kconfig                          | 4 ++--
> >
> > hw/ppc/Kconfig                          | 2 --
> >
> > 7 files changed, 11 insertions(+), 14 deletions(-)
> >
> >
> >
> >-- >
> >2.39.0
> >
> >
> >